From: Jonas Fonseca <fonseca@diku.dk>
To: Drew Northup <n1xim.email@gmail.com>
Cc: git <git@vger.kernel.org>
Subject: Re: [PATCH] TIG: Fix to reinstate proper operation with no arguments
Date: Fri, 19 Jul 2013 00:07:05 -0400 [thread overview]
Message-ID: <CAFuPQ1K=hWUSCEhaGsuW8PeoGQcj6AoPo61zUTDbjLE802h+7g@mail.gmail.com> (raw)
In-Reply-To: <51E7EDE3.4080205@gmail.com>
On Thu, Jul 18, 2013 at 9:30 AM, Drew Northup <n1xim.email@gmail.com> wrote:
>
> Somehow this patch breaks the main view to not open the correct commit in diff view when <enter> is pressed. Back to the debugger...
Does this (possibly white-space damaged) patch work for you?
diff --git a/tig.c b/tig.c
index ba9ba98..74a2928 100644
--- a/tig.c
+++ b/tig.c
@@ -3104,7 +3104,7 @@ format_expand_arg(struct format_context *format,
const char *name)
static bool
format_append_arg(struct format_context *format, const char
***dst_argv, const char *arg)
{
- format->bufpos = 0;
+ format->buf[0] = format->bufpos = 0;
while (arg) {
char *next = strstr(arg, "%(");
--
Jonas Fonseca
next prev parent reply other threads:[~2013-07-19 4:07 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-18 4:51 [PATCH] TIG: Fix to reinstate proper operation with no arguments Drew Northup
2013-07-18 13:30 ` Drew Northup
2013-07-19 4:07 ` Jonas Fonseca [this message]
2013-07-19 11:55 ` Drew Northup
2013-07-24 12:29 ` Drew Northup
2013-07-24 12:50 ` [PATCH V2] " Drew Northup
2013-07-29 1:23 ` Jonas Fonseca
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFuPQ1K=hWUSCEhaGsuW8PeoGQcj6AoPo61zUTDbjLE802h+7g@mail.gmail.com' \
--to=fonseca@diku.dk \
--cc=git@vger.kernel.org \
--cc=n1xim.email@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).