From: Jonas Fonseca <fonseca@diku.dk>
To: Kumar Appaiah <a.kumar@alumni.iitm.ac.in>
Cc: git <git@vger.kernel.org>
Subject: Re: [[TIG][PATCH] 1/3] Add log_select function to find commit from context in log view
Date: Mon, 5 Aug 2013 23:54:00 -0400 [thread overview]
Message-ID: <CAFuPQ1+5O+dBCjHYu2soAtNKiNxofAuWSVEeKBj=yu+kRGggCw@mail.gmail.com> (raw)
In-Reply-To: <1375489399-11618-2-git-send-email-a.kumar@alumni.iitm.ac.in>
On Fri, Aug 2, 2013 at 8:23 PM, Kumar Appaiah <a.kumar@alumni.iitm.ac.in> wrote:
> diff --git a/tig.c b/tig.c
> index 72f132a..dd4b0f4 100644
> --- a/tig.c
> +++ b/tig.c
> @@ -4427,11 +4454,30 @@ log_open(struct view *view, enum open_flags flags)
> static enum request
> log_request(struct view *view, enum request request, struct line *line)
> {
> + struct log_state *state = (struct log_state *) view->private;
> +
> switch (request) {
> case REQ_REFRESH:
> load_refs();
> refresh_view(view);
> return REQ_NONE;
> +
> + case REQ_MOVE_UP:
> + case REQ_PREVIOUS:
> + if (line->type == LINE_COMMIT && line->lineno > 1) {
> + /* We are at a commit, and heading upward. We
> + force log_select to find the previous
> + commit above, from the context. */
> + state->update_commit_ref = TRUE;
> + }
> + return pager_request(view, request, line);
> +
> + case REQ_MOVE_PAGE_UP:
> + case REQ_MOVE_PAGE_DOWN:
> + /* We need to figure out the right commit again. */
> + state->update_commit_ref = TRUE;
> + return pager_request(view, request, line);
> +
> default:
> return pager_request(view, request, line);
> }
I forgot to mention there is one use case this doesn't currently
handle, namely jumping to a specific line using ':<number>'. Other
than detecting this by tracking the current line number in log_state I
haven't come up with a good way to detect that a recalculation is
required.
next prev parent reply other threads:[~2013-08-06 3:54 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-03 0:23 [TIG][PATCH 0/3] Refactoring of the log view Kumar Appaiah
2013-08-03 0:23 ` [[TIG][PATCH] 1/3] Add log_select function to find commit from context in " Kumar Appaiah
2013-08-06 3:27 ` Jonas Fonseca
2013-08-06 4:08 ` Kumar Appaiah
2013-08-06 3:54 ` Jonas Fonseca [this message]
2013-08-03 0:23 ` [[TIG][PATCH] 2/3] Display correct diff the context in split " Kumar Appaiah
2013-08-06 3:50 ` Jonas Fonseca
2013-08-03 0:23 ` [[TIG][PATCH] 3/3] Revert "Scroll diff with arrow keys in log view" Kumar Appaiah
2013-08-06 4:00 ` [TIG][PATCH 0/3] Refactoring of the log view Jonas Fonseca
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFuPQ1+5O+dBCjHYu2soAtNKiNxofAuWSVEeKBj=yu+kRGggCw@mail.gmail.com' \
--to=fonseca@diku.dk \
--cc=a.kumar@alumni.iitm.ac.in \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).