From: Marc Khouzam <marc.khouzam@gmail.com>
To: Felipe Contreras <felipe.contreras@gmail.com>
Cc: "Junio C Hamano" <gitster@pobox.com>,
"SZEDER Gábor" <szeder@ira.uka.de>,
git@vger.kernel.org
Subject: Re: [PATCH] tcsh-completion re-using git-completion.bash
Date: Tue, 20 Nov 2012 09:58:50 -0500 [thread overview]
Message-ID: <CAFj1UpHs08seVH8Kb3CuoNTaF+x6vA+ybVTEu0TyLX8NYuuidQ@mail.gmail.com> (raw)
In-Reply-To: <CAMP44s30wYnkQdq8yup3z-t=FEf1R+k8OC-o7-uY=19z9VHDPg@mail.gmail.com>
On Sat, Nov 17, 2012 at 1:01 PM, Felipe Contreras
<felipe.contreras@gmail.com> wrote:
>
>> I gather that using a wrapper for zsh causes concerns about
>> backwards-compatibility.
>
> I don't see any concerns.
>
>> if [[ -n ${ZSH_VERSION-} ]]; then
>> # replace below by zsh completion commands calling `bash
>> ${HOME}/.git-completion.bash`
>
>> complete git 'p/*/`bash ${HOME}/.git-completion.bash ${COMMAND_LINE}`/'
>> complete gitk 'p/*/`bash ${HOME}/.git-completion.bash ${COMMAND_LINE}`/'
>
> That doesn't work in zsh. It might be possible to do something
> similar, but it would probably require many more lines.
Hi,
since there doesn't seem to be an agreement that the approach to achieve tcsh
git-completion would be useful for zsh (the other possible shell that could use
it is ksh, but I haven't looked into that), maybe the simplest thing
is to keep the
tcsh solution contained in a tcsh-only script. This is the latest solution as
proposed here:
[1] http://www.mail-archive.com/git@vger.kernel.org/msg12192.html
For reference, the more general solution was proposed here:
[2] http://www.mail-archive.com/git@vger.kernel.org/msg12122.html
If there is interest in merging [1], please let me know and I'll post another
version which adds a check to make sure that the user properly copied
git-completion.bash to be used by the new git-completion.tcsh.
Thanks for your input.
Marc
next prev parent reply other threads:[~2012-11-20 14:59 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CAFj1UpE6OtJEojaED1_DZJD0kU=nVsFE_w8xa0oJE-6auCU2rw@mail.gmail.com>
2012-11-12 20:07 ` Fwd: [PATCH] Add tcsh-completion support to contrib by using git-completion.bash Marc Khouzam
2012-11-13 11:14 ` SZEDER Gábor
2012-11-13 20:12 ` Marc Khouzam
2012-11-13 23:46 ` SZEDER Gábor
2012-11-14 0:49 ` [PATCH] completion: remove 'help' duplicate from porcelain commands SZEDER Gábor
2012-11-14 4:26 ` Fwd: [PATCH] Add tcsh-completion support to contrib by using git-completion.bash Marc Khouzam
2012-11-15 11:51 ` [PATCH] tcsh-completion re-using git-completion.bash Marc Khouzam
2012-11-16 1:41 ` Felipe Contreras
2012-11-16 14:39 ` Marc Khouzam
2012-11-16 15:33 ` Felipe Contreras
2012-11-16 15:48 ` Marc Khouzam
2012-11-16 16:12 ` [PATCH v3] " Marc Khouzam
2012-11-16 17:21 ` Felipe Contreras
2012-11-16 18:43 ` [PATCH v4] " Marc Khouzam
2012-11-16 19:59 ` Junio C Hamano
2012-11-16 20:01 ` Felipe Contreras
2012-11-16 17:18 ` [PATCH] " Felipe Contreras
2012-11-16 18:20 ` Marc Khouzam
2012-11-16 20:04 ` Felipe Contreras
2012-11-16 20:40 ` SZEDER Gábor
2012-11-16 21:03 ` Felipe Contreras
2012-11-16 21:22 ` SZEDER Gábor
2012-11-16 21:46 ` Felipe Contreras
2012-11-17 10:56 ` SZEDER Gábor
2012-11-17 11:46 ` Felipe Contreras
2012-11-17 14:17 ` SZEDER Gábor
2012-11-16 21:20 ` Junio C Hamano
2012-11-16 21:56 ` Felipe Contreras
2012-11-17 17:15 ` Marc Khouzam
2012-11-17 18:01 ` Felipe Contreras
2012-11-20 14:58 ` Marc Khouzam [this message]
2012-11-20 15:15 ` Felipe Contreras
2012-11-20 18:20 ` Marc Khouzam
2012-11-20 21:07 ` Junio C Hamano
2012-11-13 18:31 ` [PATCH] Add tcsh-completion support to contrib by using git-completion.bash Felipe Contreras
2012-11-14 0:11 ` SZEDER Gábor
2012-11-15 2:40 ` Felipe Contreras
2012-11-14 3:36 ` Marc Khouzam
2012-11-14 0:09 ` Fwd: " SZEDER Gábor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFj1UpHs08seVH8Kb3CuoNTaF+x6vA+ybVTEu0TyLX8NYuuidQ@mail.gmail.com \
--to=marc.khouzam@gmail.com \
--cc=felipe.contreras@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=szeder@ira.uka.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).