From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marc Khouzam Subject: Re: [PATCH] tcsh-completion re-using git-completion.bash Date: Tue, 20 Nov 2012 13:20:15 -0500 Message-ID: References: <1352980269-15569-1-git-send-email-marc.khouzam@gmail.com> <20121116204017.GX12052@goldbirke> <7vr4ntkzy4.fsf@alter.siamese.dyndns.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Cc: Junio C Hamano , =?ISO-8859-1?Q?SZEDER_G=E1bor?= , git@vger.kernel.org To: Felipe Contreras X-From: git-owner@vger.kernel.org Tue Nov 20 19:20:39 2012 Return-path: Envelope-to: gcvg-git-2@plane.gmane.org Received: from vger.kernel.org ([209.132.180.67]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1TasR3-0004GS-29 for gcvg-git-2@plane.gmane.org; Tue, 20 Nov 2012 19:20:37 +0100 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753697Ab2KTSUW (ORCPT ); Tue, 20 Nov 2012 13:20:22 -0500 Received: from mail-ie0-f174.google.com ([209.85.223.174]:65268 "EHLO mail-ie0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753670Ab2KTSUT (ORCPT ); Tue, 20 Nov 2012 13:20:19 -0500 Received: by mail-ie0-f174.google.com with SMTP id k13so9040601iea.19 for ; Tue, 20 Nov 2012 10:20:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=Ungx6qLkZG/MYkylC9RIneWRfLBl1J69hCDpOM5YuS4=; b=cqMO33iV5nStetnBGTvsE8upJB9qxO5LovQJyvmVJWR12WBecQ0xHXkm1/nB9JHCuo K8nDvHETBgO3FVmxjv/NjOeRK05W9vxQ8x0B2+2JGrp3JMo24FKLZbUmkVJaEFe8613a /+oVQczHXfw1yLn5VAHfn43VNL++l6Wln/cU5ksByZvdOTGRaiMT0v0hBtGrAMJcEdms V/eXCmZq9hZ5CxAm+2+3EY9RCPS5Zl4MVYmvZnjg2JawkrqvmfH/FufaJ4f6IKyIuDtl SzV84ob8RRlptFf+yeQGStMYkHJKMRiUJRD0KubDtQHLihoe7ofF8iVLI1xCtnNc82py NkAw== Received: by 10.50.140.104 with SMTP id rf8mr11143555igb.40.1353435616713; Tue, 20 Nov 2012 10:20:16 -0800 (PST) Received: by 10.64.132.39 with HTTP; Tue, 20 Nov 2012 10:20:15 -0800 (PST) In-Reply-To: Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Archived-At: On Tue, Nov 20, 2012 at 10:15 AM, Felipe Contreras wrote: > On Tue, Nov 20, 2012 at 3:58 PM, Marc Khouzam wrote: > >> Hi, >> >> since there doesn't seem to be an agreement that the approach to achieve tcsh >> git-completion would be useful for zsh (the other possible shell that could use >> it is ksh, but I haven't looked into that), maybe the simplest thing >> is to keep the >> tcsh solution contained in a tcsh-only script. This is the latest solution as >> proposed here: >> >> [1] http://www.mail-archive.com/git@vger.kernel.org/msg12192.html > > This one is already merged to 'next'. Awesome! I didn't notice. If I want to suggest an improvement (like checking if the bash script is available), do I just post a patch here? Thanks a lot for moving forward with this so quickly! Marc