From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: X-Spam-Status: No, score=-3.6 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.6 Received: from out1.vger.email (out1.vger.email [IPv6:2620:137:e000::1:20]) by dcvr.yhbt.net (Postfix) with ESMTP id 9112A1F452 for ; Thu, 6 Apr 2023 08:16:44 +0000 (UTC) Authentication-Results: dcvr.yhbt.net; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20210112 header.b=jwF7Vwxs; dkim-atps=neutral Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235575AbjDFIQY (ORCPT ); Thu, 6 Apr 2023 04:16:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58888 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235411AbjDFIQW (ORCPT ); Thu, 6 Apr 2023 04:16:22 -0400 Received: from mail-ed1-x531.google.com (mail-ed1-x531.google.com [IPv6:2a00:1450:4864:20::531]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 46A02119 for ; Thu, 6 Apr 2023 01:16:21 -0700 (PDT) Received: by mail-ed1-x531.google.com with SMTP id 4fb4d7f45d1cf-4fa3c48480fso1069809a12.2 for ; Thu, 06 Apr 2023 01:16:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1680768979; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=yEy6I69lkM81crQqd4dqASeg7AOw4CrsImEAYHEqGhc=; b=jwF7Vwxs+SRor1yn6DvCSuuKDEioNj2OEI8jVjAGvcGhxXY2MmPLVb909rV0pI37Cq B03kvPnQ2y+JB0ZPXW2oykmTmrrVcwaRXm5tiafvyJxp2lDLbdZA0ksUnGhan5bIQbzq y53pkWNblDEsoYJWVJEFEiklH2NulHD7DJ/ykkmtoRkgFIMcQDMtZAW+eTNNptKzU4+b 7ctWhkf7L45pLh+6jnbK6I80Ng05b7ENY043UwX+wRurieKlQBWMPPWUOWB+wXhQZtya FnyMFKHjPi6+IoJdJm/lvdi2FyFA0WBeK/Qz7QpMTI6yrbd/S1t9vVIm4BjutaTsJsgT efYA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680768979; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=yEy6I69lkM81crQqd4dqASeg7AOw4CrsImEAYHEqGhc=; b=hdeIk536+IPQimROhbkMxSN3WvSkQxUyrMZ9jkbChsr8AF/TMwjJazzHrwqhUBzjc8 PsOyf84BPY1DuKAojbSYAUCscEoS9rC/ibavKCfrezFtHJ3TSV6SGTBY1V7EcGpmH3q4 13Cd3vhZcFv11wS5XzKAIFwKqOo3VbUrY/8ox1/HKPRU9iCUGOxsjXdnOOLytwcLKyzE AM9zTfySC4KhXv76stygpcO5JDn8gMe3PcDx3kQaEdAGZW5rwU2atVZHKLxBqstS4XG6 wCosIKL7OK2kidsQ+pzkCEVn6k9SqdiYYvGayidrjvK6DIO6WCeNzgAq5yzFZT3EvqfG KAhw== X-Gm-Message-State: AAQBX9eqHVzAXBlPXSewU4VgBtav6OvRIw82X7B0M6KV9dwmpfPRjxcZ LQrrK6legJ+77j4exz6fVlXwpTpaO0rWeSn7B6mX5Iklc3w= X-Google-Smtp-Source: AKy350ayagXF2/uifyPsjFKxFvpBunZaXpRdPgyyvkS/oUbfNkron5wP1cmmRJyDrgabSzcuUHCPsTups10jlwqqUVA= X-Received: by 2002:a50:9f8e:0:b0:4fc:6494:81c3 with SMTP id c14-20020a509f8e000000b004fc649481c3mr2633800edf.1.1680768979160; Thu, 06 Apr 2023 01:16:19 -0700 (PDT) MIME-Version: 1.0 References: <20230401212858.266508-1-rybak.a.v@gmail.com> <20230403223338.468025-1-rybak.a.v@gmail.com> <20230403223338.468025-6-rybak.a.v@gmail.com> In-Reply-To: <20230403223338.468025-6-rybak.a.v@gmail.com> From: =?UTF-8?Q?=C3=98ystein_Walle?= Date: Thu, 6 Apr 2023 10:15:40 +0200 Message-ID: Subject: Re: [PATCH v2 5/6] t1502: don't create unused files To: Andrei Rybak Cc: git@vger.kernel.org, =?UTF-8?B?w4Z2YXIgQXJuZmrDtnLDsCBCamFybWFzb24=?= , Johannes Schindelin , Junio C Hamano Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Hi Andrei On Tue, 4 Apr 2023 at 00:33, Andrei Rybak wrote: > > test_expect_success 'test --parseopt invalid opt-spec' ' > test_write_lines x -- "=3D, x" >spec && > echo "fatal: missing opt-spec before option flags" >expect && > - test_must_fail git rev-parse --parseopt -- >out err && > + test_must_fail git rev-parse --parseopt -- err && > test_cmp expect err > ' This is the one that was touched by me. At the time I just cargo-culted oth= er tests. This looks obviously correct to me For what it's worth: Acked-by: =C3=98ystein Walle =C3=98sse