From: 唐宇奕 <email@example.com> To: Junio C Hamano <firstname.lastname@example.org> Cc: "Jeff King" <email@example.com>, "René Scharfe" <firstname.lastname@example.org>, email@example.com Subject: Re: Bug report: orphaned pack-objects after killing upload-pack on [ Date: Tue, 24 Nov 2020 11:21:09 +0800 [thread overview] Message-ID: <CAFWsj_WsexXgFe-jMYOk8_m9N7GLrhRjqFjRWRePZmxUDEYkSg@mail.gmail.com> (raw) In-Reply-To: <firstname.lastname@example.org> when will this bug be fixed? Junio C Hamano <email@example.com> 于2020年11月22日周日 上午5:54写道： > > Jeff King <firstname.lastname@example.org> writes: > > > Yeah, clean_on_exit seems quite reasonable to me. I suspect nobody ever > > really noticed, because as soon as pack-objects starts to write out the > > pack, it will get SIGPIPE or EPIPE and die. But there is no point in > > letting it chug on expensive object enumeration or delta compression if > > upload-pack has already exited. > > > > I don't know that wait_after_clean is necessary. We don't need to wait > > for pack-objects to fail. > > > > On the flip side, one of the reasons I added clean_on_exit long ago was > > for the similar issue on the push side, which is even worse. Here we > > might just waste some CPU, but on the push side we connect pack-objects > > directly to the remote socket, so it could actually complete the push > > (from the server's perspective) after the local git-push has died. Or at > > least I think that was possible at one point; it might not be the case > > any more. > > > > I wrote this patch ages ago, and it is still sitting close to the bottom > > (if not the bottom) of my todo stack, waiting to be investigated. ;) > > Sounds sensible. > > > -- >8 -- > > Subject: [PATCH] send-pack: kill pack-objects helper on signal or exit > > > > We spawn an external pack-objects process to actually send > > objects to the remote side. If we are killed by a signal > > during this process, the pack-objects will keep running and > > complete the push, which may surprise the user. We should > > take it down when we go down. > > > > Signed-off-by: Jeff King <email@example.com> > > --- > > send-pack.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/send-pack.c b/send-pack.c > > index eb4a44270b..d2701bf35c 100644 > > --- a/send-pack.c > > +++ b/send-pack.c > > @@ -85,6 +85,7 @@ static int pack_objects(int fd, struct ref *refs, struct oid_array *extra, struc > > po.in = -1; > > po.out = args->stateless_rpc ? -1 : fd; > > po.git_cmd = 1; > > + po.clean_on_exit = 1; > > if (start_command(&po)) > > die_errno("git pack-objects failed");
next prev parent reply other threads:[~2020-11-24 3:25 UTC|newest] Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-11-19 8:18 唐宇奕 2020-11-20 18:52 ` Bug report: orphaned pack-objects after killing upload-pack on [was: (no subject)] René Scharfe 2020-11-21 0:29 ` Jeff King 2020-11-21 21:54 ` Bug report: orphaned pack-objects after killing upload-pack on [ Junio C Hamano 2020-11-24 3:21 ` 唐宇奕 [this message] 2020-11-24 9:11 ` Jeff King 2020-11-25 21:42 ` Junio C Hamano 2020-11-26 0:53 ` Jeff King 2020-11-26 1:04 ` Junio C Hamano 2020-11-26 20:04 ` René Scharfe 2020-11-27 4:17 ` Jeff King 2020-11-27 20:43 ` René Scharfe 2020-11-28 6:30 ` Jeff King 2020-12-01 12:15 ` Jeff King 2020-12-02 11:45 ` René Scharfe 2020-12-02 22:14 ` Junio C Hamano
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style List information: http://vger.kernel.org/majordomo-info.html * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=CAFWsj_WsexXgFe-jMYOk8_m9N7GLrhRjqFjRWRePZmxUDEYkSg@mail.gmail.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --subject='Re: Bug report: orphaned pack-objects after killing upload-pack on [' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Code repositories for project(s) associated with this inbox: https://80x24.org/mirrors/git.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).