From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS3215 2.6.0.0/16 X-Spam-Status: No, score=-11.3 required=3.0 tests=AWL,BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI,SPF_HELO_NONE,SPF_PASS, USER_IN_DEF_DKIM_WL shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from out1.vger.email (out1.vger.email [IPv6:2620:137:e000::1:20]) by dcvr.yhbt.net (Postfix) with ESMTP id 8B3C91F506 for ; Tue, 20 Sep 2022 08:55:22 +0000 (UTC) Authentication-Results: dcvr.yhbt.net; dkim=pass (2048-bit key; unprotected) header.d=google.com header.i=@google.com header.b="l8ty8uks"; dkim-atps=neutral Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231376AbiITIyP (ORCPT ); Tue, 20 Sep 2022 04:54:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45856 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231330AbiITIyM (ORCPT ); Tue, 20 Sep 2022 04:54:12 -0400 Received: from mail-vk1-xa34.google.com (mail-vk1-xa34.google.com [IPv6:2607:f8b0:4864:20::a34]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D46E26B64D for ; Tue, 20 Sep 2022 01:54:11 -0700 (PDT) Received: by mail-vk1-xa34.google.com with SMTP id v192so1025471vkv.7 for ; Tue, 20 Sep 2022 01:54:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date; bh=pGOL0oY4EteaUBlWBzle+mtIe1w/rRWR426N+rwwpyY=; b=l8ty8uksBhXYXhRkkHpP2fdWsFjsCJm7Fe5CWy42W5KQDIU0Nwljnc/Fb0TLFFoeax uMtyk4/QlFtRJzuKbRXxULcbNyDFrC5tlMuBpf7M3SeRGa1o2wRxLLv+ZuphwAuj8tvx mjZZy7gd1ryqF3K7pO1o7IrCOQkiJ8AtlfyulhnD9lJeHsKZCwul3i7Mq6N023ReAhc8 G8XArHUiUixqH+u8cvL/8UwCzkGFRri7RQbm9gWmLSOR0Ysis3Ban1bXi8YQiRjeLxj9 jDj/OVkNPsz2WGaS9Xk1hG8ctY77+ynnZiyL5pAVwhYIYye5LsXYeU8wuTcTdPC7KbZd XL4A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date; bh=pGOL0oY4EteaUBlWBzle+mtIe1w/rRWR426N+rwwpyY=; b=fyS455hjRt1Ig60zvhVump5lKSatG9fT//NG1O580Qy86mzBHWc5morYJB8HqtrEwM F1w0AF1pf4xNc7twE8Fm4I/+94z6lKVvn24UIFNZ4jlo/dxSkHPPt+okLgcUeQllA+2/ Ld4xOps1D9zN1/sEHd0jcjkSVIZ35Q7t1v57FSgIQ8WGQyTvzVsOJvshoIpcnCKZDWBZ k2+ybN42alDDJaDNb5k+mK5Hi7Yx8xccu4XgtpS+/dDQEw4W5kqRv9hR8ibnNKrgHSxt jFM+nw1Ajmfh7ZeNss5y5WMuqs3DjHGFBZvgT070F4SafsG1SohEIc4A/Z6qqAOENURl 90fQ== X-Gm-Message-State: ACrzQf0/5NgVcwgR4BxcjXzZdfRBWuCcwO/owzaK2RWOnPgCydr4AezR looZInXZ5E/M6QHF2qKjKoMb31ALVXCtOa9wvjCRSw== X-Google-Smtp-Source: AMsMyM5gSbV0d8UZ7mvIffumV2P8AiSWL2Es50qD+QlHXyJrNx1xZ8KEc9pEPwXpqybTnMc/na6iCNMOn3I7YrjAu00= X-Received: by 2002:a1f:a7ca:0:b0:3a2:cb7e:65a1 with SMTP id q193-20020a1fa7ca000000b003a2cb7e65a1mr7691891vke.4.1663664050751; Tue, 20 Sep 2022 01:54:10 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Han-Wen Nienhuys Date: Tue, 20 Sep 2022 10:53:59 +0200 Message-ID: Subject: Re: [PATCH] refs: unify parse_worktree_ref() and ref_type() To: Junio C Hamano Cc: Han-Wen Nienhuys via GitGitGadget , git@vger.kernel.org, Han-Wen Nienhuys Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On Mon, Sep 19, 2022 at 11:43 PM Junio C Hamano wrote: > > On Tue, Sep 13, 2022 at 5:43 PM Junio C Hamano wrot= e: > >> then a better approach would be to have a small helper > >> parse_local_worktree_ref() and make the primary one into something > >> like > >>... > > > > Thanks, good idea. I'm sending you a v2. > > is that "v2" > or is there another version of it? I think so. > Hmph, Did I do something wrong? --=20 Han-Wen Nienhuys - Google Munich I work 80%. Don't expect answers from me on Fridays. -- Google Germany GmbH, Erika-Mann-Strasse 33, 80636 Munich Registergericht und -nummer: Hamburg, HRB 86891 Sitz der Gesellschaft: Hamburg Gesch=C3=A4ftsf=C3=BChrer: Paul Manicle, Liana Sebastian