git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Han-Wen Nienhuys <hanwen@google.com>
To: Derrick Stolee <stolee@gmail.com>
Cc: Git List <git@vger.kernel.org>
Subject: Re: Git Test Coverage Report (April 30, 2020)
Date: Thu, 30 Apr 2020 17:12:18 +0200	[thread overview]
Message-ID: <CAFQ2z_PP9Ld+GDctV-v2CDKFamF6zKdJZ_-jhahj_fcm3wy4Hw@mail.gmail.com> (raw)
In-Reply-To: <fda6d0db-f79e-f44e-7c2b-b60ed1794cd0@gmail.com>

On Thu, Apr 30, 2020 at 1:22 PM Derrick Stolee <stolee@gmail.com> wrote:
>
> Hello,
>
> Here is today's test coverage report.
>
> It appears that _all_ of the reftable code shows up in this report as
> untested. Perhaps that is the state of the world right now, or perhaps
> I need to initialize a GIT_TEST_ environment variable to ensure it runs?

> In either way, do we have any test coverage of that massive contribution?
> Please take a look at the online report [1] for that part of the report,
> as I snipped it out of this email.

(again in plain text)

The reftable code is currently exercised in a small way by t0031-reftable.sh

The upstream library has unittests, see
https://cs.bazel.build/search?q=r%3Areftable+f%3A_test.c&num=0, but I
believe Git doesn't do unittests?

I'll try to generate a coverage report for them.

You can set GIT_TEST_REFTABLE to see coverage for reftable, but I'm
not sure how useful it is given that ~15% of the tests fail.


-- 
Han-Wen Nienhuys - Google Munich
I work 80%. Don't expect answers from me on Fridays.
--
Google Germany GmbH, Erika-Mann-Strasse 33, 80636 Munich
Registergericht und -nummer: Hamburg, HRB 86891
Sitz der Gesellschaft: Hamburg
Geschäftsführer: Paul Manicle, Halimah DeLaine Prado

  reply	other threads:[~2020-04-30 15:12 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-30 11:21 Git Test Coverage Report (April 30, 2020) Derrick Stolee
2020-04-30 15:12 ` Han-Wen Nienhuys [this message]
2020-05-01 22:08   ` Johannes Schindelin
2020-05-03  9:55     ` Jeff King
2020-05-03 16:58       ` Junio C Hamano
2020-05-07 10:11         ` Han-Wen Nienhuys
2020-05-07 18:56           ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAFQ2z_PP9Ld+GDctV-v2CDKFamF6zKdJZ_-jhahj_fcm3wy4Hw@mail.gmail.com \
    --to=hanwen@google.com \
    --cc=git@vger.kernel.org \
    --cc=stolee@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).