From: Han-Wen Nienhuys <hanwen@google.com>
To: Ramsay Jones <ramsay@ramsayjones.plus.com>
Cc: GIT Mailing-list <git@vger.kernel.org>,
Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH] reftable: fix some sparse warnings
Date: Wed, 30 Sep 2020 18:51:24 +0200 [thread overview]
Message-ID: <CAFQ2z_PNT0g2yAbMkWEQW3UjbMbzALfkAfLDzpiUZjOE0b29vw@mail.gmail.com> (raw)
In-Reply-To: <eaf4629b-d8c4-0ddc-8c85-6600399a8229@ramsayjones.plus.com>
On Wed, Sep 23, 2020 at 12:47 AM Ramsay Jones
<ramsay@ramsayjones.plus.com> wrote:
>
>
> Signed-off-by: Ramsay Jones <ramsay@ramsayjones.plus.com>
> ---
>
> Hi Han-Wen Nienhuys,
>
> If you need to re-roll your 'hn/reftable' branch, could you please squash this
> into the relevant patches.
>
Thanks for the heads-up. I fixed some of these issues in the source at
google/reftable. I've seen a Helped-By footer used to acknowledge
these types of contributions, but I'm not sure on which of the 13
commits I should put that; suggestions?
> This patch is based on top of 'seen' and removes 20 sparse warnings (19 of the
Could you tell me how I can run these checks myself?
> Just for your information, you may want to look at the following 27 symbols:
> > reftable/merged.o - reftable_merged_table_hash_id
> > reftable/merged.o - reftable_merged_table_max_update_index
> > reftable/merged.o - reftable_merged_table_min_update_index
> > reftable/merged.o - reftable_merged_table_seek_log_at
> > reftable/publicbasics.o - reftable_error_to_errno
> > reftable/publicbasics.o - reftable_set_alloc
> > reftable/reader.o - reftable_reader_seek_log_at
> > reftable/stack.o - reftable_addition_close
> > reftable/stack.o - reftable_stack_auto_compact
These functions are part of the public API. We'll need to get the
reftable glue code into seen. Perhaps some need unittest coverage too.
--
Han-Wen Nienhuys - Google Munich
I work 80%. Don't expect answers from me on Fridays.
--
Google Germany GmbH, Erika-Mann-Strasse 33, 80636 Munich
Registergericht und -nummer: Hamburg, HRB 86891
Sitz der Gesellschaft: Hamburg
Geschäftsführer: Paul Manicle, Halimah DeLaine Prado
next prev parent reply other threads:[~2020-09-30 16:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-22 22:47 [PATCH] reftable: fix some sparse warnings Ramsay Jones
2020-09-30 16:51 ` Han-Wen Nienhuys [this message]
2020-09-30 20:18 ` Ramsay Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFQ2z_PNT0g2yAbMkWEQW3UjbMbzALfkAfLDzpiUZjOE0b29vw@mail.gmail.com \
--to=hanwen@google.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=ramsay@ramsayjones.plus.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).