What's cooking in git.git (Aug 2021, #09; Sun, 29)

What's cooking in git.git (Aug 2021, #09; Sun, 29)

[Junio C Hamano]

Here are the topics that have been cooking in my tree.  Commits
prefixed with '+' are in 'next' (being in 'next' is a sign that a
topic is stable enough to be used and are candidate to be in a
future release).  Commits prefixed with '-' are only in 'seen',
which means nothing more than that I have found them of interest for
some reason (like "it may have hard-to-resolve conflicts with
another topic already in flight" or "this may turn out to be
useful").  Do not read too much into a topic being in (or not in)
'seen'.  The ones marked with '.' do not appear in any of the
integration branches, but I am still holding onto them.

The first batch of topics for the new cycle are now in 'master'.
The second batch will primarily be to graduate 'ort' as the
default.

I've been a bit under the weather during the last week and wanted to
concentrate on what to push out to 'master', so while I may have
picked up new topics and replaced existing topics with their new
versions, I haven't added or updated my summaries on their doneness
to this document.  Help is appreciated.

There also may be other patches sent to the list that I haven't
looked at, whether they were reviewed by others or not.

Copies of the source code to Git live in many repositories, and the
following is a list of the ones I push into or their mirrors.  Some
repositories have only a subset of branches.

With maint, master, next, seen, todo:

	git://git.kernel.org/pub/scm/git/git.git/
	git://repo.or.cz/alt-git.git/
	https://kernel.googlesource.com/pub/scm/git/git/
	https://github.com/git/git/
	https://gitlab.com/git-vcs/git/

With all the integration branches and topics broken out:

	https://github.com/gitster/git/

Even though the preformatted documentation in HTML and man format
are not sources, they are published in these repositories for
convenience (replace "htmldocs" with "manpages" for the manual
pages):

	git://git.kernel.org/pub/scm/git/git-htmldocs.git/
	https://github.com/gitster/git-htmldocs.git/

Release tarballs are available at:

	https://www.kernel.org/pub/software/scm/git/

--------------------------------------------------
[Graduated to 'master']

* ab/bundle-doc (2021-08-02) 4 commits
  (merged to 'next' on 2021-08-23 at af25d34e71)
 + bundle doc: replace "basis" with "prerequsite(s)"
 + bundle doc: elaborate on rev<->ref restriction
 + bundle doc: elaborate on object prerequisites
 + bundle doc: rewrite the "DESCRIPTION" section

 Originally merged to 'next' on 2021-08-04

 Doc update.


* ab/http-drop-old-curl (2021-07-30) 5 commits
  (merged to 'next' on 2021-08-23 at 70188594a0)
 + http: rename CURLOPT_FILE to CURLOPT_WRITEDATA
 + http: drop support for curl < 7.19.3 and < 7.17.0 (again)
 + http: drop support for curl < 7.19.4
 + http: drop support for curl < 7.16.0
 + http: drop support for curl < 7.11.1

 Originally merged to 'next' on 2021-08-02

 Support for ancient versions of cURL library has been dropped.


* ab/pack-stdin-packs-fix (2021-07-09) 2 commits
  (merged to 'next' on 2021-08-23 at ec9d0ba95f)
 + pack-objects: fix segfault in --stdin-packs option
 + pack-objects tests: cover blindspots in stdin handling

 Originally merged to 'next' on 2021-08-04

 Input validation of "git pack-objects --stdin-packs" has been
 corrected.


* ds/add-with-sparse-index (2021-07-29) 5 commits
  (merged to 'next' on 2021-08-23 at 179c4747ac)
 + add: remove ensure_full_index() with --renormalize
 + add: ignore outside the sparse-checkout in refresh()
 + pathspec: stop calling ensure_full_index
 + add: allow operating on a sparse-only index
 + t1092: test merge conflicts outside cone
 (this branch is used by ds/sparse-index-ignored-files.)

 Originally merged to 'next' on 2021-08-02

 "git add" can work better with the sparse index.


* en/ort-perf-batch-15 (2021-08-03) 9 commits
  (merged to 'next' on 2021-08-23 at d22a850986)
 + merge-ort: remove compile-time ability to turn off usage of memory pools
 + merge-ort: reuse path strings in pool_alloc_filespec
 + merge-ort: store filepairs and filespecs in our mem_pool
 + diffcore-rename, merge-ort: add wrapper functions for filepair alloc/dealloc
 + merge-ort: switch our strmaps over to using memory pools
 + merge-ort: set up a memory pool
 + merge-ort: add pool_alloc, pool_calloc, and pool_strndup wrappers
 + diffcore-rename: use a mem_pool for exact rename detection's hashmap
 + merge-ort: rename str{map,intmap,set}_func()

 Originally merged to 'next' on 2021-08-04

 Final batch for "merge -sort" optimization.


* es/trace2-log-parent-process-name (2021-07-22) 2 commits
  (merged to 'next' on 2021-08-23 at a93182081d)
 + tr2: log parent process name
 + tr2: make process info collection platform-generic

 Originally merged to 'next' on 2021-08-04

 trace2 logs learned to show parent process name to see in what
 context Git was invoked.


* hn/refs-test-cleanup (2021-08-02) 11 commits
  (merged to 'next' on 2021-08-23 at 96fe62cbc1)
 + t6001: avoid direct file system access
 + t6500: use "ls -1" to snapshot ref database state
 + t7064: use update-ref -d to remove upstream branch
 + t1410: mark test as REFFILES
 + t1405: mark test for 'git pack-refs' as REFFILES
 + t1405: use 'git reflog exists' to check reflog existence
 + t2402: use ref-store test helper to create broken symlink
 + t3320: use git-symbolic-ref rather than filesystem access
 + t6120: use git-update-ref rather than filesystem access
 + t1503: mark symlink test as REFFILES
 + t6050: use git-update-ref rather than filesystem access

 Originally merged to 'next' on 2021-08-04

 A handful of tests that assumed implementation details of files
 backend for refs have been cleaned up.


* jc/bisect-sans-show-branch (2021-07-28) 2 commits
  (merged to 'next' on 2021-08-23 at 4d01043b2e)
 + bisect: simplify return code from bisect_checkout()
 + bisect: do not run show-branch just to show the current commit

 Originally merged to 'next' on 2021-08-02

 "git bisect" spawned "git show-branch" only to pretty-print the
 title of the commit after checking out the next version to be
 tested; this has been rewritten in C.


* js/expand-runtime-prefix (2021-07-26) 6 commits
  (merged to 'next' on 2021-08-23 at cf274b0177)
 + expand_user_path: allow in-flight topics to keep using the old name
 + interpolate_path(): allow specifying paths relative to the runtime prefix
 + Use a better name for the function interpolating paths
 + expand_user_path(): clarify the role of the `real_home` parameter
 + expand_user_path(): remove stale part of the comment
 + tests: exercise the RUNTIME_PREFIX feature

 Originally merged to 'next' on 2021-08-04

 Pathname expansion (like "~username/") learned a way to specify a
 location relative to Git installation (e.g. its $sharedir which is
 $(prefix)/share), with "%(prefix)".


* jt/push-negotiation-fixes (2021-07-15) 3 commits
  (merged to 'next' on 2021-08-23 at 6b3dcc1092)
 + fetch: die on invalid --negotiation-tip hash
 + send-pack: fix push nego. when remote has refs
 + send-pack: fix push.negotiate with remote helper

 Originally merged to 'next' on 2021-08-09

 Bugfix for common ancestor negotiation recently introduced in "git
 push" codepath.


* ps/fetch-pack-load-refs-optim (2021-08-04) 1 commit
  (merged to 'next' on 2021-08-23 at 09f9fbdd9f)
 + fetch-pack: speed up loading of refs via commit graph

 Originally merged to 'next' on 2021-08-09

 Loading of ref tips to prepare for common ancestry negotiation in
 "git fetch-pack" has been optimized by taking advantage of the
 commit graph when available.


* zh/ref-filter-raw-data (2021-07-26) 6 commits
  (merged to 'next' on 2021-08-23 at 5c06fb48a5)
 + ref-filter: add %(rest) atom
 + ref-filter: use non-const ref_format in *_atom_parser()
 + ref-filter: --format=%(raw) support --perl
 + ref-filter: add %(raw) atom
 + ref-filter: add obj-type check in grab contents
 + Merge branch 'zh/cat-file-batch-fix' into zh/ref-filter-raw-data

 Originally merged to 'next' on 2021-08-04

 Prepare the "ref-filter" machinery that drives the "--format"
 option of "git for-each-ref" and its friends to be used in "git
 cat-file --batch".

--------------------------------------------------
[New Topics]

* ab/commit-graph-usage (2021-08-25) 7 commits
 - commit-graph: show "unexpected subcommand" error
 - commit-graph: show usage on "commit-graph [write|verify] garbage"
 - commit-graph: early exit to "usage" on !argc
 - multi-pack-index: refactor "goto usage" pattern
 - commit-graph: use parse_options_concat()
 - commit-graph: remove redundant handling of -h
 - commit-graph: define common usage with a macro


* ab/ls-remote-packet-trace (2021-08-24) 1 commit
 - ls-remote: set packet_trace_identity(<name>)

 Debugging aid fix.

 Will merge to 'next'.


* ab/rebase-fatal-fatal-fix (2021-08-24) 1 commit
 - rebase: emit one "fatal" in "fatal: fatal: <error>"

 Error message fix.

 Will merge to 'next'.


* ab/refs-errno-cleanup (2021-08-25) 4 commits
 - refs: make errno output explicit for refs_resolve_ref_unsafe
 - refs: explicitly return failure_errno from parse_loose_ref_contents
 - branch tests: test for errno propagating on failing read
 - refs: add failure_errno to refs_read_raw_ref() signature
 (this branch is used by hn/reftable; uses ab/refs-files-cleanup and hn/refs-errno-cleanup.)

 The "remainder" of hn/refs-errno-cleanup topic.


* ab/retire-advice-config (2021-08-25) 4 commits
 - advice: move advice.graftFileDeprecated squashing to commit.[ch]
 - advice: remove use of global advice_add_embedded_repo
 - advice: remove read uses of most global `advice_` variables
 - advice: add enum variants for missing advice variables

 Code clean up to migrate callers from older advice_config[] based
 API to newer advice_if_enabled() and advice_enabled() API.

 Want to merge to 'next' but a tree-wide change like this can
 interfere other topics in flight, so I'll need to block some time
 to see how safe it is to proceed before we can do so.


* dd/diff-files-unmerged-fix (2021-08-25) 1 commit
 - diff-lib: ignore paths that are outside $cwd if --relative asked

 "git diff --relative" segfaulted and/or produced incorrect result
 when there are unmerged paths.

 Will merge to 'next'.


* dd/t6300-wo-gpg-fix (2021-08-25) 2 commits
 - t6300: check for cat-file exit status code
 - t6300: don't run cat-file on non-existent object

 Test fix.

 Will merge to 'next'.


* ga/send-email-sendmail-cmd (2021-08-24) 1 commit
 - t9001: PATH must not use Windows-style paths

 Test fix.

 Will merge to 'next'.


* jb/midx-revindex-fix (2021-08-23) 1 commit
 - multi-pack-index: fix *.rev cleanups with --object-dir

 An implementation in "multi-pack-index write" that takes object
 directory inconsistently used that and the object store of the
 default repository, causing segfaults and possibly corrupting
 repositories.

 On hold.
 cf. <xmqqo89jbf49.fsf@gitster.g>


* jk/t5323-no-pack-test-fix (2021-08-25) 1 commit
 - t5323: drop mentions of "master"

 Test fix.

 Will merge to 'next'.


* js/maintenance-launchctl-fix (2021-08-24) 2 commits
 - maintenance: skip bootout/bootstrap when plist is registered
 - maintenance: create `launchctl` configuration using a lock file

 "git maintenance" scheduler fix for macOS.

 Will merge to 'next'.


* jv/pkt-line-batch (2021-08-26) 2 commits
 - upload-pack: use stdio in send_ref callbacks
 - pkt-line: add packet_fwrite

 Reduce number of write(2) system calls while sending the
 ref advertisement.

 Expecting a reroll.


* me/t5582-cleanup (2021-08-24) 1 commit
 - t5582: remove spurious 'cd "$D"' line

 Test fix.

 Will merge to 'next'.


* mh/credential-leakfix (2021-08-25) 1 commit
 - credential: fix leak in credential_apply_config()

 Leak fix.

 Will merge to 'next'.


* mt/quiet-with-delayed-checkout (2021-08-26) 1 commit
 - checkout: make delayed checkout respect --quiet and --no-progress

 The delayed checkout code path in "git checkout" etc. were chatty
 even when --quiet and/or --no-progress options were given.

 Will merge to 'next'.


* ps/fetch-omit-formatting-under-quiet (2021-08-25) 1 commit
 - fetch: skip formatting updated refs with `--quiet`

 "git fetch --quiet" optimization to avoid useless computation of
 info that will never be displayed.

 Expecting a reroll.
 cf. <xmqqo89lid59.fsf@gitster.g>


* ps/ls-refs-strbuf-optim (2021-08-25) 1 commit
 - ls-refs: reuse buffer when sending refs

 Micro-optimization for the wire protocol driver.

 Will merge to 'next'.


* rs/branch-allow-deleting-dangling (2021-08-27) 1 commit
 - branch: allow deleting dangling branches with --force

 "git branch -D <branch>" used to refuse to remove a broken branch
 ref that points at a missing commit, which has been corrected.

 Will merge to 'next'.


* rs/git-mmap-uses-malloc (2021-08-24) 1 commit
 - compat: let git_mmap use malloc(3) directly

 mmap() imitation used to call xmalloc() that dies upon malloc()
 failure, which has been corrected to just return an error to the
 caller to be handled.

 Will merge to 'next'.


* rs/xopen-reports-open-failures (2021-08-25) 2 commits
 - use xopen() to handle fatal open(2) failures
 - xopen: explicitly report creation failures

 Error diagnostics improvement.

 Will merge to 'next'.


* sg/column-nl (2021-08-26) 1 commit
 - column: fix parsing of the '--nl' option

 The parser for the "--nl" option of "git column" has been
 corrected.

 Will merge to 'next'.


* ab/unbundle-progress (2021-08-27) 5 commits
 - bundle: show progress on "unbundle"
 - index-pack: add --progress-title option
 - bundle API: change "flags" to be "extra_index_pack_args"
 - strvec: add a strvec_pushvec()
 - bundle API: start writing API documentation


* jk/log-warn-on-bogus-encoding (2021-08-27) 2 commits
 - docs: use "character encoding" to refer to commit-object encoding
 - logmsg_reencode(): warn when iconv() fails


* rs/archive-use-object-id (2021-08-27) 1 commit
 - archive: convert queue_directory to struct object_id


* rs/show-branch-simplify (2021-08-27) 1 commit
 - show-branch: simplify rev_is_head()

--------------------------------------------------
[Stalled]

* gh/gitweb-branch-sort (2021-06-10) 1 commit
 - gitweb: use HEAD as secondary sort key in git_get_heads_list()

 Tie-break branches that point at the same object in the list of
 branches on GitWeb to show the one pointed at by HEAD early.

 Waiting for reviews.


* es/superproject-aware-submodules (2021-08-19) 5 commits
 - fixup! introduce submodule.superprojectGitDir record
 - submodule: record superproject gitdir during 'update'
 - submodule: record superproject gitdir during absorbgitdirs
 - introduce submodule.superprojectGitDir record
 - t7400-submodule-basic: modernize inspect() helper

 A configuration variable in a submodule points at the location of
 the superproject it is bound to (RFC).

 Looking good.


* en/zdiff3 (2021-06-15) 2 commits
 - update documentation for new zdiff3 conflictStyle
 - xdiff: implement a zealous diff3, or "zdiff3"

 "Zealous diff3" style of merge conflict presentation has been added.

 Expecting a reroll.
 cf. <CABPp-BE7-E03+x38EK-=AE5mwwdST+d50hiiud2eY2Nsf3rM5g@mail.gmail.com>


* ao/p4-avoid-decoding (2021-04-12) 2 commits
 - git-p4: do not decode data from perforce by default
 - git-p4: avoid decoding more data from perforce

 "git p4" in Python-2 days used to accept a lot more kinds of data
 from Perforce server as uninterrupted byte sequence, but after
 switching to Python-3, too many things are expected to be in UTF-8,
 which broke traditional use cases.

 Waiting for reviews.


* tv/p4-fallback-encoding (2021-04-30) 1 commit
 - git-p4: git-p4.fallbackEncoding to specify non UTF-8 charset

 "git p4" learns the fallbackEncoding configuration variable to
 safely accept changeset descriptions that aren't written in UTF-8.

 Waiting for reviews.


* ab/fsck-unexpected-type (2021-07-12) 21 commits
 - fsck: report invalid object type-path combinations
 - fsck: report invalid types recorded in objects
 - object-store.h: move read_loose_object() below 'struct object_info'
 - fsck: don't hard die on invalid object types
 - object-file.c: return -2 on "header too long" in unpack_loose_header()
 - object-file.c: return -1, not "status" from unpack_loose_header()
 - object-file.c: guard against future bugs in loose_object_info()
 - object-file.c: stop dying in parse_loose_header()
 - object-file.c: split up ternary in parse_loose_header()
 - object-file.c: simplify unpack_loose_short_header()
 - object-file.c: add missing braces to loose_object_info()
 - object-file.c: make parse_loose_header_extended() public
 - object-file.c: don't set "typep" when returning non-zero
 - cache.h: move object functions to object-store.h
 - cat-file tests: test for current --allow-unknown-type behavior
 - cat-file tests: add corrupt loose object test
 - rev-list tests: test for behavior with invalid object types
 - cat-file tests: test that --allow-unknown-type isn't on by default
 - cat-file tests: test for missing object with -t and -s
 - fsck tests: add test for fsck-ing an unknown type
 - fsck tests: refactor one test to use a sub-repo

 "git fsck" has been taught to report mismatch between expected and
 actual types of an object better.

 Needs review.

--------------------------------------------------
[Cooking]

* lh/systemd-timers (2021-08-27) 3 commits
 - maintenance: add support for systemd timers on Linux
 - maintenance: `git maintenance run` learned `--scheduler=<scheduler>`
 - cache.h: Introduce a generic "xdg_config_home_for(…)" function

 "git maintenance" scheduler learned to use systemd timers as a
 possible backend.


* ps/fetch-optim (2021-08-24) 8 commits
 - fetch: avoid second connectivity check if we already have all objects
 - fetch: merge fetching and consuming refs
 - fetch: refactor fetch refs to be more extendable
 - fetch-pack: optimize loading of refs via commit graph
 - connected: refactor iterator to return next object ID directly
 - fetch: avoid unpacking headers in object existence check
 - fetch: speed up lookup of want refs via commit-graph
 - Merge branch 'ps/connectivity-optim' into ps/fetch-optim
 (this branch uses ps/connectivity-optim.)


* sg/make-fix-ar-invocation (2021-08-19) 1 commit
  (merged to 'next' on 2021-08-24 at 9a3df9ec56)
 + Makefile: remove archives before manipulating them with 'ar'

 Build fix.

 Will merge to 'master'.


* ti/tcsh-completion-regression-fix (2021-08-18) 1 commit
  (merged to 'next' on 2021-08-24 at 8fa66cf037)
 + completion: tcsh: Fix regression by drop of wrapper functions

 Update to the command line completion (in contrib/) for tcsh.

 Will merge to 'master'.


* fc/completion-updates (2021-08-18) 4 commits
  (merged to 'next' on 2021-08-24 at 593cd75c64)
 + completion: bash: add correct suffix in variables
 + completion: bash: fix for multiple dash commands
 + completion: bash: fix for suboptions with value
 + completion: bash: fix prefix detection in branch.*

 Command line completion updates.

 Will merge to 'master'.


* ar/submodule-run-update-procedure (2021-08-24) 1 commit
 - submodule--helper: run update procedures from C

 Reimplementation of parts of "git submodule" in C continues.


* cb/ci-use-upload-artifacts-v1 (2021-08-15) 1 commit
  (merged to 'next' on 2021-08-24 at afdbb7ee8d)
 + ci: use upload-artifacts v1 for dockerized jobs

 Use upload-artifacts v1 (instead of v2) for 32-bit linux, as the
 new version has a blocker bug for that architecture.

 Will merge to 'master'.


* pw/rebase-skip-final-fix (2021-08-13) 3 commits
  (merged to 'next' on 2021-08-24 at 73ec41e9dd)
 + rebase --continue: remove .git/MERGE_MSG
 + rebase --apply: restore some tests
 + t3403: fix commit authorship

 Checking out all the paths from HEAD during the last conflicted
 step in "git rebase" and continuing would cause the step to be
 skipped (which is expected), but leaves MERGE_MSG file behind in
 $GIT_DIR and confuses the next "git commit", which has been
 corrected.

 Will merge to 'master'.


* ab/help-autocorrect-prompt (2021-08-14) 1 commit
 - help.c: help.autocorrect=prompt waits for user action

 The logic for auto-correction of misspelt subcommands learned to go
 interactive when the help.autocorrect configuration variable is set
 to true.


* pw/rebase-r-fixes (2021-08-23) 4 commits
  (merged to 'next' on 2021-08-24 at 81c6aff70a)
 + rebase -r: fix merge -c with a merge strategy
 + rebase -r: don't write .git/MERGE_MSG when fast-forwarding
 + rebase -i: add another reword test
 + rebase -r: make 'merge -c' behave like reword

 Various bugs in "git rebase -r" have been fixed.

 Will merge to 'master'.


* th/userdiff-more-java (2021-08-11) 1 commit
  (merged to 'next' on 2021-08-24 at a5617abd3e)
 + userdiff: improve java hunk header regex

 The userdiff pattern for "java" language has been updated.

 Will merge to 'master'.


* zh/cherry-pick-advice (2021-08-23) 1 commit
 - cherry-pick: use better advice message

 The advice message that "git cherry-pick" gives when it asks
 conflicted replay of a commit to be resolved by the end user has
 been updated.

 Will merge to 'next'?


* es/config-based-hooks (2021-08-19) 7 commits
 - hook: allow out-of-repo 'git hook' invocations
 - hook: include hooks from the config
 - hook: allow running non-native hooks
 - hook: introduce "git hook list"
 - hook: allow parallel hook execution
 - hook: run a list of hooks instead
 - Merge branch 'ab/config-based-hooks-base' into es/config-based-hooks
 (this branch uses ab/config-based-hooks-base.)

 Revamp the hooks subsystem to allow multiple of them to trigger
 upon the same event and control via the configuration variables.

 Will merge to 'next'?
 cf. <87v93wflm0.fsf@evledraar.gmail.com>


* mk/clone-recurse-submodules (2021-08-18) 2 commits
 - fixup! clone: set submodule.recurse=true if submodule.stickyRecursiveClone enabled
 - clone: set submodule.recurse=true if submodule.stickyRecursiveClone enabled

 After "git clone --recurse-submodules", all submodules are cloned
 but they are not by default recursed into by other commands.  With
 submodule.stickyRecursiveClone configuration set, submodule.recurse
 configuration is set to true in a repository created by "clone"
 with "--recurse-submodules" option.

 cf. <4103806f-6d88-2756-8853-7e16e56ad425@gmail.com>


* bc/t5607-avoid-broken-test-fail-prereqs (2021-08-11) 1 commit
  (merged to 'next' on 2021-08-24 at 66c1e510ff)
 + t5607: avoid using prerequisites to select algorithm

 The current implementation of GIT_TEST_FAIL_PREREQS is broken in
 that checking for the lack of a prerequisite would not work.  Avoid
 the use of "if ! test_have_prereq X" in a test script.

 Will merge to 'master'.


* jk/commit-edit-fixup-fix (2021-08-15) 1 commit
  (merged to 'next' on 2021-08-24 at 0c625438c3)
 + commit: restore --edit when combined with --fixup

 "git commit --fixup" now works with "--edit" again, after it was
 broken in v2.32.

 Will merge to 'master'.


* tl/traverse-non-commits-rename (2021-08-12) 1 commit
  (merged to 'next' on 2021-08-24 at 55cc85c20a)
 + list-objects.c: rename "traverse_trees_and_blobs" to "traverse_non_commits"

 Meh.

 Will merge to 'master'.


* cb/ci-freebsd-update (2021-08-12) 1 commit
  (merged to 'next' on 2021-08-24 at 1ecf63af7d)
 + ci: update freebsd 12 cirrus job

 Update FreeBSD CI job

 Will merge to 'master'.


* cb/builtin-merge-format-string-fix (2021-08-09) 1 commit
  (merged to 'next' on 2021-08-24 at 6e94c19f1e)
 + builtin/merge: avoid -Wformat-extra-args from ancient Xcode

 Code clean-up.

 Will merge to 'master'.


* ka/want-ref-in-namespace (2021-08-13) 3 commits
 - docs: clarify the interaction of transfer.hideRefs and namespaces
 - upload-pack.c: treat want-ref relative to namespace
 - t5730: introduce fetch command helper

 "git upload-pack" which runs on the other side of "git fetch"
 forgot to take the ref namespaces into account when handling
 want-ref requests.


* cb/ci-build-pedantic (2021-08-11) 1 commit
 - ci: run a pedantic build as part of the GitHub workflow

 CI update.

 Expecting a reroll.


* ds/sparse-index-ignored-files (2021-08-10) 9 commits
 - sparse-checkout: clear tracked sparse dirs
 - sparse-index: add SPARSE_INDEX_IGNORE_CONFIG flag
 - attr: be careful about sparse directories
 - sparse-checkout: create helper methods
 - unpack-trees: fix nested sparse-dir search
 - sparse-index: silently return when cache tree fails
 - sparse-index: silently return when not using cone-mode patterns
 - t7519: rewrite sparse index test
 - Merge branch 'ds/add-with-sparse-index' into ds/sparse-index-ignored-files

 In cone mode, the sparse-index codepath learned to remove ignored
 files (like build artifacts) outside the sparse cone, allowing the
 entire directory outside the sparse cone to be removed, which is
 especially useful when the sparse patterns change.


* jc/userdiff-pattern-hint (2021-08-11) 1 commit
  (merged to 'next' on 2021-08-24 at f29f51148f)
 + userdiff: comment on the builtin patterns

 Remind developers that the userdiff patterns should be kept simple
 and permissive, assuming that the contents they apply are always
 syntactically correct.

 Will merge to 'master'.


* jk/apply-binary-hunk-parsing-fix (2021-08-10) 1 commit
  (merged to 'next' on 2021-08-24 at c786cd1e8b)
 + apply: keep buffer/size pair in sync when parsing binary hunks

 "git apply" miscounted the bytes and failed to read to the end of
 binary hunks.

 Will merge to 'master'.


* jk/range-diff-fixes (2021-08-10) 3 commits
  (merged to 'next' on 2021-08-24 at eff05f579e)
 + range-diff: use ssize_t for parsed "len" in read_patches()
 + range-diff: handle unterminated lines in read_patches()
 + range-diff: drop useless "offset" variable from read_patches()

 "git range-diff" code clean-up.

 Will merge to 'master'.


* js/advise-when-skipping-cherry-picked (2021-08-10) 2 commits
 - SQUASH???
 - sequencer: advise if skipping cherry-picked commit

 "git rebase" by default skips changes that are equivalent to
 commits that are already in the history the branch is rebased onto;
 give messages when this happens to let the users be aware of
 skipped commits, and also teach them how to tell "rebase" to keep
 duplicated changes.


* jt/grep-wo-submodule-odb-as-alternate (2021-08-13) 8 commits
 - t7814: show lack of alternate ODB-adding
 - submodule-config: pass repo upon blob config read
 - grep: add repository to OID grep sources
 - grep: allocate subrepos on heap
 - grep: read submodule entry with explicit repo
 - grep: typesafe versions of grep_source_init
 - grep: use submodule-ODB-as-alternate lazy-addition
 - submodule: lazily add submodule ODBs as alternates

 The code to make "git grep" recurse into submodules has been
 updated to migrate away from the "add submodule's object store as
 an alternate object store" mechanism (which is suboptimal).


* ps/connectivity-optim (2021-08-09) 5 commits
  (merged to 'next' on 2021-08-24 at 94a7a04ca4)
 + revision: avoid hitting packfiles when commits are in commit-graph
 + commit-graph: split out function to search commit position
 + revision: stop retrieving reference twice
 + connected: do not sort input revisions
 + revision: separate walk and unsorted flags
 (this branch is used by ps/fetch-optim.)

 The revision traversal API has been optimized by taking advantage
 of the commit-graph, when available, to determine if a commit is
 reachable from any of the existing refs.

 Will merge to 'master'.


* ar/submodule-add-more (2021-08-10) 10 commits
 - submodule--helper: rename compute_submodule_clone_url()
 - submodule--helper: remove resolve-relative-url subcommand
 - submodule--helper: remove add-config subcommand
 - submodule--helper: remove add-clone subcommand
 - submodule--helper: convert the bulk of cmd_add() to C
 - dir: libify and export helper functions from clone.c
 - submodule--helper: remove repeated code in sync_submodule()
 - submodule--helper: refactor resolve_relative_url() helper
 - submodule--helper: add options for compute_submodule_clone_url()
 - Merge branch 'ar/submodule-add-config' into ar/submodule-add
 (this branch uses ar/submodule-add-config.)

 More parts of "git submoudle add" has been rewritten in C.


* cb/makefile-apple-clang (2021-08-06) 3 commits
 - build: catch clang that identifies itself as "$VENDOR clang"
 - build: clang version may not be followed by extra words
 - build: update detect-compiler for newer Xcode version

 Build update.

 Will merge to 'next'.


* en/merge-strategy-docs (2021-08-05) 10 commits
  (merged to 'next' on 2021-08-24 at ceb66b1062)
 + Update error message and code comment
 + merge-strategies.txt: add coverage of the `ort` merge strategy
 + git-rebase.txt: correct out-of-date and misleading text about renames
 + merge-strategies.txt: fix simple capitalization error
 + merge-strategies.txt: avoid giving special preference to patience algorithm
 + merge-strategies.txt: do not imply using copy detection is desired
 + merge-strategies.txt: update wording for the resolve strategy
 + Documentation: edit awkward references to `git merge-recursive`
 + directory-rename-detection.txt: small updates due to merge-ort optimizations
 + git-rebase.txt: correct antiquated claims about --rebase-merges
 (this branch is used by en/ort-becomes-the-default.)

 Documentation updates.

 Will merge to 'master'.


* en/ort-becomes-the-default (2021-08-05) 2 commits
  (merged to 'next' on 2021-08-24 at 92f4e08d83)
 + Update docs for change of default merge backend
 + Change default merge backend from recursive to ort
 (this branch uses en/merge-strategy-docs.)

 Use `ort` instead of `recursive` as the default merge strategy.

 Will merge to 'master'.


* js/log-protocol-version (2021-08-10) 1 commit
  (merged to 'next' on 2021-08-24 at aeeaee04fb)
 + connect, protocol: log negotiated protocol version

 Debugging aid.

 Will merge to 'master'.


* ab/lib-subtest (2021-08-05) 11 commits
 - test-lib tests: assert 1 exit code, not non-zero
 - test-lib tests: refactor common part of check_sub_test_lib_test*()
 - test-lib tests: avoid subshell for "test_cmp" for readability
 - test-lib tests: assert no copy/pasted mock test code
 - test-lib tests: get rid of copy/pasted mock test code
 - test-lib tests: don't provide a description for the sub-tests
 - test-lib tests: stop using a subshell in write_sub_test_lib_test()
 - test-lib tests: split up "write and run" into two functions
 - test-lib tests: move "run_sub_test" to a new lib-subtest.sh
 - Merge branch 'ps/t0000-output-directory-fix' into ab/lib-subtest
 - Merge branch 'jk/t0000-subtests-fix' into ab/lib-subtest

 Updates to the tests in t0000 to test the test framework.


* ab/only-single-progress-at-once (2021-07-23) 8 commits
 - progress.c: add & assert a "global_progress" variable
 - pack-bitmap-write.c: add a missing stop_progress()
 - progress.c: add temporary variable from progress struct
 - progress.c: stop eagerly fflush(stderr) when not a terminal
 - progress.c: call progress_interval() from progress_test_force_update()
 - progress.c: move signal handler functions lower
 - progress.c tests: test some invalid usage
 - progress.c tests: make start/stop verbs on stdin

 Further tweaks on progress API.


* ab/progress-users-adjust-counters (2021-08-25) 2 commits
 - entry: show finer-grained counter in "Filtering content" progress line
 - commit-graph: fix bogus counter in "Scanning merged commits" progress line

 The code to show progress indicator in a few codepaths did not
 cover between 0-100%, which has been corrected.

 Will merge to 'next'?


* ar/submodule-add-config (2021-08-10) 1 commit
 - submodule--helper: introduce add-config subcommand
 (this branch is used by ar/submodule-add-more.)

 Large part of "git submodule add" gets rewritten in C.


* dt/submodule-diff-fixes (2021-08-11) 3 commits
 - diff --submodule=diff: don't print failure message twice
 - diff --submodule=diff: do not fail on ever-initialied deleted submodules
 - t4060: remove unused variable

 "git diff --submodule=diff" showed failure from run_command() when
 trying to run diff inside a submodule, when the user manually
 removes the submodule directory.

 Will merge to 'next'?
 cf. <20210812001332.715876-1-dturner@twosigma.com>


* fs/ssh-signing (2021-08-29) 9 commits
 - ssh signing: test that gpg fails for unknown keys
 - ssh signing: tests for logs, tags & push certs
 - ssh signing: duplicate t7510 tests for commits
 - ssh signing: verify signatures using ssh-keygen
 - ssh signing: provide a textual signing_key_id
 - ssh signing: retrieve a default key from ssh-agent
 - ssh signing: add ssh key format and signing code
 - ssh signing: add test prereqs
 - ssh signing: preliminary refactoring and clean-up

 Use ssh public crypto for object and push-cert signing.

 Comments?


* en/pull-conflicting-options (2021-07-22) 8 commits
  (merged to 'next' on 2021-08-24 at e1e5b2c551)
 + pull: fix handling of multiple heads
 + pull: update docs & code for option compatibility with rebasing
 + pull: abort by default when fast-forwarding is not possible
 + pull: make --rebase and --no-rebase override pull.ff=only
 + pull: since --ff-only overrides, handle it first
 + pull: abort if --ff-only is given and fast-forwarding is impossible
 + t7601: add tests of interactions with multiple merge heads and config
 + t7601: test interaction of merge/rebase/fast-forward flags and options

 "git pull" had various corner cases that were not well thought out
 around its --rebase backend, e.g. "git pull --ff-only" did not stop
 but went ahead and rebased when the history on other side is not a
 descendant of our history.  The series tries to fix them up.

 Will merge to 'master'.


* cf/fetch-set-upstream-while-detached (2021-07-06) 1 commit
 - fetch: fix segfault on --set-upstream while on a detached HEAD

 "git fetch --set-upstream" while on detached HEAD segfaulted
 instead of noticing that such an operation did not make sense.

 Expecting a reroll.
 cf. <xmqqsg0ri5mq.fsf@gitster.g>


* ab/make-tags-cleanup (2021-08-05) 5 commits
 - Makefile: normalize clobbering & xargs for tags targets
 - Makefile: remove "cscope.out", not "cscope*" in cscope.out target
 - Makefile: don't use "FORCE" for tags targets
 - Makefile: add QUIET_GEN to "cscope" target
 - Makefile: move ".PHONY: cscope" near its target

 Build clean-up for "make tags" and friends.

 Expecting a reroll.
 4/5 may want a minor tweak to the log and the patch text but otherwise looks good.


* tb/multi-pack-bitmaps (2021-08-24) 25 commits
 - p5326: perf tests for MIDX bitmaps
 - p5310: extract full and partial bitmap tests
 - midx: respect 'GIT_TEST_MULTI_PACK_INDEX_WRITE_BITMAP'
 - t7700: update to work with MIDX bitmap test knob
 - t5319: don't write MIDX bitmaps in t5319
 - t5310: disable GIT_TEST_MULTI_PACK_INDEX_WRITE_BITMAP
 - t0410: disable GIT_TEST_MULTI_PACK_INDEX_WRITE_BITMAP
 - t5326: test multi-pack bitmap behavior
 - t/helper/test-read-midx.c: add --checksum mode
 - t5310: move some tests to lib-bitmap.sh
 - pack-bitmap: write multi-pack bitmaps
 - pack-bitmap: read multi-pack bitmaps
 - pack-bitmap.c: avoid redundant calls to try_partial_reuse
 - pack-bitmap.c: introduce 'bitmap_is_preferred_refname()'
 - pack-bitmap.c: introduce 'nth_bitmap_object_oid()'
 - pack-bitmap.c: introduce 'bitmap_num_objects()'
 - midx: avoid opening multiple MIDXs when writing
 - midx: close linked MIDXs, avoid leaking memory
 - midx: infer preferred pack when not given one
 - midx: reject empty `--preferred-pack`'s
 - midx: clear auxiliary .rev after replacing the MIDX
 - Documentation: describe MIDX-based bitmaps
 - pack-bitmap-write.c: free existing bitmaps
 - pack-bitmap-write.c: gracefully fail to write non-closed bitmaps
 - pack-bitmap.c: harden 'test_bitmap_walk()' to check type bitmaps

 The reachability bitmap file used to be generated only for a single
 pack, but now we've learned to generate bitmaps for history that
 span across multiple packfiles.

 Comments?


* ab/config-based-hooks-base (2021-08-03) 36 commits
 - hooks: fix a TOCTOU in "did we run a hook?" heuristic
 - receive-pack: convert receive hooks to hook.h
 - post-update: use hook.h library
 - receive-pack: convert 'update' hook to hook.h
 - hooks: allow callers to capture output
 - run-command: allow capturing of collated output
 - reference-transaction: use hook.h to run hooks
 - hook tests: use a modern style for "pre-push" tests
 - hook tests: test for exact "pre-push" hook input
 - transport: convert pre-push hook to hook.h
 - hook: convert 'post-rewrite' hook in sequencer.c to hook.h
 - hook: provide stdin by string_list or callback
 - run-command: add stdin callback for parallelization
 - am: convert 'post-rewrite' hook to hook.h
 - hook: support passing stdin to hooks
 - run-command: allow stdin for run_processes_parallel
 - run-command: remove old run_hook_{le,ve}() hook API
 - receive-pack: convert push-to-checkout hook to hook.h
 - read-cache: convert post-index-change to use hook.h
 - commit: convert {pre-commit,prepare-commit-msg} hook to hook.h
 - git-p4: use 'git hook' to run hooks
 - send-email: use 'git hook run' for 'sendemail-validate'
 - git hook run: add an --ignore-missing flag
 - merge: convert post-merge to use hook.h
 - hooks: convert 'post-checkout' hook to hook library
 - am: convert applypatch to use hook.h
 - rebase: convert pre-rebase to use hook.h
 - gc: use hook library for pre-auto-gc hook
 - hook: add 'run' subcommand
 - hook-list.h: add a generated list of hooks, like config-list.h
 - hook.c users: use "hook_exists()" insted of "find_hook()"
 - hook.c: add a hook_exists() wrapper and use it in bugreport.c
 - hook.[ch]: move find_hook() to this new library
 - Makefile: remove an out-of-date comment
 - Makefile: stop hardcoding {command,config}-list.h
 - Makefile: mark "check" target as .PHONY
 (this branch is used by es/config-based-hooks.)

 Restructuring of (a subset of) Emily's config-based-hooks series,
 to demonstrate that a series can be presented as a more logical and
 focused progression.

 Waiting for reviews.


* ab/serve-cleanup (2021-08-05) 10 commits
 - upload-pack: document and rename --advertise-refs
 - serve.[ch]: remove "serve_options", split up --advertise-refs code
 - {upload,receive}-pack tests: add --advertise-refs tests
 - serve.c: move version line to advertise_capabilities()
 - serve: move transfer.advertiseSID check into session_id_advertise()
 - serve.[ch]: don't pass "struct strvec *keys" to commands
 - serve: use designated initializers
 - transport: use designated initializers
 - transport: rename "fetch" in transport_vtable to "fetch_refs"
 - serve: mark has_capability() as static

 Code clean-up around "git serve".

 Expecting a reroll.


* ab/test-tool-cache-cleanup (2021-08-24) 4 commits
 - read-cache perf: add a perf test for refresh_index()
 - test-tool: migrate read-cache-again to parse_options()
 - test-tool: migrate read-cache-perf to parse_options()
 - test-tool: split up test-tool read-cache

 Test code shuffling.


* ab/pack-objects-stdin (2021-07-09) 5 commits
 - pack-objects.c: make use of REV_INFO_STDIN_LINE_PROCESS
 - pack-objects.c: do stdin parsing via revision.c's API
 - revision.[ch]: add a "handle_stdin_line" API
 - revision.h: refactor "disable_stdin" and "read_from_stdin"
 - upload-pack: run is_repository_shallow() before setup_revisions()

 Introduce handle_stdin_line callback to revision API and uses it.

 Waiting for reviews.


* pw/diff-color-moved-fix (2021-08-05) 13 commits
 - diff: drop unused options parameter from cmp_in_block_with_wsd()
 - diff --color-moved: intern strings
 - diff: use designated initializers for emitted_diff_symbol
 - diff --color-moved-ws=allow-indentation-change: improve hash lookups
 - diff --color-moved: stop clearing potential moved blocks
 - diff --color-moved: shrink potential moved blocks as we go
 - diff --color-moved: unify moved block growth functions
 - diff --color-moved: call comparison function directly
 - diff --color-moved-ws=allow-indentation-change: simplify and optimize
 - diff: simplify allow-indentation-change delta calculation
 - diff --color-moved: avoid false short line matches and bad zerba coloring
 - diff --color-moved=zebra: fix alternate coloring
 - diff --color-moved: add perf tests

 Originally merged to 'next' on 2021-08-05

 Long-overdue correctness and performance update to "diff
 --color-moved" feature.

 Eject for reroll.
 cf. <8bec1a6d-5052-50c3-4100-e6348289d581@gmail.com>


* hn/reftable (2021-08-26) 29 commits
 - SQUASH??? https://github.com/git/git/runs/3439941236?check_suite_focus=true#step:5:700
 - reftable: fixup for new base topic 3/3
 - reftable: fixup for new base topic 2/3
 - reftable: fixup for new base topic 1/3
 - t1404: annotate test cases with REFFILES
 - t1401,t2011: parameterize HEAD.lock for REFFILES
 - t1301: document what needs to be done for reftable
 - Add "test-tool dump-reftable" command.
 - git-prompt: prepare for reftable refs backend
 - refs: RFC: Reftable support for git-core
 - reftable: add dump utility
 - reftable: implement stack, a mutable database of reftable files.
 - reftable: implement refname validation
 - reftable: add merged table view
 - reftable: add a heap-based priority queue for reftable records
 - reftable: reftable file level tests
 - reftable: read reftable files
 - reftable: generic interface to tables
 - reftable: write reftable files
 - reftable: a generic binary tree implementation
 - reftable: reading/writing blocks
 - Provide zlib's uncompress2 from compat/zlib-compat.c
 - reftable: (de)serialization for the polymorphic record type.
 - reftable: add blocksource, an abstraction for random access reads
 - reftable: utility functions
 - reftable: add error related functionality
 - reftable: RFC: add LICENSE
 - init-db: set the_repository->hash_algo early on
 - hash.h: provide constants for the hash IDs
 (this branch uses ab/refs-errno-cleanup, ab/refs-files-cleanup and hn/refs-errno-cleanup.)

 The "reftable" backend for the refs API.


* ab/refs-files-cleanup (2021-08-25) 13 commits
 - refs/files: remove unused "errno != ENOTDIR" condition
 - refs/files: remove unused "errno == EISDIR" code
 - refs/files: remove unused "oid" in lock_ref_oid_basic()
 - refs API: remove OID argument to reflog_expire()
 - reflog expire: don't lock reflogs using previously seen OID
 - refs/files: add a comment about refs_reflog_exists() call
 - refs: make repo_dwim_log() accept a NULL oid
 - refs/debug: re-indent argument list for "prepare"
 - refs/files: remove unused "skip" in lock_raw_ref() too
 - refs/files: remove unused "extras/skip" in lock_ref_oid_basic()
 - refs: drop unused "flags" parameter to lock_ref_oid_basic()
 - refs/files: remove unused REF_DELETING in lock_ref_oid_basic()
 - refs/packet: add missing BUG() invocations to reflog callbacks
 (this branch is used by ab/refs-errno-cleanup, hn/refs-errno-cleanup and hn/reftable.)

 Continued work on top of the hn/refs-errno-cleanup topic.


* hn/refs-errno-cleanup (2021-08-25) 4 commits
 - refs: make errno output explicit for read_raw_ref_fn
 - refs/files-backend: stop setting errno from lock_ref_oid_basic
 - refs: remove EINVAL errno output from specification of read_raw_ref_fn
 - refs file backend: move raceproof_create_file() here
 (this branch is used by ab/refs-errno-cleanup and hn/reftable; uses ab/refs-files-cleanup.)

 Futz with the way 'errno' is relied on in the refs API to carry the
 failure modes up the callchain.


* jh/builtin-fsmonitor (2021-08-26) 36 commits
 - SQUASH??? https://github.com/git/git/runs/3438543601?check_suite_focus=true#step:5:136
 - BANDAID: sparse fixes
 - t7527: test FS event reporing on MacOS WRT case and Unicode
 - fsmonitor: handle shortname for .git
 - t7527: test status with untracked-cache and fsmonitor--daemon
 - fsmonitor: force update index after large responses
 - fsmonitor: enhance existing comments
 - fsmonitor--daemon: use a cookie file to sync with file system
 - fsmonitor--daemon: periodically truncate list of modified files
 - t7527: create test for fsmonitor--daemon
 - t/perf/p7519: add fsmonitor--daemon test cases
 - t/perf: avoid copying builtin fsmonitor files into test repo
 - t/perf/p7519: speed up test using "test-tool touch"
 - t/helper/test-touch: add helper to touch a series of files
 - fsmonitor--daemon: implement handle_client callback
 - fsmonitor-fs-listen-macos: implement FSEvent listener on MacOS
 - fsmonitor-fs-listen-macos: add macos header files for FSEvent
 - fsmonitor-fs-listen-win32: implement FSMonitor backend on Windows
 - fsmonitor--daemon: create token-based changed path cache
 - fsmonitor--daemon: define token-ids
 - fsmonitor--daemon: add pathname classification
 - fsmonitor: do not try to operate on bare repos
 - fsmonitor--daemon: implement 'start' command
 - fsmonitor--daemon: implement 'run' command
 - fsmonitor-fs-listen-macos: stub in backend for MacOS
 - fsmonitor-fs-listen-win32: stub in backend for Windows
 - t/helper/fsmonitor-client: create IPC client to talk to FSMonitor Daemon
 - fsmonitor--daemon: implement 'stop' and 'status' commands
 - fsmonitor--daemon: add a built-in fsmonitor daemon
 - fsmonitor: use IPC to query the builtin FSMonitor daemon
 - fsmonitor: config settings are repository-specific
 - help: include fsmonitor--daemon feature flag in version info
 - fsmonitor-ipc: create client routines for git-fsmonitor--daemon
 - fsmonitor--daemon: update fsmonitor documentation
 - fsmonitor--daemon: man page
 - simple-ipc: preparations for supporting binary messages.

 An attempt to write and ship with a watchman equivalent tailored
 for our use.

 Expecting a reroll post 2.33 release.

--------------------------------------------------
[Discarded]

* zh/cherry-pick-help-is-only-for-sequencer (2021-08-03) 2 commits
 . cherry-pick: use better advice message
 . cherry-pick: fix bug when used with GIT_CHERRY_PICK_HELP

 Originally merged to 'next' on 2021-08-04

 "git cherry-pick" loses its state file when a stray
 GIT_CHERRY_PICK_HELP environment is present, which has been
 corrected.

 Reverted out of 'next' at 1f62d2e1 on 2021-08-11


* jk/refs-files-cleanup-cleanup (2021-08-19) 1 commit
 . refs: drop unused "flags" parameter to lock_ref_oid_basic()

 Code cleanup.

 Obsoleted by updated ab/refs-files-cleanup


* ow/clone-bare-origin (2021-08-03) 1 commit
 - clone: Allow combining --bare and --origin

 "git clone" did not like to take "--bare" and "--origin=X" at the
 same time; loosen the restriction.

 cf. <20210802174944.53745-1-oystwa@gmail.com>


* jc/trivial-threeway-binary-merge (2021-07-28) 1 commit
 - ll-merge: teach ll_binary_merge() a trivial three-way merge

 The built-in merge driver for binary files learned to resolve
 trivial three-way merges (e.g. apply change, which turns A into B,
 to content A) by itself, which would help "git apply --3way" used
 when there is no need to use "--3way".

 Will discard.
 Replace with a trivial-merge logic in apply.c::try_treeway() or
 apply.c::three_way_merge().


* np/blame-ignore-revs-file-may-be-optional (2021-08-09) 1 commit
 - blame: add config `blame.ignoreRevsFileIsOptional`

 When the file named by blame.ignoreRevsFile configuration variable
 does not exist, it causes "git blame" to die.  Sometimes, it is
 useful if the files named by configuration variables can be made
 optional (it would allow ~/.gitconfig to give a filename, and make
 it effective only in repositories that have a file with that name).

 This uses an extra variable that marks that the variable is
 optional.  Yet another alternative is being discussed to define
 syntax for "optional" filename values, so that the same mechanism
 can be used for not just blame.ignoreRevsFile but other filenames.

 Queued just as a reminder of the theme.

Re: What's cooking in git.git (Aug 2021, #09; Sun, 29)

[Ævar Arnfjörð Bjarmason]

On Sun, Aug 29 2021, Junio C Hamano wrote:

> I've been a bit under the weather during the last week and wanted to
> concentrate on what to push out to 'master', so while I may have
> picked up new topics and replaced existing topics with their new
> versions, I haven't added or updated my summaries on their doneness
> to this document.  Help is appreciated.

Sorry to hear that, hope you're in good health now.

Below is my usual summary of my topics + topics I've got comments on.

Please take the below comments in the spirit of helping you along
whenever you can get to them, and not as needless prodding to prioritize
them in particular over others.

Also re your <xmqqbl5ml70u.fsf@gitster.g> I'll switch to quoting
Message-ID's in that style, and not as
https://lore.kernel.org/git/<msgid> links. FWIW I was doing the latter
for the benefit of readers on the sidelines, but will switch.

> [Graduated to 'master']
> [...]
> * ab/bundle-doc (2021-08-02) 4 commits

Thanks!

> * ab/http-drop-old-curl (2021-07-30) 5 commits

Thanks. I've got those changes to introduce a git-curl-compat.h etc. on
top ready to go, but haven't submitted them considering the amount of
things I've got outstanding, but if you'd like them sooner than later...

> * ab/pack-stdin-packs-fix (2021-07-09) 2 commits

Thanks!

> * hn/refs-test-cleanup (2021-08-02) 11 commits

Yay, more of reftable moving forward...

> [...]
> [New Topics]
>
> * ab/commit-graph-usage (2021-08-25) 7 commits
>  - commit-graph: show "unexpected subcommand" error
>  - commit-graph: show usage on "commit-graph [write|verify] garbage"
>  - commit-graph: early exit to "usage" on !argc
>  - multi-pack-index: refactor "goto usage" pattern
>  - commit-graph: use parse_options_concat()
>  - commit-graph: remove redundant handling of -h
>  - commit-graph: define common usage with a macro

Taylor, SZEDER: That's at
<cover-v4-0.7-00000000000-20210823T122854Z-avarab@gmail.com>, you
reviwed the earlier
<cover-0.6-00000000000-20210720T113707Z-avarab@gmail.com>, what do you
think about this version?

> * ab/ls-remote-packet-trace (2021-08-24) 1 commit

Thanks!

> * ab/rebase-fatal-fatal-fix (2021-08-24) 1 commit

Thanks!

> * ab/refs-errno-cleanup (2021-08-25) 4 commits
>  - refs: make errno output explicit for refs_resolve_ref_unsafe
>  - refs: explicitly return failure_errno from parse_loose_ref_contents
>  - branch tests: test for errno propagating on failing read
>  - refs: add failure_errno to refs_read_raw_ref() signature
>  (this branch is used by hn/reftable; uses ab/refs-files-cleanup and hn/refs-errno-cleanup.)
>
>  The "remainder" of hn/refs-errno-cleanup topic.

Thanks, and thanks for bearing with me on the whole
ab/refs-errno-cleanup & hn/refs-errno-cleanup v.s. hn/reftable ordering
question.

> * ab/retire-advice-config (2021-08-25) 4 commits
>  - advice: move advice.graftFileDeprecated squashing to commit.[ch]
>  - advice: remove use of global advice_add_embedded_repo
>  - advice: remove read uses of most global `advice_` variables
>  - advice: add enum variants for missing advice variables
>
>  Code clean up to migrate callers from older advice_config[] based
>  API to newer advice_if_enabled() and advice_enabled() API.
>
>  Want to merge to 'next' but a tree-wide change like this can
>  interfere other topics in flight, so I'll need to block some time
>  to see how safe it is to proceed before we can do so.

As you've doubtless found out, since this series doesn't change the
advice.h API a patch like the outstanding
<7749a69a38faeceadc7a8735fb3d0edd359c954c.1629842085.git.gitgitgadget@gmail.com>
by Derrick Stolee doesn't conflict with it, but the scaffolding part in
<496da0b17476011b4ef4dde31593afc7572246eb.1628623058.git.steadmon@google.com>
by Josh Steadmon does.

I think in this case the least painful thing overall is to get this
topic merged down to "master" sooner than later, i.e. before we get more
patches needing advice.c changes based on top of the current master.

But alternatively I could re-roll and split up
<patch-v4-4.4-7f79fb282e5-20210823T103719Z-avarab@gmail.com> and leave
the "static struct" in place with some dummy variable, purely to make
resolving any merge conflicts easier for you. We'd then eventually drop
that scaffolding later.

Or I could do nothing and you could merge this down at whatever pace
you're OK with. Just let me know if I can help make it easier in any
way.

> * ab/unbundle-progress (2021-08-27) 5 commits

This has outstanding feedback at
<cover-v3-0.5-00000000000-20210826T140414Z-avarab@gmail.com> that I need
to respond to.

> * ab/fsck-unexpected-type (2021-07-12) 21 commits
>  - fsck: report invalid object type-path combinations
>  - fsck: report invalid types recorded in objects
>  - object-store.h: move read_loose_object() below 'struct object_info'
>  - fsck: don't hard die on invalid object types
>  - object-file.c: return -2 on "header too long" in unpack_loose_header()
>  - object-file.c: return -1, not "status" from unpack_loose_header()
>  - object-file.c: guard against future bugs in loose_object_info()
>  - object-file.c: stop dying in parse_loose_header()
>  - object-file.c: split up ternary in parse_loose_header()
>  - object-file.c: simplify unpack_loose_short_header()
>  - object-file.c: add missing braces to loose_object_info()
>  - object-file.c: make parse_loose_header_extended() public
>  - object-file.c: don't set "typep" when returning non-zero
>  - cache.h: move object functions to object-store.h
>  - cat-file tests: test for current --allow-unknown-type behavior
>  - cat-file tests: add corrupt loose object test
>  - rev-list tests: test for behavior with invalid object types
>  - cat-file tests: test that --allow-unknown-type isn't on by default
>  - cat-file tests: test for missing object with -t and -s
>  - fsck tests: add test for fsck-ing an unknown type
>  - fsck tests: refactor one test to use a sub-repo
>
>  "git fsck" has been taught to report mismatch between expected and
>  actual types of an object better.
>
>  Needs review.

:( @ the no takers in reviewing it. E.g. at
<87v93wflm0.fsf@evledraar.gmail.com>.

> * zh/cherry-pick-advice (2021-08-23) 1 commit
>  - cherry-pick: use better advice message
>
>  The advice message that "git cherry-pick" gives when it asks
>  conflicted replay of a commit to be resolved by the end user has
>  been updated.
>
>  Will merge to 'next'?

I think so, I looked it over as part of browsing advice()-related
changes, looks good to me.

> * es/config-based-hooks (2021-08-19) 7 commits
>  - hook: allow out-of-repo 'git hook' invocations
>  - hook: include hooks from the config
>  - hook: allow running non-native hooks
>  - hook: introduce "git hook list"
>  - hook: allow parallel hook execution
>  - hook: run a list of hooks instead
>  - Merge branch 'ab/config-based-hooks-base' into es/config-based-hooks
>  (this branch uses ab/config-based-hooks-base.)
>
>  Revamp the hooks subsystem to allow multiple of them to trigger
>  upon the same event and control via the configuration variables.
>
>  Will merge to 'next'?
>  cf. <87v93wflm0.fsf@evledraar.gmail.com>

This needs a re-roll based on my comments in reply to
<20210819033450.3382652-1-emilyshaffer@google.com>. It's mostly ready as
far as the end-state is concerneb, but e.g. will break "rebase" (a
commit in the middle doesn't compile), leaks memory etc.

It needs a re-roll of ab/config-based-hooks-base, which I was waiting on
some of Emily's feedback to do. Looks like there's no outstanding things
there, so iwll work on that SOON.

> * js/advise-when-skipping-cherry-picked (2021-08-10) 2 commits
>  - SQUASH???
>  - sequencer: advise if skipping cherry-picked commit
>
>  "git rebase" by default skips changes that are equivalent to
>  commits that are already in the history the branch is rebased onto;
>  give messages when this happens to let the users be aware of
>  skipped commits, and also teach them how to tell "rebase" to keep
>  duplicated changes.

This LGTM with your proposed obviously-correct squash.

Re comment about ab/retire-advice-config above: I could also just fold
this into that series if you'd prefer, i.e. it would be one way to deal
with the only outstanding merge conflict in advice.c between
master..seen.

> * cb/makefile-apple-clang (2021-08-06) 3 commits
>  - build: catch clang that identifies itself as "$VENDOR clang"
>  - build: clang version may not be followed by extra words
>  - build: update detect-compiler for newer Xcode version
>
>  Build update.
>
>  Will merge to 'next'.

Makes sense. Any reason other than lack of time that you opted not to go
for the IMO simpler approach I suggested in
<87bl6aypke.fsf@evledraar.gmail.com>?

> * ab/lib-subtest (2021-08-05) 11 commits
>  - test-lib tests: assert 1 exit code, not non-zero
>  - test-lib tests: refactor common part of check_sub_test_lib_test*()
>  - test-lib tests: avoid subshell for "test_cmp" for readability
>  - test-lib tests: assert no copy/pasted mock test code
>  - test-lib tests: get rid of copy/pasted mock test code
>  - test-lib tests: don't provide a description for the sub-tests
>  - test-lib tests: stop using a subshell in write_sub_test_lib_test()
>  - test-lib tests: split up "write and run" into two functions
>  - test-lib tests: move "run_sub_test" to a new lib-subtest.sh
>  - Merge branch 'ps/t0000-output-directory-fix' into ab/lib-subtest
>  - Merge branch 'jk/t0000-subtests-fix' into ab/lib-subtest
>
>  Updates to the tests in t0000 to test the test framework.

I think with my re-roll at
<cover-v3-0.9-0000000000-20210805T103237Z-avarab@gmail.com> it should be
OK to declare this good to go sooner than later. I.e. the only trouble I
can imagine this causing in
<patch-v3-6.9-bc79b29f3c-20210805T103237Z-avarab@gmail.com> is now easy
to revert in isolation.

> * ab/only-single-progress-at-once (2021-07-23) 8 commits
>  - progress.c: add & assert a "global_progress" variable
>  - pack-bitmap-write.c: add a missing stop_progress()
>  - progress.c: add temporary variable from progress struct
>  - progress.c: stop eagerly fflush(stderr) when not a terminal
>  - progress.c: call progress_interval() from progress_test_force_update()
>  - progress.c: move signal handler functions lower
>  - progress.c tests: test some invalid usage
>  - progress.c tests: make start/stop verbs on stdin
>
>  Further tweaks on progress API.

(Summary copied from <87v93wflm0.fsf@evledraar.gmail.com>)

The changes are rather straightforward, see
<cover-0.8-0000000000-20210722T125012Z-avarab@gmail.com>; so if anyone's
interested in reviewing them.

There's been no reports of anyone running into the new BUG() assertion
in 8/8 of it: <patch-8.8-1a14176bee-20210722T125012Z-avarab@gmail.com>

> * ab/progress-users-adjust-counters (2021-08-25) 2 commits
>  - entry: show finer-grained counter in "Filtering content" progress line
>  - commit-graph: fix bogus counter in "Scanning merged commits" progress line
>
>  The code to show progress indicator in a few codepaths did not
>  cover between 0-100%, which has been corrected.
>
>  Will merge to 'next'?

Yes, should be good to go with my re-roll at
<cover-v3-0.2-00000000000-20210823T102722Z-avarab@gmail.com>, which
you've picked up here.

> * fs/ssh-signing (2021-08-29) 9 commits
>  - ssh signing: test that gpg fails for unknown keys
>  - ssh signing: tests for logs, tags & push certs
>  - ssh signing: duplicate t7510 tests for commits
>  - ssh signing: verify signatures using ssh-keygen
>  - ssh signing: provide a textual signing_key_id
>  - ssh signing: retrieve a default key from ssh-agent
>  - ssh signing: add ssh key format and signing code
>  - ssh signing: add test prereqs
>  - ssh signing: preliminary refactoring and clean-up
>
>  Use ssh public crypto for object and push-cert signing.
>
>  Comments?

I'm also interested in this one. My reading of
<9075cdd1-e34d-5dcb-f2b8-69ae4abf587b@gigacodes.de> is that the author
plans to re-roll it sometimes around mid-September. I personally punted
on reviewing the current version while waiting for that.

> * cf/fetch-set-upstream-while-detached (2021-07-06) 1 commit
>  - fetch: fix segfault on --set-upstream while on a detached HEAD
>
>  "git fetch --set-upstream" while on detached HEAD segfaulted
>  instead of noticing that such an operation did not make sense.
>
>  Expecting a reroll.
>  cf. <xmqqsg0ri5mq.fsf@gitster.g>

I think the author's comment in reply to my
<patch-v2-1.1-9e846b76959-20210823T125434Z-avarab@gmail.com> can be read
as them being happy to go with my alternate version, but CC'd them.

I'll re-roll with what I noted in <87bl5nfcof.fsf@evledraar.gmail.com>,
which amounts to a cosmetic change, but is probably easier to read.

> * ab/make-tags-cleanup (2021-08-05) 5 commits
>  - Makefile: normalize clobbering & xargs for tags targets
>  - Makefile: remove "cscope.out", not "cscope*" in cscope.out target
>  - Makefile: don't use "FORCE" for tags targets
>  - Makefile: add QUIET_GEN to "cscope" target
>  - Makefile: move ".PHONY: cscope" near its target
>
>  Build clean-up for "make tags" and friends.
>
>  Expecting a reroll.
>  4/5 may want a minor tweak to the log and the patch text but otherwise looks good.

(Summary copied from <87v93wflm0.fsf@evledraar.gmail.com>)

This entire comment has been in What's Cooking since v3 of the series,
but v4 has been out since August 4th:
<cover-v4-0.5-00000000000-20210804T225222Z-avarab@gmail.com>

> * ab/config-based-hooks-base (2021-08-03) 36 commits
> [...]
>  Restructuring of (a subset of) Emily's config-based-hooks series,
>  to demonstrate that a series can be presented as a more logical and
>  focused progression.
>
>  Waiting for reviews.

See above comment for ab/config-based-hooks-base.

> * ab/serve-cleanup (2021-08-05) 10 commits
>  - upload-pack: document and rename --advertise-refs
>  - serve.[ch]: remove "serve_options", split up --advertise-refs code
>  - {upload,receive}-pack tests: add --advertise-refs tests
>  - serve.c: move version line to advertise_capabilities()
>  - serve: move transfer.advertiseSID check into session_id_advertise()
>  - serve.[ch]: don't pass "struct strvec *keys" to commands
>  - serve: use designated initializers
>  - transport: use designated initializers
>  - transport: rename "fetch" in transport_vtable to "fetch_refs"
>  - serve: mark has_capability() as static
>
>  Code clean-up around "git serve".
>
>  Expecting a reroll.

(Summary copied from <87v93wflm0.fsf@evledraar.gmail.com>)

The "Expecting a reroll" here was added in response to (I think) my
commentary in <87wnp1mqv2.fsf@evledraar.gmail.com> that I'd re-roll it,
but the already picked up v4 is that re-roll:
<cover-v4-00.10-00000000000-20210805T011823Z-avarab@gmail.com>

> * ab/test-tool-cache-cleanup (2021-08-24) 4 commits
>  - read-cache perf: add a perf test for refresh_index()
>  - test-tool: migrate read-cache-again to parse_options()
>  - test-tool: migrate read-cache-perf to parse_options()
>  - test-tool: split up test-tool read-cache
>
>  Test code shuffling.

I had a "take it or leave it" comment at
<878s0nz5q2.fsf@evledraar.gmail.com>.

> * ab/pack-objects-stdin (2021-07-09) 5 commits
>  - pack-objects.c: make use of REV_INFO_STDIN_LINE_PROCESS
>  - pack-objects.c: do stdin parsing via revision.c's API
>  - revision.[ch]: add a "handle_stdin_line" API
>  - revision.h: refactor "disable_stdin" and "read_from_stdin"
>  - upload-pack: run is_repository_shallow() before setup_revisions()
>
>  Introduce handle_stdin_line callback to revision API and uses it.
>
>  Waiting for reviews.

I had a series waiting to be submitted that depends on this and
ab/bundle-doc, since ab/bundle-doc has landed I think I'll re-roll this
with that feature series appended, to see if there's more interest once
the end-state I was going for is known...

> * hn/reftable (2021-08-26) 29 commits
>  - SQUASH??? https://github.com/git/git/runs/3439941236?check_suite_focus=true#step:5:700
>  - reftable: fixup for new base topic 3/3
>  - reftable: fixup for new base topic 2/3
>  - reftable: fixup for new base topic 1/3
>  - t1404: annotate test cases with REFFILES
>  - t1401,t2011: parameterize HEAD.lock for REFFILES
>  - t1301: document what needs to be done for reftable
>  - Add "test-tool dump-reftable" command.
>  - git-prompt: prepare for reftable refs backend
>  - refs: RFC: Reftable support for git-core
>  - reftable: add dump utility
>  - reftable: implement stack, a mutable database of reftable files.
>  - reftable: implement refname validation
>  - reftable: add merged table view
>  - reftable: add a heap-based priority queue for reftable records
>  - reftable: reftable file level tests
>  - reftable: read reftable files
>  - reftable: generic interface to tables
>  - reftable: write reftable files
>  - reftable: a generic binary tree implementation
>  - reftable: reading/writing blocks
>  - Provide zlib's uncompress2 from compat/zlib-compat.c
>  - reftable: (de)serialization for the polymorphic record type.
>  - reftable: add blocksource, an abstraction for random access reads
>  - reftable: utility functions
>  - reftable: add error related functionality
>  - reftable: RFC: add LICENSE
>  - init-db: set the_repository->hash_algo early on
>  - hash.h: provide constants for the hash IDs
>  (this branch uses ab/refs-errno-cleanup, ab/refs-files-cleanup and hn/refs-errno-cleanup.)
>
>  The "reftable" backend for the refs API.

Han-Wen: It would be really nice to have this re-rolled sooner than
later, my and Junio's "fixup" commits at the end are a band-aid, but I
already ran into wanting to bisect something between master..seen that
was unnecessarily painful due to the series now not compiling without
the "fixup" commits at the end.

> * ab/refs-files-cleanup (2021-08-25) 13 commits
> [...]
> * hn/refs-errno-cleanup (2021-08-25) 4 commits
> [...]
>
>  Futz with the way 'errno' is relied on in the refs API to carry the
>  failure modes up the callchain.

As noted in the comment for ab/refs-errno-cleanup above, thanks!

Re: What's cooking in git.git (Aug 2021, #09; Sun, 29)

[Han-Wen Nienhuys]

On Mon, Aug 30, 2021 at 2:03 PM Ævar Arnfjörð Bjarmason
<avarab@gmail.com> wrote:

> Han-Wen: It would be really nice to have this re-rolled sooner than
> later, my and Junio's "fixup" commits at the end are a band-aid, but I
> already ran into wanting to bisect something between master..seen that
> was unnecessarily painful due to the series now not compiling without
> the "fixup" commits at the end.

I am folding in the __FUNCTION__ fix.

However, I thought patches should be sent against the master branch
and not against some intermediate  version of 'seen' ?

-- 
Han-Wen Nienhuys - Google Munich
I work 80%. Don't expect answers from me on Fridays.
--

Google Germany GmbH, Erika-Mann-Strasse 33, 80636 Munich

Registergericht und -nummer: Hamburg, HRB 86891

Sitz der Gesellschaft: Hamburg

Geschäftsführer: Paul Manicle, Halimah DeLaine Prado

Re: What's cooking in git.git (Aug 2021, #09; Sun, 29)

[Ævar Arnfjörð Bjarmason]

On Mon, Aug 30 2021, Han-Wen Nienhuys wrote:

> On Mon, Aug 30, 2021 at 2:03 PM Ævar Arnfjörð Bjarmason
> <avarab@gmail.com> wrote:
>
>> Han-Wen: It would be really nice to have this re-rolled sooner than
>> later, my and Junio's "fixup" commits at the end are a band-aid, but I
>> already ran into wanting to bisect something between master..seen that
>> was unnecessarily painful due to the series now not compiling without
>> the "fixup" commits at the end.
>
> I am folding in the __FUNCTION__ fix.
>
> However, I thought patches should be sent against the master branch
> and not against some intermediate  version of 'seen' ?

No, per "Decide what to base your work on" in
Documentation/SubmittingPatches. See the part about "A new feature
should be based on `master` in general[...]".

In this case the topic on Junio's side isn't based on "master", hence
the bisect breakages noted above.

I don't know per the upthread what Junio's intended pace of merging down
ab/refs-files-cleanup and hn/refs-errno-cleanup is, depending on the
answer to that perhaps it would be best to wait and re-roll on a new
master.

Also for any re-roll of hn/refable, see my
<877dgch4rn.fsf@evledraar.gmail.com> for notes of other breakages in
it. I also had the impression based on my
<87h7jqz7k5.fsf@evledraar.gmail.com> and your reply in
<CAFQ2z_P8vgY0RRT+XSH9K3VDQt39FLqXx6qfeZqaZPkwhq1w+A@mail.gmail.com>
back in April/May that the intent was to re-roll this topic in a way
that would be more split-up as described there.

I don't care much about the exact end-state there, other than:

 1. Trying to land reftable/ in some shape where we're not constantly
    re-reviewing the "add upstream library" part of it.

 2. Not have something like hn/reftable in-tree which per my above is in
    a demonstrably broken/experimental state, but our docs are in state
    of noting it like it's just another ref backend. Hence the
    suggestion of first landing the library with its own tests, getting
    the integration and GIT_TEST_REFABLE passing, and finally updating
    docs etc. to advertise the thing to users.

Re: What's cooking in git.git (Aug 2021, #09; Sun, 29)

[Han-Wen Nienhuys]

On Mon, Aug 30, 2021 at 3:42 PM Ævar Arnfjörð Bjarmason
<avarab@gmail.com> wrote:
>
>
> On Mon, Aug 30 2021, Han-Wen Nienhuys wrote:
>
> > On Mon, Aug 30, 2021 at 2:03 PM Ævar Arnfjörð Bjarmason
> > <avarab@gmail.com> wrote:
> >
> >> Han-Wen: It would be really nice to have this re-rolled sooner than
> >> later, my and Junio's "fixup" commits at the end are a band-aid, but I
> >> already ran into wanting to bisect something between master..seen that
> >> was unnecessarily painful due to the series now not compiling without
> >> the "fixup" commits at the end.
> >
> > I am folding in the __FUNCTION__ fix.
> >
> > However, I thought patches should be sent against the master branch
> > and not against some intermediate  version of 'seen' ?
>
> No, per "Decide what to base your work on" in
> Documentation/SubmittingPatches. See the part about "A new feature
> should be based on `master` in general[...]".
>
> In this case the topic on Junio's side isn't based on "master", hence
> the bisect breakages noted above.
>
> I don't know per the upthread what Junio's intended pace of merging down
> ab/refs-files-cleanup and hn/refs-errno-cleanup is, depending on the
> answer to that perhaps it would be best to wait and re-roll on a new
> master.

It's perf season here, so I don't have a lot of time to work on this.
It's probably the most efficient use of time to back out the reftable
series from seen until the errno refactoring lands in master. I can
rebase the reftable topic then.

> Also for any re-roll of hn/refable, see my
> <877dgch4rn.fsf@evledraar.gmail.com> for notes of other breakages in
> it. I also had the impression based on my
> <87h7jqz7k5.fsf@evledraar.gmail.com> and your reply in
> <CAFQ2z_P8vgY0RRT+XSH9K3VDQt39FLqXx6qfeZqaZPkwhq1w+A@mail.gmail.com>
> back in April/May that the intent was to re-roll this topic in a way
> that would be more split-up as described there.
>
> I don't care much about the exact end-state there, other than:
>
>  1. Trying to land reftable/ in some shape where we're not constantly
>     re-reviewing the "add upstream library" part of it.

Sure, I can send a separate patch series for adding the library.

-- 
Han-Wen Nienhuys - Google Munich
I work 80%. Don't expect answers from me on Fridays.
--
Google Germany GmbH, Erika-Mann-Strasse 33, 80636 Munich
Registergericht und -nummer: Hamburg, HRB 86891
Sitz der Gesellschaft: Hamburg
Geschäftsführer: Paul Manicle, Halimah DeLaine Prado

Re: What's cooking in git.git (Aug 2021, #09; Sun, 29)

[Derrick Stolee]

On 8/29/2021 9:19 PM, Junio C Hamano wrote:
...
> I've been a bit under the weather during the last week and wanted to
> concentrate on what to push out to 'master', so while I may have
> picked up new topics and replaced existing topics with their new
> versions, I haven't added or updated my summaries on their doneness
> to this document.  Help is appreciated.

I hope you feel better!

I haven't seen [1] get picked up yet, but I think it is really
important that it does, as it fixes a segfault in the sparse
index when certain hashset resizes occur.

[1] https://lore.kernel.org/git/pull.1017.git.1629136135286.gitgitgadget@gmail.com/

Thanks,
-Stolee

Re: What's cooking in git.git (Aug 2021, #09; Sun, 29)

[Junio C Hamano]

Han-Wen Nienhuys <hanwen@google.com> writes:

> On Mon, Aug 30, 2021 at 2:03 PM Ævar Arnfjörð Bjarmason
> <avarab@gmail.com> wrote:
>
>> Han-Wen: It would be really nice to have this re-rolled sooner than
>> later, my and Junio's "fixup" commits at the end are a band-aid, but I
>> already ran into wanting to bisect something between master..seen that
>> was unnecessarily painful due to the series now not compiling without
>> the "fixup" commits at the end.
>
> I am folding in the __FUNCTION__ fix.
>
> However, I thought patches should be sent against the master branch
> and not against some intermediate  version of 'seen' ?

Sure, but in this case I think these errno and reftable patches have
been made to build on top of them, forming a single gigantic series.
Here is what I have for now.

$ git log --first-parent --oneline --decorate master..hn/reftable
447290b6a4 (hn/reftable) SQUASH??? https://github.com/git/git/run...
f76d6f0ad8 reftable: fixup for new base topic 3/3
dd1c4edcf2 reftable: fixup for new base topic 2/3
3b5bcd75c0 reftable: fixup for new base topic 1/3
6f5b8c7d12 t1404: annotate test cases with REFFILES
1de26b03cf t1401,t2011: parameterize HEAD.lock for REFFILES
ed288d74ad t1301: document what needs to be done for reftable
9e4385c42a Add "test-tool dump-reftable" command.
1792a05f21 git-prompt: prepare for reftable refs backend
07aab82357 refs: RFC: Reftable support for git-core
a83701eef8 reftable: add dump utility
385d6c58c5 reftable: implement stack, a mutable database of reftable files.
b9e7eceb13 reftable: implement refname validation
b6e5675982 reftable: add merged table view
38119bdd8d reftable: add a heap-based priority queue for reftable records
d0c6772ff7 reftable: reftable file level tests
c6c539dd32 reftable: read reftable files
f65d21f3b1 reftable: generic interface to tables
897ad67203 reftable: write reftable files
015556832e reftable: a generic binary tree implementation
7c4b155181 reftable: reading/writing blocks
92c1c3179f Provide zlib's uncompress2 from compat/zlib-compat.c
784075c5f6 reftable: (de)serialization for the polymorphic record type.
5440a522c3 reftable: add blocksource, an abstraction for random access reads
cc2a68a200 reftable: utility functions
2efae91445 reftable: add error related functionality
af64fc6ba6 reftable: RFC: add LICENSE
1ade5fa369 init-db: set the_repository->hash_algo early on
f39a30dc25 hash.h: provide constants for the hash IDs
3fde557f7f (ab/refs-errno-cleanup) refs: make errno output explici...
86c9090d90 refs: explicitly return failure_errno from parse_loose_ref_contents
30f5e21f7f branch tests: test for errno propagating on failing read
f3df9ee957 refs: add failure_errno to refs_read_raw_ref() signature
5b12e16bb1 (hn/refs-errno-cleanup) refs: make errno output explicit for read_raw_ref_fn
1ae6ed230a refs/files-backend: stop setting errno from lock_ref_oid_basic
20d422cfd7 refs: remove EINVAL errno output from specification of read_raw_ref_fn
3fa2e91d17 refs file backend: move raceproof_create_file() here
48cdcd9ca0 (ab/refs-files-cleanup) refs/files: remove unused "errno != ENOTDIR" condition
245fbba46d refs/files: remove unused "errno == EISDIR" code
ff7a2e4dbb refs/files: remove unused "oid" in lock_ref_oid_basic()
cc40b5ce13 refs API: remove OID argument to reflog_expire()
ae35e16cd4 reflog expire: don't lock reflogs using previously seen OID
7aa7829f75 refs/files: add a comment about refs_reflog_exists() call
6f45ec88d2 refs: make repo_dwim_log() accept a NULL oid
81bc122589 refs/debug: re-indent argument list for "prepare"
640d9d55c3 refs/files: remove unused "skip" in lock_raw_ref() too
11e984da07 refs/files: remove unused "extras/skip" in lock_ref_oid_basic()
491ad946b2 refs: drop unused "flags" parameter to lock_ref_oid_basic()
212631ed50 refs/files: remove unused REF_DELETING in lock_ref_oid_basic()
881aebffcf refs/packet: add missing BUG() invocations to reflog callbacks

Re: What's cooking in git.git (Aug 2021, #09; Sun, 29)

[Junio C Hamano]

Derrick Stolee <stolee@gmail.com> writes:

> I haven't seen [1] get picked up yet, but I think it is really
> important that it does, as it fixes a segfault in the sparse
> index when certain hashset resizes occur.

Thanks.

Re: What's cooking in git.git (Aug 2021, #09; Sun, 29)

[Junio C Hamano]

Ævar Arnfjörð Bjarmason <avarab@gmail.com> writes:

> Also re your <xmqqbl5ml70u.fsf@gitster.g> I'll switch to quoting
> Message-ID's in that style, and not as
> https://lore.kernel.org/git/<msgid> links. FWIW I was doing the latter
> for the benefit of readers on the sidelines, but will switch.

I can deal with either.  What I meant was that often resend of the
patch outside the context of "What's cooking" would be easier to
find the patches.

>> * ab/commit-graph-usage (2021-08-25) 7 commits
>>  - commit-graph: show "unexpected subcommand" error
>>  - commit-graph: show usage on "commit-graph [write|verify] garbage"
>>  - commit-graph: early exit to "usage" on !argc
>>  - multi-pack-index: refactor "goto usage" pattern
>>  - commit-graph: use parse_options_concat()
>>  - commit-graph: remove redundant handling of -h
>>  - commit-graph: define common usage with a macro
>
> Taylor, SZEDER: That's at
> <cover-v4-0.7-00000000000-20210823T122854Z-avarab@gmail.com>, you
> reviwed the earlier
> <cover-0.6-00000000000-20210720T113707Z-avarab@gmail.com>, what do you
> think about this version?

>> * ab/unbundle-progress (2021-08-27) 5 commits
>
> This has outstanding feedback at
> <cover-v3-0.5-00000000000-20210826T140414Z-avarab@gmail.com> that I need
> to respond to.

OK.

>> * zh/cherry-pick-advice (2021-08-23) 1 commit
>>  - cherry-pick: use better advice message
>>
>>  The advice message that "git cherry-pick" gives when it asks
>>  conflicted replay of a commit to be resolved by the end user has
>>  been updated.
>>
>>  Will merge to 'next'?
>
> I think so, I looked it over as part of browsing advice()-related
> changes, looks good to me.

Thanks.

>> * es/config-based-hooks (2021-08-19) 7 commits
>>  - hook: allow out-of-repo 'git hook' invocations
>>  - hook: include hooks from the config
>>  - hook: allow running non-native hooks
>>  - hook: introduce "git hook list"
>>  - hook: allow parallel hook execution
>>  - hook: run a list of hooks instead
>>  - Merge branch 'ab/config-based-hooks-base' into es/config-based-hooks
>>  (this branch uses ab/config-based-hooks-base.)
>>
>>  Revamp the hooks subsystem to allow multiple of them to trigger
>>  upon the same event and control via the configuration variables.
>>
>>  Will merge to 'next'?
>>  cf. <87v93wflm0.fsf@evledraar.gmail.com>
>
> This needs a re-roll based on my comments in reply to
> <20210819033450.3382652-1-emilyshaffer@google.com>. It's mostly ready as
> far as the end-state is concerneb, but e.g. will break "rebase" (a
> commit in the middle doesn't compile), leaks memory etc.
>
> It needs a re-roll of ab/config-based-hooks-base, which I was waiting on
> some of Emily's feedback to do. Looks like there's no outstanding things
> there, so iwll work on that SOON.

OK, thanks.  Will mark both as expecting reroll on my end.


>> * js/advise-when-skipping-cherry-picked (2021-08-10) 2 commits
>>  - SQUASH???
>>  - sequencer: advise if skipping cherry-picked commit
>>
>>  "git rebase" by default skips changes that are equivalent to
>>  commits that are already in the history the branch is rebased onto;
>>  give messages when this happens to let the users be aware of
>>  skipped commits, and also teach them how to tell "rebase" to keep
>>  duplicated changes.
>
> This LGTM with your proposed obviously-correct squash.
>
> Re comment about ab/retire-advice-config above: I could also just fold
> this into that series if you'd prefer, i.e. it would be one way to deal
> with the only outstanding merge conflict in advice.c between
> master..seen.

Let's see how far we can go with these two as separate topics; I do
not foresee much issues in either topic and can advance them to
'next' soonish.

>> * cb/makefile-apple-clang (2021-08-06) 3 commits
>>  - build: catch clang that identifies itself as "$VENDOR clang"
>>  - build: clang version may not be followed by extra words
>>  - build: update detect-compiler for newer Xcode version
>>
>>  Build update.
>>
>>  Will merge to 'next'.
>
> Makes sense. Any reason other than lack of time that you opted not to go
> for the IMO simpler approach I suggested in
> <87bl6aypke.fsf@evledraar.gmail.com>?

I just didn't see the need for this update to be so big to deserve
such a total rewrite.

>> * ab/lib-subtest (2021-08-05) 11 commits
>>  - test-lib tests: assert 1 exit code, not non-zero
>>  - test-lib tests: refactor common part of check_sub_test_lib_test*()
>>  - test-lib tests: avoid subshell for "test_cmp" for readability
>>  - test-lib tests: assert no copy/pasted mock test code
>>  - test-lib tests: get rid of copy/pasted mock test code
>>  - test-lib tests: don't provide a description for the sub-tests
>>  - test-lib tests: stop using a subshell in write_sub_test_lib_test()
>>  - test-lib tests: split up "write and run" into two functions
>>  - test-lib tests: move "run_sub_test" to a new lib-subtest.sh
>>  - Merge branch 'ps/t0000-output-directory-fix' into ab/lib-subtest
>>  - Merge branch 'jk/t0000-subtests-fix' into ab/lib-subtest
>>
>>  Updates to the tests in t0000 to test the test framework.
>
> I think with my re-roll at
> <cover-v3-0.9-0000000000-20210805T103237Z-avarab@gmail.com> it should be
> OK to declare this good to go sooner than later. I.e. the only trouble I
> can imagine this causing in
> <patch-v3-6.9-bc79b29f3c-20210805T103237Z-avarab@gmail.com> is now easy
> to revert in isolation.

What's queued is v3, I think.  In the list of messages in the thread
on page

  https://lore.kernel.org/git/cover-v3-0.9-0000000000-20210805T103237Z-avarab@gmail.com/

it is still a bit disturbing to see these three versions were sent
without much reaction to the list.

>> * ab/make-tags-cleanup (2021-08-05) 5 commits
>>  - Makefile: normalize clobbering & xargs for tags targets
>>  - Makefile: remove "cscope.out", not "cscope*" in cscope.out target
>>  - Makefile: don't use "FORCE" for tags targets
>>  - Makefile: add QUIET_GEN to "cscope" target
>>  - Makefile: move ".PHONY: cscope" near its target
>>
>>  Build clean-up for "make tags" and friends.
>>
>>  Expecting a reroll.
>>  4/5 may want a minor tweak to the log and the patch text but otherwise looks good.
>
> (Summary copied from <87v93wflm0.fsf@evledraar.gmail.com>)
>
> This entire comment has been in What's Cooking since v3 of the series,
> but v4 has been out since August 4th:
> <cover-v4-0.5-00000000000-20210804T225222Z-avarab@gmail.com>

You're right.  The topic branch has the v4 but the comment in the
What's cooking report is simply stale.

>> * ab/test-tool-cache-cleanup (2021-08-24) 4 commits
>>  - read-cache perf: add a perf test for refresh_index()
>>  - test-tool: migrate read-cache-again to parse_options()
>>  - test-tool: migrate read-cache-perf to parse_options()
>>  - test-tool: split up test-tool read-cache
>>
>>  Test code shuffling.
>
> I had a "take it or leave it" comment at
> <878s0nz5q2.fsf@evledraar.gmail.com>.

Thanks, I'd eject it then.  It should be easy to send in updates
when the tree is otherwise more quiescent.

Re: What's cooking in git.git (Aug 2021, #09; Sun, 29)

[Jonathan Tan]

> * ka/want-ref-in-namespace (2021-08-13) 3 commits
>  - docs: clarify the interaction of transfer.hideRefs and namespaces
>  - upload-pack.c: treat want-ref relative to namespace
>  - t5730: introduce fetch command helper
> 
>  "git upload-pack" which runs on the other side of "git fetch"
>  forgot to take the ref namespaces into account when handling
>  want-ref requests.

Sorry for not being able to look at this until now, but:

Reviewed-by: Jonathan Tan <jonathantanmy@google.com>

Thanks for addressing my comment about the failing tests to be written
in success/failure pairs [1] - I see that that has been done in patch 2.

[1] https://lore.kernel.org/git/20210802210644.3432544-1-jonathantanmy@google.com/

Re: What's cooking in git.git (Aug 2021, #09; Sun, 29)

[SZEDER Gábor]

On Mon, Aug 30, 2021 at 01:00:46PM +0200, Ævar Arnfjörð Bjarmason wrote:
> 
> On Sun, Aug 29 2021, Junio C Hamano wrote:

> > * ab/only-single-progress-at-once (2021-07-23) 8 commits
> >  - progress.c: add & assert a "global_progress" variable
> >  - pack-bitmap-write.c: add a missing stop_progress()
> >  - progress.c: add temporary variable from progress struct
> >  - progress.c: stop eagerly fflush(stderr) when not a terminal
> >  - progress.c: call progress_interval() from progress_test_force_update()
> >  - progress.c: move signal handler functions lower
> >  - progress.c tests: test some invalid usage
> >  - progress.c tests: make start/stop verbs on stdin
> >
> >  Further tweaks on progress API.
> 
> (Summary copied from <87v93wflm0.fsf@evledraar.gmail.com>)
> 
> The changes are rather straightforward, see
> <cover-0.8-0000000000-20210722T125012Z-avarab@gmail.com>; so if anyone's
> interested in reviewing them.
> 
> There's been no reports of anyone running into the new BUG() assertion
> in 8/8 of it: <patch-8.8-1a14176bee-20210722T125012Z-avarab@gmail.com>

Please don't advance this to next yet.  I've found some issues with
it, but not the time to raise them.

Re: What's cooking in git.git (Aug 2021, #09; Sun, 29)

[Junio C Hamano]

Jonathan Tan <jonathantanmy@google.com> writes:

>> * ka/want-ref-in-namespace (2021-08-13) 3 commits
>>  - docs: clarify the interaction of transfer.hideRefs and namespaces
>>  - upload-pack.c: treat want-ref relative to namespace
>>  - t5730: introduce fetch command helper
>> 
>>  "git upload-pack" which runs on the other side of "git fetch"
>>  forgot to take the ref namespaces into account when handling
>>  want-ref requests.
>
> Sorry for not being able to look at this until now, but:
>
> Reviewed-by: Jonathan Tan <jonathantanmy@google.com>
>
> Thanks for addressing my comment about the failing tests to be written
> in success/failure pairs [1] - I see that that has been done in patch 2.
>
> [1] https://lore.kernel.org/git/20210802210644.3432544-1-jonathantanmy@google.com/

Thanks.  Will "rebase -i (reword)" your Reviewed-by in and then
advance the topic to 'next'.