mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Han-Wen Nienhuys <>
To: Junio C Hamano <>
Cc: Han-Wen Nienhuys via GitGitGadget <>,
	git <>, Han-Wen Nienhuys <>
Subject: Re: [PATCH] refs: move REF_LOG_ONLY to refs-internal.h
Date: Wed, 9 Sep 2020 11:35:34 +0200	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

On Wed, Sep 9, 2020 at 12:50 AM Junio C Hamano <> wrote:
> Hmph, I am not necessarily sure about "need to duplicate" [*1*], but
> I do agree with the patch text---the bit should not belong to a
> single "files-backend" backend.
> [Footnote]
> *1* obviously, a better alternative, if possible, would be to let
>     the more generic layer do so without forcing the backends to
>     duplicate.  But even if such a change were possible and we
>     decide to avoid duplication, it does not make sense to have this
>     bit specifically defined for the files-backend and nobody else.

I'm not sure if it is possible. REFS_LOG_ONLY is used in the
split_head_update() which is called from the middle of the
files_transaction_prepare(). In particular, it can happen after a
number of locks have already been taken. If this moves into the
generic layer, the head split happens before the locks are taken,
which could alter behavior.

Han-Wen Nienhuys - Google Munich
I work 80%. Don't expect answers from me on Fridays.

Google Germany GmbH, Erika-Mann-Strasse 33, 80636 Munich

Registergericht und -nummer: Hamburg, HRB 86891

Sitz der Gesellschaft: Hamburg

Geschäftsführer: Paul Manicle, Halimah DeLaine Prado

      reply	other threads:[~2020-09-09  9:36 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-28 15:25 [PATCH] refs: move REF_LOG_ONLY to refs-internal.h Han-Wen Nienhuys via GitGitGadget
2020-09-08 18:17 ` Han-Wen Nienhuys
2020-09-08 21:04   ` Junio C Hamano
2020-09-08 22:50 ` Junio C Hamano
2020-09-09  9:35   ` Han-Wen Nienhuys [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

  List information:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='' \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).