From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS53758 23.128.96.0/24 X-Spam-Status: No, score=-11.7 required=3.0 tests=AWL,BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS,SPF_PASS, USER_IN_DEF_DKIM_WL shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by dcvr.yhbt.net (Postfix) with ESMTP id 98A441F8C6 for ; Mon, 5 Jul 2021 12:36:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231455AbhGEMhJ (ORCPT ); Mon, 5 Jul 2021 08:37:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55684 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230188AbhGEMhI (ORCPT ); Mon, 5 Jul 2021 08:37:08 -0400 Received: from mail-ua1-x930.google.com (mail-ua1-x930.google.com [IPv6:2607:f8b0:4864:20::930]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D65BDC061574 for ; Mon, 5 Jul 2021 05:34:31 -0700 (PDT) Received: by mail-ua1-x930.google.com with SMTP id g21so6930545uaw.3 for ; Mon, 05 Jul 2021 05:34:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=2rXGlNCP8PkCPVIzjsJocFYGC1SuRlPyuTcTkwqRrYo=; b=wD/mNcE3l6sJi8hhiI8Cys+OhBwTKztXAZ2Iufr5jgk7CDVx2Ksph+i0w2AC8SVd35 aZCWB6QsGZgsnwY3W0CDrt9yh62sM6OhIFYVwWCMGDGlhLlYTZA7yX8xxXBwxQR9Ykc0 PvlXfcGE5mVAUjcgAsudHsvlLazBXeRxer5zC6RrOcIAxlDCVvJCyQyserULR/D8RoM9 sNDuI6c6GxjtaXP/Mc4Zh8llrweG4n6QEK/TQIG2x23Ct2OXtarpilnhQVhD7/2VqCBI CKn9KwkA/EIyYvR3rjwf3GnoPED9igoNPg6ZCdPXljEBj5eGhZFpbfVyxz7zDI216ljl S8YA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=2rXGlNCP8PkCPVIzjsJocFYGC1SuRlPyuTcTkwqRrYo=; b=S4VznPBYI6wRSuKZttXxZCZtRPkSTCeYdAflaf1+XWw0QMRSHoiM65K0HV52kqUV31 3HVFzFZaxcbX3JrCd9izAyNT4FAAeuQhWLuaEcxdyWXmz13Erc+Nm5LqW3jHgJySOYUY e2J6skJl/xM8uGjYEX+2VkVhToWVB19L1DKqNz+Fg2X0CojlL9DPwhAekWpQMKyc/TfB T5URQmqFQu6Fbs22ayj0m4TKQIky5MaQFII/TizjKNS1sCUnuR5ue4oeK1zvhECM0P+i RRFOvx6rrgDS6RF3wbayJlof03guYhjPfHaOidKQDQrNSghCkXOdWZFFIHt88oSr4sme KJOg== X-Gm-Message-State: AOAM5313gZB0HxVklClZnt943jW2unWj9exWODSMZXkJ2GEbc+u4pdNh OTpvQj3yKj7uGHnTcXKMmAIrJSjtJD+CIidi2s5SJA== X-Google-Smtp-Source: ABdhPJzJWtFEuyOwmFtBKqFnveV+YeRYCkN3IqMBDCmNT2Wl8PzxM4IjPEgb7s5RrUd9fXTcZplfD80GDe/1yI4Yu+E= X-Received: by 2002:ab0:67cf:: with SMTP id w15mr9891820uar.80.1625488470832; Mon, 05 Jul 2021 05:34:30 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Han-Wen Nienhuys Date: Mon, 5 Jul 2021 14:34:19 +0200 Message-ID: Subject: Re: [PATCH v2 7/8] serve: add support for a "startup" git_config() callback To: =?UTF-8?B?w4Z2YXIgQXJuZmrDtnLDsCBCamFybWFzb24=?= Cc: git@vger.kernel.org, Junio C Hamano , Jonathan Tan , Josh Steadmon , Bruno Albuquerque , Jeff King , Eric Sunshine , Christian Couder Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On Mon, Jun 28, 2021 at 9:19 PM =C3=86var Arnfj=C3=B6r=C3=B0 Bjarmason wrote: > /* Main serve loop for protocol version 2 */ > void serve(struct serve_options *options) side note: this is a very short name for a globally visible symbol. Would be nice if this were something like protocol_v2_serve_loop() . Then one could drop the comment. --=20 Han-Wen Nienhuys - Google Munich I work 80%. Don't expect answers from me on Fridays. -- Google Germany GmbH, Erika-Mann-Strasse 33, 80636 Munich Registergericht und -nummer: Hamburg, HRB 86891 Sitz der Gesellschaft: Hamburg Gesch=C3=A4ftsf=C3=BChrer: Paul Manicle, Halimah DeLaine Prado