From: Han-Wen Nienhuys <hanwen@google.com> To: Junio C Hamano <gitster@pobox.com> Cc: Han-Wen Nienhuys via GitGitGadget <gitgitgadget@gmail.com>, git <git@vger.kernel.org>, Han-Wen Nienhuys <hanwenn@gmail.com> Subject: Re: [PATCH v3 0/3] Remove special casing for PSEUDOREF updates Date: Tue, 11 Aug 2020 12:49:59 +0200 [thread overview] Message-ID: <CAFQ2z_NMH75mewQyvN=NnjYR059ut3jfJLH_GPuiMA0ehyzBrQ@mail.gmail.com> (raw) In-Reply-To: <xmqqk0y6cwst.fsf@gitster.c.googlers.com> On Mon, Aug 10, 2020 at 6:04 PM Junio C Hamano <gitster@pobox.com> wrote: > > Han-Wen Nienhuys <hanwen@google.com> writes: > > > Dealing with FETCH_HEAD generically isn't possible unless we extend > > the API of the ref backend: the generic ref_store instance doesn't > > offer a way to get at the path that corresponds to FETCH_HEAD, so we > > can't handle it in refs_read_raw_ref(). In the current reftable > > series, FETCH_HEAD is dealt with in the backends separately. > > I am not sure what the best way would be, but I do not think any > existing code writes into it using the refs API at all, even though > it may be read only for the first object name using the refs API. > > And I am not sure if we want to extend the write side API so that > the callers can express the full flexibility of that single file. That's not what I am getting at. I am just interested in how to handle FETCH_HEAD in refs_read_raw_ref. > So perhaps the best way forward would be to ensure that anybody who > tries to read from FETCH_HEAD using the ref API reads the first > object name in it from $GIT_DIR/FETCH_HEAD file as we've always done > since the beginning of time, regardless of what ref backend is used, Right, but how do we get at the value of $GIT_DIR given a struct ref_store? We can either push that out to the ref store backend, because each backend knows what $GIT_DIR is, or we can make $GIT_DIR a property of the generic ref_store. I suppose it's cleaner to make the latter API extension. -- Han-Wen Nienhuys - Google Munich I work 80%. Don't expect answers from me on Fridays. -- Google Germany GmbH, Erika-Mann-Strasse 33, 80636 Munich Registergericht und -nummer: Hamburg, HRB 86891 Sitz der Gesellschaft: Hamburg Geschäftsführer: Paul Manicle, Halimah DeLaine Prado
next prev parent reply other threads:[~2020-08-11 10:50 UTC|newest] Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-07-06 17:29 [PATCH 0/2] " Han-Wen Nienhuys via GitGitGadget 2020-07-06 17:29 ` [PATCH 1/2] Modify pseudo refs through ref backend storage Han-Wen Nienhuys via GitGitGadget 2020-07-06 20:26 ` Junio C Hamano 2020-07-07 13:56 ` Han-Wen Nienhuys 2020-07-07 15:20 ` Junio C Hamano 2020-07-07 17:15 ` Han-Wen Nienhuys 2020-07-07 18:14 ` Junio C Hamano 2020-07-06 17:29 ` [PATCH 2/2] Make HEAD a PSEUDOREF rather than PER_WORKTREE Han-Wen Nienhuys via GitGitGadget 2020-07-06 20:30 ` Junio C Hamano 2020-07-07 9:24 ` Han-Wen Nienhuys 2020-07-09 21:11 ` [PATCH v2 0/3] Remove special casing for PSEUDOREF updates Han-Wen Nienhuys via GitGitGadget 2020-07-09 21:11 ` [PATCH v2 1/3] t1400: use git rev-parse for testing PSEUDOREF existence Han-Wen Nienhuys via GitGitGadget 2020-07-09 21:11 ` [PATCH v2 2/3] Modify pseudo refs through ref backend storage Han-Wen Nienhuys via GitGitGadget 2020-07-09 21:11 ` [PATCH v2 3/3] Make HEAD a PSEUDOREF rather than PER_WORKTREE Han-Wen Nienhuys via GitGitGadget 2020-07-10 19:25 ` [PATCH v2 0/3] Remove special casing for PSEUDOREF updates Junio C Hamano 2020-07-16 18:45 ` [PATCH v3 " Han-Wen Nienhuys via GitGitGadget 2020-07-16 18:45 ` [PATCH v3 1/3] t1400: use git rev-parse for testing PSEUDOREF existence Han-Wen Nienhuys via GitGitGadget 2020-07-16 18:45 ` [PATCH v3 2/3] Modify pseudo refs through ref backend storage Han-Wen Nienhuys via GitGitGadget 2020-07-17 8:52 ` Johannes Schindelin 2020-07-27 15:41 ` Han-Wen Nienhuys 2020-07-16 18:45 ` [PATCH v3 3/3] Make HEAD a PSEUDOREF rather than PER_WORKTREE Han-Wen Nienhuys via GitGitGadget 2020-07-16 22:09 ` [PATCH v3 0/3] Remove special casing for PSEUDOREF updates Junio C Hamano 2020-07-27 8:50 ` Han-Wen Nienhuys 2020-07-27 16:20 ` Junio C Hamano 2020-08-03 19:07 ` Han-Wen Nienhuys 2020-08-03 20:07 ` Junio C Hamano 2020-08-05 1:45 ` Junio C Hamano 2020-08-05 10:48 ` Han-Wen Nienhuys 2020-08-05 15:54 ` Junio C Hamano 2020-08-10 14:27 ` Han-Wen Nienhuys 2020-08-10 16:04 ` Junio C Hamano 2020-08-11 10:49 ` Han-Wen Nienhuys [this message] 2020-08-11 18:38 ` Junio C Hamano 2020-08-19 13:19 ` Han-Wen Nienhuys 2020-08-19 15:52 ` Junio C Hamano 2020-07-27 16:25 ` [PATCH v4 " Han-Wen Nienhuys via GitGitGadget 2020-07-27 16:25 ` [PATCH v4 1/3] t1400: use git rev-parse for testing PSEUDOREF existence Han-Wen Nienhuys via GitGitGadget 2020-07-27 16:25 ` [PATCH v4 2/3] Modify pseudo refs through ref backend storage Han-Wen Nienhuys via GitGitGadget 2020-07-27 16:25 ` [PATCH v4 3/3] Make HEAD a PSEUDOREF rather than PER_WORKTREE Han-Wen Nienhuys via GitGitGadget
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style List information: http://vger.kernel.org/majordomo-info.html * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='CAFQ2z_NMH75mewQyvN=NnjYR059ut3jfJLH_GPuiMA0ehyzBrQ@mail.gmail.com' \ --to=hanwen@google.com \ --cc=git@vger.kernel.org \ --cc=gitgitgadget@gmail.com \ --cc=gitster@pobox.com \ --cc=hanwenn@gmail.com \ --subject='Re: [PATCH v3 0/3] Remove special casing for PSEUDOREF updates' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Code repositories for project(s) associated with this inbox: https://80x24.org/mirrors/git.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).