From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS53758 23.128.96.0/24 X-Spam-Status: No, score=-11.7 required=3.0 tests=AWL,BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS,SPF_PASS, USER_IN_DEF_DKIM_WL shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by dcvr.yhbt.net (Postfix) with ESMTP id B4BC41F8C6 for ; Wed, 7 Jul 2021 08:20:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230112AbhGGIWy (ORCPT ); Wed, 7 Jul 2021 04:22:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42124 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229975AbhGGIWy (ORCPT ); Wed, 7 Jul 2021 04:22:54 -0400 Received: from mail-vs1-xe30.google.com (mail-vs1-xe30.google.com [IPv6:2607:f8b0:4864:20::e30]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 84145C061574 for ; Wed, 7 Jul 2021 01:20:13 -0700 (PDT) Received: by mail-vs1-xe30.google.com with SMTP id u11so1136788vsl.7 for ; Wed, 07 Jul 2021 01:20:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=i0UZPa2r/JUI/Qf9k18jEuxegDLKTw/rxBdgJ66CZCI=; b=Ak5WH8fTmAG7iWS8uc7Y0pBEs2wqzEmidSv13WIwDgY4BdLekfpqN9IHvyVsBZD2Os xrB8XA6eMj2+nW+XHvM45A8LWQ77+H+I4t0Na1AjpBeaMdhlPSeGOQrcsYy/jlgY0z9w xxgnTz6P5GbFfOjPIORENfDJP5EfvHPwf94LlRnDNjnPsZyuyru0BR/Wx5yMrNkqNMZZ E1xbbZg7z7WP5Ds4f73h/mYv7IIimKJFmJJZZtbFQzu6kUuhgvbtAOUv6eXWZyphewcy ieI4S7EMkCaVjz/U5O/LmjbNoEwSZL9zu/TWqBBFvF8wSzzAqeIdAjwkcfAERxpLnBgm JkBA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=i0UZPa2r/JUI/Qf9k18jEuxegDLKTw/rxBdgJ66CZCI=; b=ElLG0Ip7y3hcraxNInJVGIaLVmDS9sh+VqixNtDXxV8XDKhAv48RfNtDfNVumL6BYy qmZqEc2g786C7pK+a9aFeRLGLM2fd3eZgIeJ9dnWhD+EOipKbcB0e9A4fdPn+krKad7b UdoOfKnl7IgtzCkxentfQi8LxevCJEy/ceLypVKTALcWpi1j3MC2rJdmqGO1i/36hV2c jIgqsF+z4aF2aFdTaW+3az3eZbL8er9Ny/Dzn8E9ElFnpQLxLyoJLBSf8REyZrBqYHpd Gm+hMGxM2r+Sdid/aNf/X1WyElR2rmaKDftM5Wn86WJ+riXyH8SyJLEJvHnhJpwSFLVf VO9A== X-Gm-Message-State: AOAM532iTWc5du5qRiddhHrR8ceFn5D9TBkozF5AceAeiNh5w+bcLV0+ 34MQPRF8aAoKlp+5h6l39A13zIOWIvUd2zpAygloyA== X-Google-Smtp-Source: ABdhPJxT+PY8d56d65KQxcLFGsuZFNiIBBsvzWVkRbKxDSqw1Q2y8+7PxuXnnVqduSqjS8UuBZ/Vzx3OrsLfcYV+mSY= X-Received: by 2002:a67:6992:: with SMTP id e140mr20175114vsc.2.1625646012313; Wed, 07 Jul 2021 01:20:12 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Han-Wen Nienhuys Date: Wed, 7 Jul 2021 10:20:00 +0200 Message-ID: Subject: Re: [PATCH v4 5/6] refs: explicitly return failure_errno from parse_loose_ref_contents To: Junio C Hamano Cc: Han-Wen Nienhuys via GitGitGadget , git@vger.kernel.org, Jonathan Tan , =?UTF-8?B?w4Z2YXIgQXJuZmrDtnLDsCBCamFybWFzb24=?= , Han-Wen Nienhuys Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On Tue, Jul 6, 2021 at 9:37 PM Junio C Hamano wrote: > > "Han-Wen Nienhuys via GitGitGadget" writes: > > > From: Han-Wen Nienhuys > > > > The EINVAL error from parse_loose_ref_contents is used in files-backend > > to create a custom error message. > > > > Signed-off-by: Han-Wen Nienhuys > > Reviewed-By: =C3=86var Arnfj=C3=B6r=C3=B0 Bjarmason > > I think a -By in the trailer is spelled with lowercase, i.e. "Reviewed-by= ". .. All done. I also addressed your other fixup. --=20 Han-Wen Nienhuys - Google Munich I work 80%. Don't expect answers from me on Fridays. -- Google Germany GmbH, Erika-Mann-Strasse 33, 80636 Munich Registergericht und -nummer: Hamburg, HRB 86891 Sitz der Gesellschaft: Hamburg Gesch=C3=A4ftsf=C3=BChrer: Paul Manicle, Halimah DeLaine Prado