From: Chris Packham <judge.packham@gmail.com>
To: Junio C Hamano <gitster@pobox.com>, GIT <git@vger.kernel.org>
Subject: Re: [RFC PATCHv2 1/2] am: add gitk patch format
Date: Fri, 5 Sep 2014 13:23:17 +1200 [thread overview]
Message-ID: <CAFOYHZDfpZPvuE_BZQHajc65fZNKoyqvFf+UZyf0LyLwrooqzA@mail.gmail.com> (raw)
In-Reply-To: <CAPc5daWip1dQ5Or6hzmdjoBUStusvs-jK0ODNuzAotNfM5BLbQ@mail.gmail.com>
(added back git ml because I accidentally dropped the Cc when replying
to Junio).
On Fri, Sep 5, 2014 at 10:57 AM, Junio C Hamano <gitster@pobox.com> wrote:
>>> I doubt that a patchset that does
>>> not update mailinfo and mailsplit to extract information and to undo
>>> the indentation could be a right solution.
>>
>> I've read this sentence a couple of times and I can't understand it.
>
> "am" uses mailsplit on the input file to separate it into one or more
> input files, each of which represents a single change. On each of
> them, it uses mailinfo to extract the meta information (e.g.
> authorship), log message and the patch into separate files.
Except when --patch-format=hg|stgit is specified (or detected). In
these cases mailsplit is avoided.
> It does not make any sense for a support for a new input format that
> does not teach mailinfo how to handle that format. Transforming it
> into a pseudo e-mail format is not the way to go. If that approach were
> acceptable, that format conversion filter can be run completely outside
> "am" in the first place, no?
So teaching git mailinfo to do s/^ // (either when asked to or
using some heuristic) would be a better approach? I also think we
should accept "Author:" as an acceptable fallback if "From:" is not
present.
next prev parent reply other threads:[~2014-09-05 1:23 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-03 9:35 [RFC PATCH 0/1] am: bug report and new patch format support Chris Packham
2014-09-03 9:35 ` [RFC PATCH 1/1] am: add gitk patch format Chris Packham
2014-09-03 9:59 ` Chris Packham
2014-09-03 10:18 ` [RFC PATCH 0/1] am: bug report and new patch format support Chris Packham
2014-09-03 22:21 ` [RFC PATCHv2 0/2] am: bug fix " Chris Packham
2014-09-03 22:21 ` [RFC PATCHv2 1/2] am: add gitk patch format Chris Packham
2014-09-03 23:19 ` Junio C Hamano
2014-09-04 0:46 ` Chris Packham
2014-09-04 17:21 ` Junio C Hamano
2014-09-04 22:47 ` Chris Packham
[not found] ` <CAPc5daWip1dQ5Or6hzmdjoBUStusvs-jK0ODNuzAotNfM5BLbQ@mail.gmail.com>
2014-09-05 1:23 ` Chris Packham [this message]
2014-09-05 18:29 ` Junio C Hamano
2014-09-05 21:54 ` Chris Packham
2014-09-03 22:21 ` [RFC PATCHv2 2/2] am: avoid re-directing stdin twice Chris Packham
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFOYHZDfpZPvuE_BZQHajc65fZNKoyqvFf+UZyf0LyLwrooqzA@mail.gmail.com \
--to=judge.packham@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).