From: Max Rothman <firstname.lastname@example.org> To: Stefan Beller <email@example.com> Cc: "firstname.lastname@example.org" <email@example.com> Subject: Re: No log --no-decorate completion? Date: Tue, 7 Nov 2017 15:31:51 -0500 [thread overview] Message-ID: <CAFA_24L5nTUhO=PbMB9SdnCB1Lj+5rmOHmMJwkuLGWgy-ooxBA@mail.gmail.com> (raw) In-Reply-To: <CAGZ79kbWEe=TyqPFSc+D8HCRh3cOkGbkqFKZbpkdisjvkfiaFg@mail.gmail.com> Thanks for the feedback! >> * Add bash completion for the missing --no-* options on git log >> * Add bash completion for --textconv and --indent-heuristic families to >> git diff and all commands that use diff's options >> * Add bash completion for --no-abbrev-commit, --expand-tabs, and >> --no-expand-tabs to git show > > This describes what happens in this patch, but not why, which helps > future readers of commit message more than the "what". How about: > Teach git-log tab completion about the --no-* options for ease of use > at the command line. > > Similarly, teach git-show tab completion about the --no-abbrev-commit, > --expand-tabs, and --no-expand-tabs options. > > Also, teach git-diff (and all commands that use its options) tab > completion about the --textconv and --indent-heuristic families of > options. --indent-heuristic is no longer experimental, so there's no > reason it should be left out of tab completion any more, and textconv > seems to have simply been missed. > At the end of a commit message, the Git project requires a sign off. > (See section (5) in Documentation/SubmittingPatches; > tl;dr: add Signed-off-by: NAME <EMAIL> if you can agree to > https://developercertificate.org/) So the sign-off should include my name and email? I thought it was supposed to be the person who approved the patch, but I must've gotten confused. > The patch looks good, but doesn't apply because the email contains > white spaces instead of tabs. Maybe try https://submitgit.herokuapp.com/ > (or fix/change your email client to send a patch; the gmail web interface > doesn't work. I personally got 'git send-email' up and running; > The Documentation/SubmittingPatches has a section on email clients, too) Yeah, I was using the gmail interface. I'll give the heroku app a go. It has an option for sending a message in reply to another, and I assume I should send it in reply to this thread. Do you know how to tell what the appropriate ID to use is? Looking through the raw email, I see several, so it's not obvious to me which to use. Thanks, Max
next prev parent reply other threads:[~2017-11-07 20:32 UTC|newest] Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-10-11 14:47 Max Rothman 2017-10-11 18:09 ` Stefan Beller 2017-10-12 17:41 ` Max Rothman 2017-10-24 15:32 ` Max Rothman [not found] ` <CAFA_24K99LkeJBKV7+a-m-m9PUZik49cOd40+cEn-6zCvGmMsQ@mail.gmail.com> 2017-10-24 15:32 ` Stefan Beller 2017-11-02 20:25 ` Max Rothman 2017-11-02 21:19 ` Stefan Beller 2017-11-07 20:31 ` Max Rothman [this message] 2017-11-07 20:48 ` Stefan Beller 2017-11-07 21:22 ` [PATCH] completion: add missing completions for log, diff, show Max Rothman 2017-11-08 2:33 ` Junio C Hamano 2017-11-08 3:30 ` Max Rothman 2017-11-08 4:06 ` Junio C Hamano 2019-07-02 1:56 ` Max Rothman 2019-08-02 0:54 ` Max Rothman 2019-09-11 18:15 ` Max Rothman 2019-09-12 8:54 ` Johannes Schindelin 2019-09-12 19:47 ` Junio C Hamano [not found] ` <CAFA_24L5S1_AS1OzPYf50iXwEupi0Bus827-NWoUpka-avNo_w@mail.gmail.com> 2019-09-13 21:03 ` Johannes Schindelin
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style List information: http://vger.kernel.org/majordomo-info.html * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='CAFA_24L5nTUhO=PbMB9SdnCB1Lj+5rmOHmMJwkuLGWgy-ooxBA@mail.gmail.com' \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --subject='Re: No log --no-decorate completion?' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Code repositories for project(s) associated with this inbox: https://80x24.org/mirrors/git.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).