git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Matthew Booth <mbooth@redhat.com>
To: git@vger.kernel.org
Subject: [BUG] git log -L ... -s does not suppress diff output
Date: Mon, 25 Feb 2019 17:03:50 +0000	[thread overview]
Message-ID: <CAEkQehdFu5zM4AY3ihN0pn1aCNEomY0WV07pryfAB45JN-tDDA@mail.gmail.com> (raw)

Example output:

=========
$ git --version
git version 2.20.1

$ git log -L 2957,3107:nova/compute/manager.py -s
commit 35ce77835bb271bad3c18eaf22146edac3a42ea0
<snip>

diff --git a/nova/compute/manager.py b/nova/compute/manager.py
--- a/nova/compute/manager.py
+++ b/nova/compute/manager.py
@@ -2937,152 +2921,151 @@
     def rebuild_instance(self, context, instance, orig_image_ref, image_ref,
                          injected_files, new_pass, orig_sys_metadata,
<snip>
=========

git log docs suggest it should not do this:

       -s, --no-patch
           Suppress diff output. Useful for commands like git show
that show the patch by default, or to cancel
           the effect of --patch.

Couldn't find anything in a search of the archives of this mailing
list, although that's obviously far from conclusive. Seems to be
longstanding, as it was mentioned on StackOverflow back in 2015:

https://stackoverflow.com/questions/31709785/git-line-log-git-l-suppress-diff

Matt
-- 
Matthew Booth
Red Hat OpenStack Engineer, Compute DFG

Phone: +442070094448 (UK)

             reply	other threads:[~2019-02-25 17:04 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-25 17:03 Matthew Booth [this message]
2019-02-25 17:18 ` [BUG] git log -L ... -s does not suppress diff output Jeff King
2019-02-25 17:32   ` [PATCH] line-log: suppress diff output with "-s" Jeff King
2019-02-25 17:59     ` SZEDER Gábor
2019-02-25 18:55       ` Jeff King
2019-02-25 18:46   ` [BUG] git log -L ... -s does not suppress diff output Randall S. Becker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAEkQehdFu5zM4AY3ihN0pn1aCNEomY0WV07pryfAB45JN-tDDA@mail.gmail.com \
    --to=mbooth@redhat.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).