From: "Benoît Person" <benoit.person@ensimag.fr> To: Matthieu Moy <Matthieu.Moy@grenoble-inp.fr> Cc: Junio C Hamano <gitster@pobox.com>, Git Mailing List <git@vger.kernel.org>, Celestin Matte <celestin.matte@ensimag.fr> Subject: Re: [PATCH v6 2/5] git-remote-mediawiki: new git bin-wrapper for developement Date: Sat, 29 Jun 2013 13:09:22 +0200 [thread overview] Message-ID: <CAETqRCiJZchP6ydr1F2wPogphyUQuDFxusq+Uczcxk1kmpoD=Q@mail.gmail.com> (raw) In-Reply-To: <vpqhagj9oux.fsf@anie.imag.fr> > GIT_ROOT_DIR=../../.. > GIT_EXEC_PATH=$(cd "$(dirname "$0")" && cd ${GIT_ROOT_DIR} && pwd) > GIT_MEDIAWIKI="$GIT_EXEC_PATH"/contrib/mw-to-git > PATH="$GIT_MEDIAWIKI"/contrib/mw-to-git:"$PATH" > GPLEXTRA="$GIT_MEDIAWIKI"/contrib/mw-to-git > > exec "${GIT_EXEC_PATH}/bin-wrappers/git" "$@" Should I do that in a reroll ? >>> Two possible alternatives: >>> >>> - Is there a reason you would not want to "install" whatever Perl >>> modules you want to "use" via GITPERLLIB mechanism to >>> ../../perl/blib/lib? >> If we are making modifications to Git/Mediawiki.pm or even git-mw.perl >> / git-remote-mediawiki.perl, installing them without proper testing >> beforehand seems wrong. > > That's not "installing" (i.e. not "make install"), just a copy within > the source tree. Same as what's done in Git's toplevel. Oh right, sorry, read it too quickly :/ Well, I still find it weird to copy untested files out of contrib/mw-to-git/ though. Another idea crossed my mind: for now the test suite creates a symlink of git-remote-mediawiki in the toplevel if it's not installed. It would be better to use the bin-wrapper in the testsuite I think ? (plus, with the current solution, it may have problems finding the latest Git::Mediawiki.pm)
next prev parent reply other threads:[~2013-06-29 11:09 UTC|newest] Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top 2013-06-27 17:37 [PATCH v6 0/5] git-remote-mediawiki: new tool to preview local changes without pushing benoit.person 2013-06-27 17:37 ` [PATCH v6 1/5] git-remote-mediawiki: Introduction of Git::Mediawiki.pm benoit.person 2013-06-27 17:37 ` [PATCH v6 2/5] git-remote-mediawiki: new git bin-wrapper for developement benoit.person 2013-06-27 17:57 ` Junio C Hamano 2013-06-27 18:47 ` Matthieu Moy 2013-06-27 18:53 ` Benoît Person 2013-06-27 22:21 ` Matthieu Moy 2013-06-29 11:09 ` Benoît Person [this message] 2013-07-01 7:46 ` Matthieu Moy 2013-06-27 17:37 ` [PATCH v6 3/5] git-remote-mediawiki: factoring code between git-remote-mediawiki and Git::Mediawiki benoit.person 2013-06-27 17:37 ` [PATCH v6 4/5] git-remote-mediawiki: Adding git-mw command benoit.person 2013-06-27 17:37 ` [PATCH v6 5/5] git-remote-mediawiki: Add preview subcommand into git mw benoit.person
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style List information: http://vger.kernel.org/majordomo-info.html * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='CAETqRCiJZchP6ydr1F2wPogphyUQuDFxusq+Uczcxk1kmpoD=Q@mail.gmail.com' \ --to=benoit.person@ensimag.fr \ --cc=Matthieu.Moy@grenoble-inp.fr \ --cc=celestin.matte@ensimag.fr \ --cc=git@vger.kernel.org \ --cc=gitster@pobox.com \ --subject='Re: [PATCH v6 2/5] git-remote-mediawiki: new git bin-wrapper for developement' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Code repositories for project(s) associated with this inbox: https://80x24.org/mirrors/git.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).