git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: "Benoît Person" <benoit.person@ensimag.fr>
To: Matthieu Moy <Matthieu.Moy@grenoble-inp.fr>
Cc: Git Mailing List <git@vger.kernel.org>,
	Celestin Matte <celestin.matte@ensimag.fr>,
	Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH v8 3/7] git-remote-mediawiki: New git bin-wrapper for developement
Date: Sat, 6 Jul 2013 11:45:46 +0200	[thread overview]
Message-ID: <CAETqRCh0_gc_MqN5eXLn_guCELYKgfHdN3986d9WPubxUFeLqQ@mail.gmail.com> (raw)
In-Reply-To: <vpqfvvtzdw4.fsf@anie.imag.fr>

On 5 July 2013 09:04, Matthieu Moy <Matthieu.Moy@grenoble-inp.fr> wrote:
> benoit.person@ensimag.fr writes:
>
>> --- a/contrib/mw-to-git/Makefile
>> +++ b/contrib/mw-to-git/Makefile
>> @@ -2,6 +2,12 @@
>>  # Copyright (C) 2013
>>  #     Matthieu Moy <Matthieu.Moy@imag.fr>
>>  #
>> +# To build and test:
>> +#
>> +#   make:
>> +#     bin-wrapper/git mw preview Some_page.mw
>> +#     bin-wrapper/git clone mediawiki::http://example.com/wiki/
>> +#
>
> The colon after "make" and the indentation look weird. Shouldn't this be
>
> +# To build and test:
> +#
> +#   make
> +#   bin-wrapper/git mw preview Some_page.mw
> +#   bin-wrapper/git clone mediawiki::http://example.com/wiki/
> +#
>
> ?

oops, yes definitely.

  reply	other threads:[~2013-07-06  9:45 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-04 20:38 [PATCH v8 0/7] git-remote-mediawiki: new tool to preview local changes without pushing benoit.person
2013-07-04 20:38 ` [PATCH v8 1/7] git-remote-mediawiki: Introduction of Git::Mediawiki.pm benoit.person
2013-07-04 20:38 ` [PATCH v8 2/7] wrap-for-bin: Make bin-wrappers chainable benoit.person
2013-07-04 20:38 ` [PATCH v8 3/7] git-remote-mediawiki: New git bin-wrapper for developement benoit.person
2013-07-05  7:04   ` Matthieu Moy
2013-07-06  9:45     ` Benoît Person [this message]
2013-07-08 13:30       ` [PATCH] fixup! " Matthieu Moy
2013-07-08 15:56         ` Junio C Hamano
2013-07-04 20:38 ` [PATCH v8 4/7] git-remote-mediawiki: Update tests to run with the new bin-wrapper benoit.person
2013-07-04 20:38 ` [PATCH v8 5/7] git-remote-mediawiki: Factoring code between git-remote-mediawiki and Git::Mediawiki benoit.person
2013-07-04 20:38 ` [PATCH v8 6/7] git-remote-mediawiki: Adding git-mw command benoit.person
2013-07-04 20:39 ` [PATCH v8 7/7] git-remote-mediawiki: Add preview subcommand into git mw benoit.person

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAETqRCh0_gc_MqN5eXLn_guCELYKgfHdN3986d9WPubxUFeLqQ@mail.gmail.com \
    --to=benoit.person@ensimag.fr \
    --cc=Matthieu.Moy@grenoble-inp.fr \
    --cc=celestin.matte@ensimag.fr \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).