From: Martin von Zweigbergk <martinvonz@google.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH v2] docs: clarify that refs/notes/ do not keep the attached objects alive
Date: Wed, 10 Feb 2021 21:36:33 -1000 [thread overview]
Message-ID: <CAESOdVB7i9UJpsB91sedGKPiCxkc0XgC+T5SLP4qF==kaqhJtg@mail.gmail.com> (raw)
In-Reply-To: <xmqq7dnfys5l.fsf@gitster.c.googlers.com>
On Wed, Feb 10, 2021 at 9:34 PM Junio C Hamano <gitster@pobox.com> wrote:
>
> Martin von Zweigbergk <martinvonz@google.com> writes:
>
> > `git help gc` contains this snippet:
> >
> > "[...] it will keep [..] objects referenced by the index,
> > remote-tracking branches, notes saved by git notes under refs/notes/"
> >
> > I had interpreted that as saying that the objects that notes were
> > attached to are kept, but that is not the case. Let's clarify the
> > documentation by moving out the part about git notes to a separate
> > sentence.
> >
> > Signed-off-by: Martin von Zweigbergk <martinvonz@google.com>
> > ---
>
> This looks the same as the one in
> <e7fde2369495f32c7aa88c7b6b74ebee1a1bed24.1613000292.git.martinvonz@google.com>
>
> which was v1, except that this one has your sign-off. Sent a wrong
> version?
Yes, sorry. I forgot the `-a` to `git commit --amend` (have been using
Mercurial for the last 5 years now). I'll send a v3.
next prev parent reply other threads:[~2021-02-11 7:38 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-11 0:00 [PATCH] docs: clarify that refs/notes/ do not keep the attached objects alive Martin von Zweigbergk
2021-02-11 0:35 ` Junio C Hamano
2021-02-11 7:14 ` Martin von Zweigbergk
2021-02-11 7:30 ` Junio C Hamano
2021-02-11 7:38 ` Martin von Zweigbergk
2021-02-11 7:18 ` [PATCH v2] " Martin von Zweigbergk
2021-02-11 7:34 ` Junio C Hamano
2021-02-11 7:36 ` Martin von Zweigbergk [this message]
2021-02-11 7:39 ` [PATCH v3] " Martin von Zweigbergk
2021-02-11 7:43 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAESOdVB7i9UJpsB91sedGKPiCxkc0XgC+T5SLP4qF==kaqhJtg@mail.gmail.com' \
--to=martinvonz@google.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).