From: Yasushi SHOJI <yasushi.shoji@gmail.com>
To: Christian Couder <christian.couder@gmail.com>
Cc: "Martin Ågren" <martin.agren@gmail.com>,
"Ævar Arnfjörð Bjarmason" <avarab@gmail.com>,
"Git Mailing List" <git@vger.kernel.org>,
"Christian Couder" <chriscool@tuxfamily.org>,
"Junio C Hamano" <gitster@pobox.com>
Subject: Re: [BUG] v2.16.0-rc0 seg faults when git bisect skip
Date: Tue, 9 Jan 2018 20:09:05 +0900 [thread overview]
Message-ID: <CAELBRW+kvvUVKt2L9xRDtFvD2Vi9qG=3ZnNR2OVmdq6F64RMBg@mail.gmail.com> (raw)
In-Reply-To: <CAP8UFD1rO1cFCfZg53gG71qfbapkn3gVvja87YFiMBZTkOqNuw@mail.gmail.com>
Hi,
On Tue, Jan 9, 2018 at 12:09 AM, Christian Couder
<christian.couder@gmail.com> wrote:
> ... "i == cnt" is always false above. I think it should be "i == cnt - 1".
uga. Thanks. That's stupid of me.
> And with your code one can wonder why the cleanup is part of the loop.
OK. I have nothing to offer, then. Thank you for taking care of this!
>> I also found a bug in show_list(). I'm attaching a patch as well.
>
> Could you send it inline as explained in Documentation/SubmittingPatches?
Done that.
Thanks,
--
yashi
next prev parent reply other threads:[~2018-01-09 11:09 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-03 12:36 [BUG] v2.16.0-rc0 seg faults when git bisect skip Yasushi SHOJI
2018-01-03 14:21 ` Ævar Arnfjörð Bjarmason
2018-01-03 18:26 ` Martin Ågren
2018-01-03 18:48 ` [PATCH] bisect: fix a regression causing a segfault Ævar Arnfjörð Bjarmason
2018-01-05 2:45 ` [BUG] v2.16.0-rc0 seg faults when git bisect skip Yasushi SHOJI
2018-01-05 5:28 ` Yasushi SHOJI
2018-01-06 8:21 ` Martin Ågren
2018-01-06 14:27 ` Yasushi SHOJI
2018-01-06 15:02 ` Martin Ågren
2018-01-06 15:05 ` Christian Couder
2018-01-08 14:45 ` Yasushi SHOJI
2018-01-08 15:09 ` Christian Couder
2018-01-09 11:09 ` Yasushi SHOJI [this message]
2018-01-05 22:20 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAELBRW+kvvUVKt2L9xRDtFvD2Vi9qG=3ZnNR2OVmdq6F64RMBg@mail.gmail.com' \
--to=yasushi.shoji@gmail.com \
--cc=avarab@gmail.com \
--cc=chriscool@tuxfamily.org \
--cc=christian.couder@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=martin.agren@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).