From: "Daniel Ferreira (theiostream)" <bnmvco@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: Git Mailing List <git@vger.kernel.org>, Duy Nguyen <pclouds@gmail.com>
Subject: Re: What's cooking in git.git (May 2017, #08; Mon, 29)
Date: Wed, 31 May 2017 00:18:29 -0300 [thread overview]
Message-ID: <CAEA2_RJWnjiqinoAhd9aEM=zx9K4MxYpsoDcgoVwf0RnChsnUQ@mail.gmail.com> (raw)
In-Reply-To: <xmqq1sr889lb.fsf@gitster.mtv.corp.google.com>
On Mon, May 29, 2017 at 3:23 AM, Junio C Hamano <gitster@pobox.com> wrote:
> * df/dir-iter-remove-subtree (2017-05-29) 5 commits
> . remove_subtree(): reimplement using iterators
> . dir_iterator: rewrite state machine model
> . dir_iterator: refactor dir_iterator_advance
> . remove_subtree(): test removing nested directories
> . dir_iterator: add tests for dir_iterator API
>
> Update the dir-iterator API and use it to reimplement
> remove_subtree().
>
> GSoC microproject.
> Ejected as it conflicts with other topics in flight in a
> non-trivial way.
I see this conflicts with Duy's
fa7e9c0c24637d6b041a2919a33956b68bfd0869 ("files-backend: make reflog
iterator go through per-worktree reflog", 2017-04-19) because his
commit creates a new dir_iterator whose NULL value means something
semantically. This would be perfectly OK with the old dir_iterator API
(where NULL was not a possible return value from dir_iterator_begin()
and could be "reserved" for this case), but will most probably
generate issues with the new API, where NULL can *also* mean we failed
to lstat() the directory we're trying to iterate over[1].
I'll try to address this issue playing with pu, but I'm just wondering
what would be the best way to send this upcoming not-based-on-master
patch to the list. Should I just send it normally and signal it
originates from pu rather than master?
Thanks,
[1]: https://public-inbox.org/git/1493226219-33423-1-git-send-email-bnmvco@gmail.com/T/#m68286d783b5dfbad6921fbf012f685a629645c61
next prev parent reply other threads:[~2017-05-31 3:19 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-29 6:23 What's cooking in git.git (May 2017, #08; Mon, 29) Junio C Hamano
2017-05-29 7:51 ` Samuel Lijin
2017-05-30 0:35 ` Junio C Hamano
2017-05-30 17:42 ` Stefan Beller
2017-05-30 23:07 ` Junio C Hamano
2017-05-31 3:18 ` Daniel Ferreira (theiostream) [this message]
2017-05-31 5:58 ` Stefan Beller
2017-05-31 18:59 ` Ævar Arnfjörð Bjarmason
2017-06-01 0:48 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAEA2_RJWnjiqinoAhd9aEM=zx9K4MxYpsoDcgoVwf0RnChsnUQ@mail.gmail.com' \
--to=bnmvco@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=pclouds@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).