Re: [PATCH 6/8] gpg-interface: find the last gpg signature line

[Ben Toews <mastahyeti@gmail.com>]

On Tue, Apr 10, 2018 at 3:44 AM, Junio C Hamano <gitster@pobox.com> wrote:
> Ben Toews <mastahyeti@gmail.com> writes:
>
>> diff --git a/t/t7004-tag.sh b/t/t7004-tag.sh
>> index ee093b393d..e3f1e014aa 100755
>> --- a/t/t7004-tag.sh
>> +++ b/t/t7004-tag.sh
>> @@ -1059,6 +1059,17 @@ test_expect_success GPG \
>>       git tag -v blanknonlfile-signed-tag
>>  '
>>
>> +test_expect_success GPG 'signed tag with embedded PGP message' '
>> +     cat >msg <<-\EOF &&
>> +     -----BEGIN PGP MESSAGE-----
>> +
>> +     this is not a real PGP message
>> +     -----END PGP MESSAGE-----
>> +     EOF
>> +     git tag -s -F msg confusing-pgp-message &&
>> +     git tag -v confusing-pgp-message
>> +'
>> +
>>  # messages with commented lines for signed tags:
>>
>>  cat >sigcommentsfile <<EOF
>
> Hmmmm, what vintage of our codebase is this patch based on?  Did I
> miss a patch that removes these lines
>
>
>     printf '      ' >sigblanknonlfile
>     get_tag_header blanknonlfile-signed-tag $commit commit $time >expect
>     echo '-----BEGIN PGP SIGNATURE-----' >>expect
>     test_expect_success GPG \
>             'creating a signed tag with spaces and no newline should succeed' '
>             git tag -s -F sigblanknonlfile blanknonlfile-signed-tag &&
>             get_tag_msg blanknonlfile-signed-tag >actual &&
>             test_cmp expect actual &&
>             git tag -v signed-tag
>     '
>
> which appear between the pre- and post- context of the lines you are
> inserting?  They date back to 2007-2009.
>

That test was fixed a week ago:
https://github.com/git/git/commit/a99d903f21d102a5768f19157085a9733aeb68dd



-- 
-Ben Toews