From: Luke Diamand <luke@diamand.org>
To: Merland Romain <merlorom@yahoo.fr>
Cc: "Git Users" <git@vger.kernel.org>,
"SZEDER Gábor" <szeder.dev@gmail.com>,
"Miguel Torroja" <miguel.torroja@gmail.com>,
"Vinicius Kursancew" <viniciusalexandre@gmail.com>,
"Lars Schneider" <larsxschneider@gmail.com>
Subject: Re: [PATCHv1 1/1] git-p4: better error reporting when p4 fails
Date: Tue, 5 Jun 2018 11:59:41 +0100 [thread overview]
Message-ID: <CAE5ih7_01ZixwnFP2kGN9Y5M26MyNai82USUr2UfunL3Ubztdg@mail.gmail.com> (raw)
In-Reply-To: <777690205.383623.1528195798488@mail.yahoo.com>
On 5 June 2018 at 11:49, Merland Romain <merlorom@yahoo.fr> wrote:
>
>> @@ -91,6 +93,13 @@ def p4_build_cmd(cmd):
>> real_cmd = ' '.join(real_cmd) + ' ' + cmd
>> else:
>> real_cmd += cmd
>> +
>> + # now check that we can actually talk to the server
>> + global p4_access_checked
>> + if not p4_access_checked:
>> + p4_access_checked = True
>> + p4_check_access()
>> +
>
> Just switch the 2 lines 'p4_access_checked = True' and 'p4_check_access()'
> It seems to me more logical
Like this:
+ p4_check_access()
+ p4_access_checked = True
You need to set p4_access_checked first so that it doesn't go and try
to check the p4 access before running "p4 login -s", which would then
get stuck forever.
>
> Romain
next prev parent reply other threads:[~2018-06-05 10:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-05 8:55 [PATCHv1 0/1] git-p4: better error reporting Luke Diamand
2018-06-05 8:55 ` [PATCHv1 1/1] git-p4: better error reporting when p4 fails Luke Diamand
[not found] ` <777690205.383623.1528195798488@mail.yahoo.com>
2018-06-05 10:59 ` Luke Diamand [this message]
2018-06-05 19:44 ` Eric Sunshine
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAE5ih7_01ZixwnFP2kGN9Y5M26MyNai82USUr2UfunL3Ubztdg@mail.gmail.com \
--to=luke@diamand.org \
--cc=git@vger.kernel.org \
--cc=larsxschneider@gmail.com \
--cc=merlorom@yahoo.fr \
--cc=miguel.torroja@gmail.com \
--cc=szeder.dev@gmail.com \
--cc=viniciusalexandre@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).