From: Luke Diamand <luke@diamand.org>
To: Junio C Hamano <gitster@pobox.com>
Cc: Git Users <git@vger.kernel.org>,
Lars Schneider <larsxschneider@gmail.com>,
Michael J Gruber <git@drmicha.warpmail.net>
Subject: Re: [PATCH] git-p4: Add failing test case for name-rev vs symbolic-ref
Date: Mon, 27 Mar 2017 07:57:47 +0100 [thread overview]
Message-ID: <CAE5ih78jhR3GwMBdPyi5oOHByC2fVxefExStc9pCNMTu-1Os7w@mail.gmail.com> (raw)
In-Reply-To: <xmqqefxj4ofm.fsf@gitster.mtv.corp.google.com>
On 27 March 2017 at 00:18, Junio C Hamano <gitster@pobox.com> wrote:
> Luke Diamand <luke@diamand.org> writes:
>
>> As per the discussion about use of "git name-rev" vs "git symbolic-ref" in
>> git-p4 here:
>>
>> http://marc.info/?l=git&m=148979063421355
>>
>> git-p4 could get confused about the branch it is on and affects
>> the git-p4.allowSubmit <branchname> option. This adds a failing
>> test case for the problem.
>>
>> Luke Diamand (1):
>> git-p4: add failing test for name-rev rather than symbolic-ref
>>
>> t/t9807-git-p4-submit.sh | 16 ++++++++++++++++
>> 1 file changed, 16 insertions(+)
>
> Ahh, thanks for tying loose ends. I completely forgot about that
> topic.
>
> If we queue this and then update the function in git-p4.py that
> (mis)uses name-rev to learn the current branch to use symbolic-ref
> instead, can we flip the "expect_failure" to "expect_success"?
Yes. The test passes with your change.
>
> IOW, can we have a follow up to this patch that fixes a known
> breakage the patch documents ;-)?
Yes.
Regards!
Luke
next prev parent reply other threads:[~2017-03-27 6:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-26 9:15 [PATCH] git-p4: Add failing test case for name-rev vs symbolic-ref Luke Diamand
2017-03-26 9:15 ` [PATCH] git-p4: add failing test for name-rev rather than symbolic-ref Luke Diamand
2017-03-26 23:18 ` [PATCH] git-p4: Add failing test case for name-rev vs symbolic-ref Junio C Hamano
2017-03-27 6:57 ` Luke Diamand [this message]
2017-03-27 20:30 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAE5ih78jhR3GwMBdPyi5oOHByC2fVxefExStc9pCNMTu-1Os7w@mail.gmail.com \
--to=luke@diamand.org \
--cc=git@drmicha.warpmail.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=larsxschneider@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).