git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Luke Diamand <luke@diamand.org>
To: Lars Schneider <larsxschneider@gmail.com>
Cc: Git Users <git@vger.kernel.org>
Subject: Re: git-p4: t9819 failing
Date: Thu, 24 Sep 2015 21:29:01 +0100	[thread overview]
Message-ID: <CAE5ih7-f3V2YSWW7FO-MxB6BPu7WjB93jDDFs5mKkzz2wDX0yA@mail.gmail.com> (raw)
In-Reply-To: <CAE5ih78m9RbD=s_12ckA+yzRP=fuiruF=kasUSFZEjUZZA21UQ@mail.gmail.com>

OK, slight correction there - it now doesn't crash getting the disk
usage, but I think it still needs to be updated following the other
changes to case-handling.

Luke

On 24 September 2015 at 08:45, Luke Diamand <luke@diamand.org> wrote:
> On 23 September 2015 at 13:28, Lars Schneider <larsxschneider@gmail.com> wrote:
>>
>>> Here's the last bit of the crash dump from git-p4 I get:
>>>
>>>  File "/home/ldiamand/git/git/git-p4", line 2580, in streamP4FilesCbSelf
>>>    self.streamP4FilesCb(entry)
>>>  File "/home/ldiamand/git/git/git-p4", line 2497, in streamP4FilesCb
>>>    required_bytes = int((4 * int(self.stream_file["fileSize"])) -
>>> calcDiskFree(self.cloneDestination))
>>>  File "/home/ldiamand/git/git/git-p4", line 116, in calcDiskFree
>>>    st = os.statvfs(dirname)
>>> OSError: [Errno 2] No such file or directory: 'lc'
>>>
>>> Luke
>> Confirmed. What do you think about this fix?
>
> Works for me!
>
>
>
>>
>> Thank you,
>> Lars
>>
>> ---
>>  git-p4.py | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/git-p4.py b/git-p4.py
>> index 1d1bb87..66c0a4e 100755
>> --- a/git-p4.py
>> +++ b/git-p4.py
>> @@ -3478,6 +3478,7 @@ class P4Clone(P4Sync):
>>
>>          print "Importing from %s into %s" % (', '.join(depotPaths), self.cloneDestination)
>>
>> +        self.cloneDestination = os.path.abspath(self.cloneDestination)
>>          if not os.path.exists(self.cloneDestination):
>>              os.makedirs(self.cloneDestination)
>>          chdir(self.cloneDestination)
>> --

  reply	other threads:[~2015-09-24 20:29 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-23  9:27 git-p4: t9819 failing Luke Diamand
2015-09-23 10:27 ` Lars Schneider
2015-09-23 11:11   ` Luke Diamand
2015-09-23 12:28     ` Lars Schneider
2015-09-24  7:45       ` Luke Diamand
2015-09-24 20:29         ` Luke Diamand [this message]
2015-09-25  9:29           ` Lars Schneider

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAE5ih7-f3V2YSWW7FO-MxB6BPu7WjB93jDDFs5mKkzz2wDX0yA@mail.gmail.com \
    --to=luke@diamand.org \
    --cc=git@vger.kernel.org \
    --cc=larsxschneider@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).