git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: John Shahid <jvshahid@gmail.com>
To: git@vger.kernel.org
Subject: git push recurse.submodules behavior changed in 2.13
Date: Sat, 27 May 2017 09:31:15 -0400	[thread overview]
Message-ID: <CAE5=+KX57KM+6n9NpePw9KYPXFy7UH-WRgSwaJDnvRofYFXm7Q@mail.gmail.com> (raw)

Hi all,

It looks like the git push recurse-submodules behavior has changed.
Currently with 2.13 you cannot run "git push
--recurse-submodules=on-demand" if the parent repo is on a different
branch than the sub repos, e.g. parent repo is on "develop" and
sub-repo on "master". I created a test that can be found here [1].

A bisect shows that the change to propagate refspec [2] to the
submodules is the culprit. imho this is an undesired change in
behavior. I looked at the code but couldn't see an easy way to fix
this issue without breaking the feature mentioned above. The only
option I can think of is to control the refspec propagation behavior
using a flag, e.g. "--propagate-refspecs" or add another
recurse-submodules option, e.g. "--recurse-submodules=propagate"

What do you all think ?

[1] https://gist.github.com/jvshahid/b778702cc3d825c6887d2707e866a9c8
[2] https://github.com/git/git/commit/06bf4ad1db92c32af38e16d9b7f928edbd647780

             reply	other threads:[~2017-05-27 13:31 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-27 13:31 John Shahid [this message]
2017-05-29  2:44 ` git push recurse.submodules behavior changed in 2.13 Junio C Hamano
2017-05-29  4:20   ` Stefan Beller
2017-05-30 12:01     ` John Shahid
2017-05-30 17:05       ` Brandon Williams
2017-05-30 18:10 ` Jonathan Nieder
2017-05-31 14:50   ` John Shahid
2017-06-10 13:28     ` John Shahid
2017-06-12 17:27       ` Stefan Beller
2017-06-16 14:11         ` John Shahid

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAE5=+KX57KM+6n9NpePw9KYPXFy7UH-WRgSwaJDnvRofYFXm7Q@mail.gmail.com' \
    --to=jvshahid@gmail.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).