Re: [GSOC] [PATCH v1 2/2] Change indents to TAB

[Vivan Garg <v.garg.work@gmail.com>]

You are missing the body of the commit message here as well, Please add one
in your next re-roll.

On Tue, Feb 21, 2023 at 10:01 PM Zhang Yi <18994118902@163.com> wrote:
>
> Signed-off-by: Zhang Yi <18994118902@163.com>
> ---
>  t/t9700-perl-git.sh | 58 ++++++++++++++++++++++-----------------------
>  1 file changed, 29 insertions(+), 29 deletions(-)
>
> diff --git a/t/t9700-perl-git.sh b/t/t9700-perl-git.sh
> index 3f6396ef63..671875a3fc 100755
> --- a/t/t9700-perl-git.sh
> +++ b/t/t9700-perl-git.sh
> @@ -14,35 +14,35 @@ skip_all_if_no_Test_More
>  # set up test repository
>
>  test_expect_success 'set up test repository' '
> -     echo "test file 1" > file1 &&
> -     echo "test file 2" > file2 &&
> -     mkdir directory1 &&
> -     echo "in directory1" >> directory1/file &&
> -     mkdir directory2 &&
> -     echo "in directory2" >> directory2/file &&
> -     git add . &&
> -     git commit -m "first commit" &&
> -
> -     echo "new file in subdir 2" > directory2/file2 &&
> -     git add . &&
> -     git commit -m "commit in directory2" &&
> -
> -     echo "changed file 1" > file1 &&
> -     git commit -a -m "second commit" &&
> -
> -     git config --add color.test.slot1 green &&
> -     git config --add test.string value &&
> -     git config --add test.dupstring value1 &&
> -     git config --add test.dupstring value2 &&
> -     git config --add test.booltrue true &&
> -     git config --add test.boolfalse no &&
> -     git config --add test.boolother other &&
> -     git config --add test.int 2k &&
> -     git config --add test.path "~/foo" &&
> -     git config --add test.pathexpanded "$HOME/foo" &&
> -     git config --add test.pathmulti foo &&
> -     git config --add test.pathmulti bar
> -     '
> +       echo "test file 1" > file1 &&
> +       echo "test file 2" > file2 &&
> +       mkdir directory1 &&
> +       echo "in directory1" >> directory1/file &&
> +       mkdir directory2 &&
> +       echo "in directory2" >> directory2/file &&
> +       git add . &&
> +       git commit -m "first commit" &&
> +
> +       echo "new file in subdir 2" > directory2/file2 &&
> +       git add . &&
> +       git commit -m "commit in directory2" &&
> +
> +       echo "changed file 1" > file1 &&
> +       git commit -a -m "second commit" &&
> +
> +       git config --add color.test.slot1 green &&
> +       git config --add test.string value &&
> +       git config --add test.dupstring value1 &&
> +       git config --add test.dupstring value2 &&
> +       git config --add test.booltrue true &&
> +       git config --add test.boolfalse no &&
> +       git config --add test.boolother other &&
> +       git config --add test.int 2k &&
> +       git config --add test.path "~/foo" &&
> +       git config --add test.pathexpanded "$HOME/foo" &&
> +       git config --add test.pathmulti foo &&
> +       git config --add test.pathmulti bar
> +'
>
>  test_expect_success 'set up bare repository' '
>         git init --bare bare.git
> --

There should be no whitespace after redirect operators; as described in the last
commit of this patch. Make sure to fix that in your next re-roll for
this test script
as well. You might also want to look at this for a summary of all the
things you
need to do:
https://lore.kernel.org/git/CAPig+cQpUu2UO-+jWn1nTaDykWnxwuEitzVB7PnW2SS_b7V8Hg@mail.gmail.com/

> 2.29.0-rc0
>

Thanks!