From: Caio Marcelo de Oliveira Filho <cmarcelo@gmail.com>
To: Remi Galan Alfonso <remi.galan-alfonso@ensimag.grenoble-inp.fr>
Cc: git <git@vger.kernel.org>
Subject: Re: [PATCH] commit: add commit.signoff config option
Date: Thu, 25 Jun 2015 11:57:13 -0300 [thread overview]
Message-ID: <CADstYCZ6cXrA-3a-NX1GANQ+tjL69D-V37Y0FGbs9dpF4Oa7rg@mail.gmail.com> (raw)
In-Reply-To: <1228200928.789773.1435221179871.JavaMail.zimbra@ensimag.grenoble-inp.fr>
> In both tests, you should probably use 'test_config' instead of 'git
> config [...] git config --unset', it takes care of it for you (also
> should prevent the case where the config is not unset when your test
> fails in the middle).
Posted a v2 with this improvement and the bash completion.
Thanks for the review.
--
Caio Marcelo de Oliveira Filho
next prev parent reply other threads:[~2015-06-25 14:57 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-25 7:30 [PATCH] commit: add commit.signoff config option cmarcelo
2015-06-25 8:21 ` Alexander Kuleshov
2015-06-25 8:32 ` Remi Galan Alfonso
2015-06-25 14:57 ` Caio Marcelo de Oliveira Filho [this message]
-- strict thread matches above, loose matches on Subject: below --
2015-06-25 7:32 Caio Marcelo de Oliveira Filho
2015-06-25 8:43 ` Christian Couder
2015-06-25 14:55 ` Caio Marcelo de Oliveira Filho
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CADstYCZ6cXrA-3a-NX1GANQ+tjL69D-V37Y0FGbs9dpF4Oa7rg@mail.gmail.com \
--to=cmarcelo@gmail.com \
--cc=git@vger.kernel.org \
--cc=remi.galan-alfonso@ensimag.grenoble-inp.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).