git@vger.kernel.org list mirror (unofficial, one of many)
 help / color / mirror / code / Atom feed
* Re: [PATCH] Optimize the description of the configuration in packfile-uris doc
@ 2021-05-13  2:45 Teng Long
  0 siblings, 0 replies; 4+ messages in thread
From: Teng Long @ 2021-05-13  2:45 UTC (permalink / raw)
  To: jonathantanmy; +Cc: dyroneteng, git

Jonathan Tan <jonathantanmy@google.com> writes:

>As for the commit message, limit the title to 50 characters or fewer if
>possible. Maybe something like "packfile-uri.txt: fix blobPackfileUri
>description" or something like that.

Thanks for mention this, "packfile-uri.txt: fix blobPackfileUri
description" is good and meets the "50 characters" requirement.

So, you are right and the title will be changed in the next patch.

>Also in the commit message, maybe mention that the correct format can be
>seen in t5702.

Because I am implementing another patch[1] about supporting the commit
object in packfile-uri, so I noticed the `configure_exclusion` function in
t5702.

Agree and will include it in the next patch.

Thanks.

[1] https://public-inbox.org/git/20210507021140.31372-1-dyroneteng@gmail.com

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] Optimize the description of the configuration in packfile-uris doc
  2021-05-06 16:47 ` Jonathan Tan
@ 2021-05-06 21:39   ` Junio C Hamano
  0 siblings, 0 replies; 4+ messages in thread
From: Junio C Hamano @ 2021-05-06 21:39 UTC (permalink / raw)
  To: Jonathan Tan; +Cc: dyroneteng, git

Jonathan Tan <jonathantanmy@google.com> writes:

>> There is a description problem in the document about packfile-uris. This
>> patch describes the configuration format of `uploadpack.blobPackfileUri`
>> more accurately.
>
> Thanks for noticing this. The diff itself is correct, of course.
>
> As for the commit message, limit the title to 50 characters or fewer if
> possible. Maybe something like "packfile-uri.txt: fix blobPackfileUri
> description" or something like that.
>
> Also in the commit message, maybe mention that the correct format can be
> seen in t5702.

Thanks for giving a review with clear suggestion for improvements,
Jonathan.  And thanks for contributing, Teng.

Will look forward to seeing an updated patch.

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] Optimize the description of the configuration in packfile-uris doc
  2021-05-06  7:33 Teng Long
@ 2021-05-06 16:47 ` Jonathan Tan
  2021-05-06 21:39   ` Junio C Hamano
  0 siblings, 1 reply; 4+ messages in thread
From: Jonathan Tan @ 2021-05-06 16:47 UTC (permalink / raw)
  To: dyroneteng; +Cc: git, jonathantanmy

> There is a description problem in the document about packfile-uris. This
> patch describes the configuration format of `uploadpack.blobPackfileUri`
> more accurately.

Thanks for noticing this. The diff itself is correct, of course.

As for the commit message, limit the title to 50 characters or fewer if
possible. Maybe something like "packfile-uri.txt: fix blobPackfileUri
description" or something like that.

Also in the commit message, maybe mention that the correct format can be
seen in t5702.

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH] Optimize the description of the configuration in packfile-uris doc
@ 2021-05-06  7:33 Teng Long
  2021-05-06 16:47 ` Jonathan Tan
  0 siblings, 1 reply; 4+ messages in thread
From: Teng Long @ 2021-05-06  7:33 UTC (permalink / raw)
  To: git; +Cc: jonathantanmy, Teng Long

There is a description problem in the document about packfile-uris. This
patch describes the configuration format of `uploadpack.blobPackfileUri`
more accurately.

Signed-off-by: Teng Long <dyroneteng@gmail.com>
---
 Documentation/technical/packfile-uri.txt | 15 ++++++++-------
 1 file changed, 8 insertions(+), 7 deletions(-)

diff --git a/Documentation/technical/packfile-uri.txt b/Documentation/technical/packfile-uri.txt
index f7eabc6c76..1eb525fe76 100644
--- a/Documentation/technical/packfile-uri.txt
+++ b/Documentation/technical/packfile-uri.txt
@@ -35,13 +35,14 @@ include some sort of non-trivial implementation in the Minimum Viable Product,
 at least so that we can test the client.
 
 This is the implementation: a feature, marked experimental, that allows the
-server to be configured by one or more `uploadpack.blobPackfileUri=<sha1>
-<uri>` entries. Whenever the list of objects to be sent is assembled, all such
-blobs are excluded, replaced with URIs. As noted in "Future work" below, the
-server can evolve in the future to support excluding other objects (or other
-implementations of servers could be made that support excluding other objects)
-without needing a protocol change, so clients should not expect that packfiles
-downloaded in this way only contain single blobs.
+server to be configured by one or more `uploadpack.blobPackfileUri=
+<object-hash> <pack-hash> <uri>` entries. Whenever the list of objects to be
+sent is assembled, all such blobs are excluded, replaced with URIs. As noted
+in "Future work" below, the server can evolve in the future to support
+excluding other objects (or other implementations of servers could be made
+that support excluding other objects) without needing a protocol change, so
+clients should not expect that packfiles downloaded in this way only contain
+single blobs.
 
 Client design
 -------------
-- 
2.31.1


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2021-05-13  2:45 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-13  2:45 [PATCH] Optimize the description of the configuration in packfile-uris doc Teng Long
  -- strict thread matches above, loose matches on Subject: below --
2021-05-06  7:33 Teng Long
2021-05-06 16:47 ` Jonathan Tan
2021-05-06 21:39   ` Junio C Hamano

Code repositories for project(s) associated with this inbox:

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).