From: Jacob Vosmaer <jacob@gitlab.com>
To: Git Mailing List <git@vger.kernel.org>
Subject: Re: Feature-request: git-bundle --quiet
Date: Mon, 12 Aug 2019 12:15:19 +0200 [thread overview]
Message-ID: <CADMWQoP3tH7-e+3FCYkB7b7nf8v-HBQ1toDoje8G_hvD_LaDZw@mail.gmail.com> (raw)
In-Reply-To: <20190808104212.GA14189@sigill.intra.peff.net>
This is a tangent, but relevant: how do we feel about the fact that
'git bundle create' does not perform CRC32 checks when copying data
out of an existing packfile?
See https://github.com/git/git/blob/v2.22.0/builtin/pack-objects.c#L2614-L2622 .
I understand the rationale of "skip CRC32 when serving a fetch",
although I have no clue how much we gain from skipping it. But "pack
to stdout means fetch" isn't quite accurate, as it includes bundles.
Best regards,
Jacob Vosmaer
GitLab, Inc.
Best regards,
Jacob Vosmaer
GitLab, Inc.
On Thu, Aug 8, 2019 at 12:42 PM Jeff King <peff@peff.net> wrote:
>
> On Tue, Aug 06, 2019 at 07:19:11PM +0000, Robin H. Johnson wrote:
>
> > I started trying to make a stab at implementing this, but the code
> > wasn't standing out for it. Hopefully somebody else has poked at it
> > before:
> >
> > I'd like to have a --quiet option for git-bundle, such that only errors
> > are sent to stderr, and not the packing progress.
>
> This seems like a reasonable thing to want.
>
> It looks like you'd have to teach cmd_bundle() to use parse_options(),
> parse a quiet flag, and then pas that down to create_bundle(). Then it
> would pass it along to write_pack_data(), which would decide whether to
> pass "-q".
>
> That would allow:
>
> git bundle --quiet create foo.bundle ...
>
> -Peff
next prev parent reply other threads:[~2019-08-12 10:15 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-06 19:19 Feature-request: git-bundle --quiet Robin H. Johnson
2019-08-08 10:42 ` Jeff King
2019-08-12 10:15 ` Jacob Vosmaer [this message]
2019-08-12 16:08 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CADMWQoP3tH7-e+3FCYkB7b7nf8v-HBQ1toDoje8G_hvD_LaDZw@mail.gmail.com \
--to=jacob@gitlab.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).