From: Jacob Vosmaer <jacob@gitlab.com>
To: rsbecker@nexbridge.com
Cc: Junio C Hamano <gitster@pobox.com>,
git@vger.kernel.org, avarab@gmail.com, peff@peff.net
Subject: Re: [PATCH v2 1/1] upload-pack.c: increase output buffer size
Date: Wed, 15 Dec 2021 21:45:19 +0100 [thread overview]
Message-ID: <CADMWQoMJ_BBzwSsaCBwLjaWuu=L2=f_nWSemR-pctBMpMTsgbA@mail.gmail.com> (raw)
In-Reply-To: <003301d7f1f3$c1e24f20$45a6ed60$@nexbridge.com>
On Wed, Dec 15, 2021 at 9:38 PM <rsbecker@nexbridge.com> wrote:
>
> The maximum I/O size on the platform is 56Kb. Anything larger will fail. That's why we use xread and xwrite for non-buffered I/O.
That sounds like it's orthogonal to what this patch is changing.
Regardless of this patch, the actual writes are performed by
write_or_die, which calls write_in_full. In turn, write_in_full calls
xwrite however often is necessary. We are not making any assumptions
anywhere about how large individual write syscalls turn out. Git
packets use userspace buffers so we can read and write them no matter
what the underlying IO sizes are.
next prev parent reply other threads:[~2021-12-15 20:45 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-13 13:23 [PATCH 0/1] Make upload-pack pack write size configurable Jacob Vosmaer
2021-12-13 13:23 ` [PATCH 1/1] upload-pack.c: make output buffer " Jacob Vosmaer
2021-12-14 12:08 ` Ævar Arnfjörð Bjarmason
2021-12-14 15:08 ` Jeff King
2021-12-14 19:46 ` [PATCH v2 0/1] upload-pack.c: increase output buffer size Jacob Vosmaer
2021-12-14 19:46 ` [PATCH v2 1/1] " Jacob Vosmaer
2021-12-14 20:41 ` Ævar Arnfjörð Bjarmason
2021-12-15 16:30 ` Jeff King
2021-12-15 19:50 ` Junio C Hamano
2021-12-15 19:59 ` rsbecker
2021-12-15 20:24 ` Jacob Vosmaer
2021-12-15 20:38 ` rsbecker
2021-12-15 20:45 ` Jacob Vosmaer [this message]
2021-12-15 21:34 ` rsbecker
2021-12-14 15:37 ` [PATCH 1/1] upload-pack.c: make output buffer size configurable Jeff King
2021-12-14 20:04 ` Jacob Vosmaer
2021-12-14 15:12 ` [PATCH 0/1] Make upload-pack pack write " Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CADMWQoMJ_BBzwSsaCBwLjaWuu=L2=f_nWSemR-pctBMpMTsgbA@mail.gmail.com' \
--to=jacob@gitlab.com \
--cc=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=peff@peff.net \
--cc=rsbecker@nexbridge.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).