From: Ilan Biala <ilanbiala@gmail.com>
To: Jeff King <peff@peff.net>
Cc: git@vger.kernel.org
Subject: Re: git diff --name-only --submodule=diff combination does not work
Date: Tue, 22 Sep 2020 17:32:12 -0400 [thread overview]
Message-ID: <CAD2jYq8OtHUpfUZyXC_+FHew45XEtgty3H-XF_2e30mb6kCCmw@mail.gmail.com> (raw)
In-Reply-To: <20200922212404.GA547416@coredump.intra.peff.net>
I expected adding --submodule=diff to add all the filenames in
submodules that were modified, but the output just shows the submodule
folder name, not all the files within the submodule that were
modified.
On Tue, Sep 22, 2020 at 5:24 PM Jeff King <peff@peff.net> wrote:
>
> On Tue, Sep 22, 2020 at 04:56:45PM -0400, Ilan Biala wrote:
>
> > I've been running into issues with using the --name-only and
> > --submodule=diff flags together in Git 2.27.0. Is this a known bug?
>
> What did you expect it to do, and what did it do instead?
>
> I'm not very familiar with the --submodule flag, but it looks like it
> only impacts "--patch" output. E.g., in git.git (with the submodule
> actually populated):
>
> $ git log --oneline --submodule=diff -p sha1collisiondetection
> 4125f78222 sha1dc: update from upstream
> Submodule sha1collisiondetection 16033998da..855827c583:
> > Detect endianess on HP-UX
> 07a20f569b Makefile: fix unaligned loads in sha1dc with UBSan
> Submodule sha1collisiondetection 232357eb2e..16033998da:
> > Shorter version of force aligned access.
> > Add compiler option to force aligned access even for Intel CPUs.
> 23e37f8e9d sha1dc: update from upstream
> Submodule sha1collisiondetection 19d97bf5af..232357eb2e:
> > Merge pull request #45 from avar/aix-big-endian-detection
> > sha1c: fix a trivial spelling error
> 86cfd61e6b sha1dc: optionally use sha1collisiondetection as a submodule
> Submodule sha1collisiondetection 0000000000...19d97bf5af (new submodule)
>
> $ git log --oneline --submodule=log --raw sha1collisiondetection
> 4125f78222 sha1dc: update from upstream
> :160000 160000 16033998da 855827c583 M sha1collisiondetection
> 07a20f569b Makefile: fix unaligned loads in sha1dc with UBSan
> :160000 160000 232357eb2e 16033998da M sha1collisiondetection
> 23e37f8e9d sha1dc: update from upstream
> :160000 160000 19d97bf5af 232357eb2e M sha1collisiondetection
> 86cfd61e6b sha1dc: optionally use sha1collisiondetection as a submodule
> :000000 160000 0000000000 19d97bf5af A sha1collisiondetection
>
> -Peff
next prev parent reply other threads:[~2020-09-22 21:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20200922193407.23931C0613CF@lindbergh.monkeyblade.net>
2020-09-22 20:56 ` git diff --name-only --submodule=diff combination does not work Ilan Biala
2020-09-22 21:24 ` Jeff King
2020-09-22 21:32 ` Ilan Biala [this message]
2020-09-24 6:38 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAD2jYq8OtHUpfUZyXC_+FHew45XEtgty3H-XF_2e30mb6kCCmw@mail.gmail.com \
--to=ilanbiala@gmail.com \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).