mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Dave Borowitz <>
To: Junio C Hamano <>
Cc: git <>
Subject: Re: Bug: send-pack does not respect http.signingkey
Date: Thu, 16 Jul 2015 15:08:48 -0700	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

On Thu, Jul 16, 2015 at 2:10 PM, Junio C Hamano <> wrote:
> Dave Borowitz <> writes:
>> On Thu, Jul 16, 2015 at 1:12 PM, Junio C Hamano <> wrote:
>>> Dave Borowitz <> writes:
>>>> On Thu, Jul 16, 2015 at 1:06 PM, Junio C Hamano <> wrote:
>>>>> Perhaps something like this?
>>>> Seems like it should work.
>>>> Jonathan had suggested there might be some principled reason why
>>>> send-pack does not respect config options, and suggested passing it in
>>>> as a flag. But that would be more work, certainly, as it would also
>>>> have to get passed through git-remote-http somehow.
>>> I actually was wondering about exactly the same thing as Jonathan,
>>> and that is where my "Perhaps" came from.
>> I will say, though, as the maintainer of a handful of custom remote
>> helpers, I would prefer a solution that does not involve changing the
>> implementation of those just to pass this configuration through.
> That is not a controversial part ;-)
>> So my
>> vote would be for send-pack to respect the normal config options.
> The thing is what should be included in the "normal" config options.
> The "something like this?" patch was deliberately narrow, including
> only the GPG thing and nothing else.  But anticipating that the ref
> backend would be per repo configuration, and send-pack would want to
> read from refs (and possibly write back tracking?), we may want to
> prepare ourselves by reading a bit wider than "GPG thing and nothing
> else", e.g. git_default_config() or something like that.

Ah, now I understand the question. I have no opinion other than that
we shouldn't let discussion about future features prevent us from
fixing this obvious signed push bug :)

  reply	other threads:[~2015-07-16 22:09 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-16 19:45 Bug: send-pack does not respect http.signingkey Dave Borowitz
2015-07-16 20:06 ` Junio C Hamano
2015-07-16 20:08   ` Dave Borowitz
2015-07-16 20:12     ` Junio C Hamano
2015-07-16 20:31       ` Dave Borowitz
2015-07-16 21:10         ` Junio C Hamano
2015-07-16 22:08           ` Dave Borowitz [this message]
2015-07-21 19:25             ` Dave Borowitz
2015-07-21 19:33               ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

  List information:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).