From: Duy Nguyen <pclouds@gmail.com>
To: Stefan Beller <sbeller@google.com>
Cc: David Turner <novalis@novalis.org>, git <git@vger.kernel.org>
Subject: Re: git push requires a worktree?
Date: Wed, 30 May 2018 20:50:52 +0200 [thread overview]
Message-ID: <CACsJy8Dy6Ft7jnj2SFz_0uLSxv9muujY_0nTvFbi3XGMEGFKgA@mail.gmail.com> (raw)
In-Reply-To: <CAGZ79kaT2KM0cZOSEXMpnr53TxUdH=gSbyQaGdBw1wEGnkK2Kw@mail.gmail.com>
On Wed, May 30, 2018 at 7:32 PM, Stefan Beller <sbeller@google.com> wrote:
> * the setup code for commands that do not have the
> NEED_WORK_TREE flag in git.c
Unless it's very urgent, I can fix it later (and hopefully soon-ish).
The problem is definitely not with setting core.worktree but with too
eagerly chdir() when you don't need it. We also have another problem
(chdir'ing too late) in the same area that led to the introduction of
chdir-notify. If I'm successful in killing chdir-notify by chdir at
the right time and with the right condition, then it should fix this
as well. I'm pretty close to it, I think.
--
Duy
prev parent reply other threads:[~2018-05-30 18:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-30 17:16 git push requires a worktree? David Turner
2018-05-30 17:32 ` Stefan Beller
2018-05-30 18:50 ` Duy Nguyen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACsJy8Dy6Ft7jnj2SFz_0uLSxv9muujY_0nTvFbi3XGMEGFKgA@mail.gmail.com \
--to=pclouds@gmail.com \
--cc=git@vger.kernel.org \
--cc=novalis@novalis.org \
--cc=sbeller@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).