From: Duy Nguyen <pclouds@gmail.com>
To: Klaatu <klaatu@member.fsf.org>
Cc: Git Mailing List <git@vger.kernel.org>
Subject: Re: Git excludes fails to avoid git submodule warning
Date: Sun, 24 Mar 2019 14:58:22 +0700 [thread overview]
Message-ID: <CACsJy8Dhio4C6p-ZtJ1ZOq-6UP9GiBg3sXsy4YDKamm5p-zqbw@mail.gmail.com> (raw)
In-Reply-To: <5352115.zUM9HkL6VV@beast>
On Sun, Mar 24, 2019 at 6:01 AM Klaatu <klaatu@member.fsf.org> wrote:
>
> Working with Git 2.21.0 on Linux:
>
> The git-add(1) man page says:
>
> "The optional configuration variable core.excludesFile indicates a path to a
> file containing patterns of file names to exclude from git-add"
>
> But if I do this:
>
> $ echo "docs/themes/*/.git >> .gitexcludes
> $ git config core.excludeFiles .gitexcludes
> $ git add docs
> warning: adding embedded git repository: docs/themes/foo
>
> It seems to me that this goes against what the git-add(1) man page says.
>
> A workaround I found on stackoverflow is to add any file within the target
> directory:
>
> $ git add docs/themes/foo/README
>
> And then add everything:
>
> $ git add docs
>
> In which case the contents of .gitexcludes is honoured. But that seems like a
> hack.
That's because you're not supposed to add files inside another
repository. The "git add docs/theme/foo/README" should have failed.
This kind of sharing part of worktree between two repositories (the
top dir and one in docs/themes/foo) has never been officiaily
supported if I remember it correctly.
> Am I experiencing the intended result of Git's exclude function? If so, I'll
> happily submit a patch to the man page to clarify this behaviour. If not, I
> guess I'm submitting a bug report here.
>
> Thanks for all the amazing work.
--
Duy
prev parent reply other threads:[~2019-03-24 7:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-24 18:15 Git excludes fails to avoid git submodule warning Klaatu
2019-03-24 7:58 ` Duy Nguyen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACsJy8Dhio4C6p-ZtJ1ZOq-6UP9GiBg3sXsy4YDKamm5p-zqbw@mail.gmail.com \
--to=pclouds@gmail.com \
--cc=git@vger.kernel.org \
--cc=klaatu@member.fsf.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).