git@vger.kernel.org list mirror (unofficial, one of many)
 help / color / Atom feed
From: Duy Nguyen <pclouds@gmail.com>
To: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Cc: Junio C Hamano <gitster@pobox.com>,
	Git Mailing List <git@vger.kernel.org>,
	Derrick Stolee <stolee@gmail.com>
Subject: Re: What's cooking in git.git (Mar 2019, #04; Wed, 20)
Date: Thu, 21 Mar 2019 18:14:18 +0700
Message-ID: <CACsJy8DgNzGK3g2P7ZyRmd7sbiSOXY07KqYEh-gSsPkEZ+D5Qw@mail.gmail.com> (raw)
In-Reply-To: <87sgvgcy3o.fsf@evledraar.gmail.com>

On Thu, Mar 21, 2019 at 5:37 PM Ævar Arnfjörð Bjarmason
<avarab@gmail.com> wrote:
> diff --git a/commit-graph.c b/commit-graph.c
> index b2f64790aa..28b5b599ee 100644
> --- a/commit-graph.c
> +++ b/commit-graph.c
> @@ -155,14 +155,8 @@ struct commit_graph *parse_commit_graph(void *graph_map, int fd,
>
>         graph_version = *(unsigned char*)(data + 4);
>         if (!graph_version || graph_version > 2) {
> -               error(_("unsupported commit-graph version %X"), graph_version);
> -               return NULL;
> -       }
> -
> -       hash_version = *(unsigned char*)(data + 5);
> -       if (hash_version != oid_version()) {
> -               error(_("commit-graph hash version %X does not match version %X"),
> -                     hash_version, oid_version());
> +               error(_("commit-graph the graph version %X is unsupported"),

Slightly off-topic, but it does not seem to be a good idea to use %X
here, on a user-visible message, without any indication that it's a
hexadecimal number. %d would do, or just put 0x%X.

> +                       graph_version);
>                 return NULL;
>         }
>
> @@ -172,7 +166,7 @@ struct commit_graph *parse_commit_graph(void *graph_map, int fd,
>         case 1:
>                 hash_version = *(unsigned char*)(data + 5);
>                 if (hash_version != oid_version()) {
> -                       error(_("hash version %X does not match version %X"),
> +                       error(_("commit-graph hash version %X does not match version %X"),
>                               hash_version, oid_version());
>                         return NULL;
>                 }



-- 
Duy

      reply index

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-20  3:13 Junio C Hamano
2019-03-20  4:56 ` Junio C Hamano
2019-03-20 11:23 ` Thomas Gummerer
2019-03-20 22:05 ` Rohit Ashiwal
2019-03-20 22:56   ` Thomas Gummerer
2019-03-20 23:07     ` Rohit Ashiwal
2019-03-21  0:31     ` Junio C Hamano
2019-03-20 22:42 ` Ævar Arnfjörð Bjarmason
2019-03-21  0:46   ` Junio C Hamano
2019-03-21  5:19     ` Junio C Hamano
2019-03-21  9:13       ` Ævar Arnfjörð Bjarmason
2019-03-21  9:46         ` Junio C Hamano
2019-03-21 10:37           ` Ævar Arnfjörð Bjarmason
2019-03-21 11:14             ` Duy Nguyen [this message]

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CACsJy8DgNzGK3g2P7ZyRmd7sbiSOXY07KqYEh-gSsPkEZ+D5Qw@mail.gmail.com \
    --to=pclouds@gmail.com \
    --cc=avarab@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=stolee@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

git@vger.kernel.org list mirror (unofficial, one of many)

Archives are clonable:
	git clone --mirror https://public-inbox.org/git
	git clone --mirror http://ou63pmih66umazou.onion/git
	git clone --mirror http://czquwvybam4bgbro.onion/git
	git clone --mirror http://hjrcffqmbrq6wope.onion/git

Example config snippet for mirrors

Newsgroups are available over NNTP:
	nntp://news.public-inbox.org/inbox.comp.version-control.git
	nntp://ou63pmih66umazou.onion/inbox.comp.version-control.git
	nntp://czquwvybam4bgbro.onion/inbox.comp.version-control.git
	nntp://hjrcffqmbrq6wope.onion/inbox.comp.version-control.git
	nntp://news.gmane.org/gmane.comp.version-control.git

 note: .onion URLs require Tor: https://www.torproject.org/

AGPL code for this site: git clone https://public-inbox.org/public-inbox.git