git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Duy Nguyen <pclouds@gmail.com>
To: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Cc: Junio C Hamano <gitster@pobox.com>,
	Git Mailing List <git@vger.kernel.org>
Subject: Re: What's cooking in git.git (Jan 2018, #04; Wed, 31)
Date: Mon, 12 Feb 2018 17:04:35 +0700	[thread overview]
Message-ID: <CACsJy8DZ7DqF9Y_D=Yif6zUj6-Ls=iczyr5UOJonCsafER7spQ@mail.gmail.com> (raw)
In-Reply-To: <876073k2lc.fsf@evledraar.gmail.com>

On Sun, Feb 11, 2018 at 9:44 PM, Ævar Arnfjörð Bjarmason
<avarab@gmail.com> wrote:
>
> On Sat, Feb 10 2018, Duy Nguyen jotted:
>
>> On Sat, Feb 10, 2018 at 1:37 AM, Ævar Arnfjörð Bjarmason
>> <avarab@gmail.com> wrote:
>>>
>>> On Thu, Feb 01 2018, Junio C. Hamano jotted:
>>>
>>>> * nd/fix-untracked-cache-invalidation (2018-01-24) 5 commits
>>>>  - dir.c: stop ignoring opendir() error in open_cached_dir()
>>>>  - update-index doc: note a fixed bug in the untracked cache
>>>>  - dir.c: fix missing dir invalidation in untracked code
>>>>  - dir.c: avoid stat() in valid_cached_dir()
>>>>  - status: add a failing test showing a core.untrackedCache bug
>>>>
>>>>  Some bugs around "untracked cache" feature have been fixed.
>>>>
>>>>  Will merge to 'next'.
>>>
>>> I think you / Nguyễn may not have seen my
>>> <87d11omi2o.fsf@evledraar.gmail.com>
>>> (https://public-inbox.org/git/87d11omi2o.fsf@evledraar.gmail.com/)
>>
>> I have. But since you wrote "I haven't found... yet", I assumed you
>> were still on it. You didn't give me much info to follow anyway.
>
> Haven't had time to dig further, sorry, and won't be able to share the
> repository. Is there some UC inspection command that can be run on the
> relevant path / other thing that'll be indicative of what went wrong?

There's test-dump-untracked-cache that will give you all the data.
From then on, you may need to dig in the code a bit to see how that
data should be processed.

There's no obfuscation support in that command, unfortunately, so you
can't just send me the dump. But if you could limit it to a few
"blocks" related to the error messages, then manual obfuscation should
not take that much time (either that or just add obfuscation in
test-dump-untracked-cache.c, it's probably easier task; or I can do
this for you)

>>> As noted there I think it's best to proceed without the "dir.c: stop
>>> ignoring opendir[...]" patch.
>>>
>>> It's going to be a bad regression in 2.17 if it ends up spewing pagefuls
>>> of warnings in previously working repos if the UC is on.
>>
>> "previously working" is a strong word when opendir() starts to
>> complain. Sure we can suppress/ignore the error messages but I don't
>> think it's a healthy attitude. Unreported bugs can't be fixed.
>
> I mean that for the user it returned the right "git status" info and
> didn't print errors, but yeah, the index may have been in some
> internally funny state.

One question (I wasn't clear from your previous mail). Does "git
status" always report the same errors when run multiple times, or does
it just report once, then next "git status" is silent? I suppose it's
the former case..
-- 
Duy

      reply	other threads:[~2018-02-12 10:05 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-01  0:56 What's cooking in git.git (Jan 2018, #04; Wed, 31) Junio C Hamano
2018-02-01 11:05 ` Ævar Arnfjörð Bjarmason
2018-02-02 18:09   ` Junio C Hamano
2018-02-09 17:06   ` Johannes Schindelin
2018-02-09 18:30     ` Ævar Arnfjörð Bjarmason
2018-02-01 12:11 ` Ævar Arnfjörð Bjarmason
2018-02-02 18:05   ` Junio C Hamano
2018-02-02 19:29     ` Ævar Arnfjörð Bjarmason
2018-02-09 18:37 ` Ævar Arnfjörð Bjarmason
2018-02-09 18:54   ` Junio C Hamano
2018-02-09 21:04     ` [PATCH 0/2] update-index doc: note new caveats in 2.17 Ævar Arnfjörð Bjarmason
2018-02-09 21:40       ` Junio C Hamano
2018-02-09 22:10         ` Ævar Arnfjörð Bjarmason
2018-02-09 21:04     ` [PATCH 1/2] update-index doc: note a fixed bug in the untracked cache Ævar Arnfjörð Bjarmason
2018-02-09 21:52       ` Junio C Hamano
2018-02-09 22:14         ` Ævar Arnfjörð Bjarmason
2018-02-09 22:50           ` Junio C Hamano
2018-02-09 22:58             ` Ævar Arnfjörð Bjarmason
2018-02-09 21:04     ` [PATCH 2/2] update-index doc: note the caveat with "could not open..." Ævar Arnfjörð Bjarmason
2018-02-10 10:09   ` What's cooking in git.git (Jan 2018, #04; Wed, 31) Duy Nguyen
2018-02-11 14:44     ` Ævar Arnfjörð Bjarmason
2018-02-12 10:04       ` Duy Nguyen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CACsJy8DZ7DqF9Y_D=Yif6zUj6-Ls=iczyr5UOJonCsafER7spQ@mail.gmail.com' \
    --to=pclouds@gmail.com \
    --cc=avarab@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).