From: Duy Nguyen <firstname.lastname@example.org> To: Jeff King <email@example.com> Cc: Dakota Hawkins <firstname.lastname@example.org>, Junio C Hamano <email@example.com>, Git <firstname.lastname@example.org> Subject: Re: [PATCH] doc/gitattributes: mention non-recursive behavior Date: Wed, 21 Mar 2018 17:16:16 +0100 [thread overview] Message-ID: <CACsJy8DCkh=kn1bmCQf4idPggsh5cEY936gfR-5qaQKRsmLBzA@mail.gmail.com> (raw) In-Reply-To: <20180321065005.GB16784@sigill.intra.peff.net> On Wed, Mar 21, 2018 at 7:50 AM, Jeff King <email@example.com> wrote: > On Tue, Mar 20, 2018 at 05:41:52PM +0100, Duy Nguyen wrote: > >> > +The rules by which the pattern matches paths are the same as in >> > +`.gitignore` files (see linkgit:gitignore), with a few exceptions: >> > + >> > + - negative patterns are forbidden >> >> After 8b1bd02415 (Make !pattern in .gitattributes non-fatal - >> 2013-03-01) maybe we could use the verb "ignored" too instead of >> "forbidden" > > Makes sense. The original is already in 'next', so do you want to send > an incremental patch? It's up to you. After all it's you who's doing all the work :) >> > + pointless in an attributes file; use `path/**` instead) >> >> We probably could do this internally too (converting "path/" to >> "path/**") but we need to deal with corner cases (e.g. "path" without >> the trailing slash, but is a directory). So yes, suggesting the user >> to do it instead may be easier. > > Yeah, I almost suggested that, but I worried about those corner cases. > It seems like documenting the current behavior is the right first step > in any case. Agreed. > One other maybe-difference I came across coincidentally today: you have > to quote the pattern in .gitattributes if it contains spaces, but not in > .gitignore. But that's more an artifact of the rest of the file syntax > than the pattern syntax (.gitignore has no other fields to confuse it > with). Yeah I forgot about that (and I was the one who started it). The document was updated in 860a74d9d9 (attr: support quoting pathname patterns in C style - 2017-01-27) though. -- Duy
next prev parent reply other threads:[~2018-03-21 16:16 UTC|newest] Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-03-20 1:49 .gitattributes override behavior (possible bug, or documentation bug) Dakota Hawkins 2018-03-20 2:34 ` Jeff King 2018-03-20 3:10 ` Dakota Hawkins 2018-03-20 3:17 ` Dakota Hawkins 2018-03-20 4:12 ` Jeff King 2018-03-20 4:04 ` Jeff King 2018-03-20 4:14 ` [PATCH] doc/gitattributes: mention non-recursive behavior Jeff King 2018-03-20 4:28 ` Dakota Hawkins 2018-03-20 16:41 ` Duy Nguyen 2018-03-21 6:50 ` Jeff King 2018-03-21 16:16 ` Duy Nguyen [this message] 2018-03-23 9:12 ` Jeff King 2018-03-20 4:25 ` .gitattributes override behavior (possible bug, or documentation bug) Dakota Hawkins 2018-03-20 4:40 ` Jeff King 2018-03-20 4:49 ` Dakota Hawkins 2018-03-20 16:28 ` Duy Nguyen 2018-03-21 3:22 ` Dakota Hawkins 2018-03-21 6:52 ` Jeff King 2018-03-21 7:36 ` Dakota Hawkins 2018-03-21 7:44 ` Dakota Hawkins 2018-03-21 7:50 ` Jeff King 2018-03-21 8:35 ` Dakota Hawkins 2018-03-21 8:36 ` Jeff King 2018-03-21 16:18 ` Junio C Hamano 2018-03-21 16:07 ` Duy Nguyen 2018-03-20 3:33 ` Junio C Hamano 2018-03-20 3:40 ` Dakota Hawkins 2018-03-20 3:45 ` Jeff King
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style List information: http://vger.kernel.org/majordomo-info.html * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='CACsJy8DCkh=kn1bmCQf4idPggsh5cEY936gfR-5qaQKRsmLBzA@mail.gmail.com' \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --subject='Re: [PATCH] doc/gitattributes: mention non-recursive behavior' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Code repositories for project(s) associated with this inbox: https://80x24.org/mirrors/git.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).