From: Duy Nguyen <pclouds@gmail.com>
To: Junio C Hamano <gitster@pobox.com>,
David Turner <dturner@twopensource.com>
Cc: git mailing list <git@vger.kernel.org>
Subject: Re: RFC/Pull Request: Refs db backend
Date: Tue, 23 Jun 2015 17:23:09 +0700 [thread overview]
Message-ID: <CACsJy8DA3oOt8QRsztdJXwmfUwDvY_nGALQrOpSA3M_eNSuT8g@mail.gmail.com> (raw)
In-Reply-To: <xmqqvbefdm0d.fsf@gitster.dls.corp.google.com>
On Tue, Jun 23, 2015 at 12:36 PM, Junio C Hamano <gitster@pobox.com> wrote:
> "If there is interest"? Shut up and take my money ;-)
Yeah. This may be the next big thing since pack bitmap. It's even
better if it enters 'master' hand in hand with pack protocol v2, but I
think v2 needs more time.
On Tue, Jun 23, 2015 at 7:50 AM, David Turner <dturner@twopensource.com> wrote:
> To test this backend's correctness, I hacked test-lib.sh and
> test-lib-functions.sh to run all tests under the refs backend.
Now we have two. split-index also benefits from running through full
test suite like this. I propose we make "make test" run the test suite
twice. The first run is with default configuration, no split index, no
fancy ref backend. The second run enables split-index and switches to
new backend, running through all test cases. In future we can also
enable packv4 in this second run. There won't be a third run.
When the second ref backend comes, we can switch between the two
backends using a random number generator where we control both
algorithm and seed, so that when a test fails, the user can give us
their seed and we can re-run with the same configuration.
> Dozens of tests use manual ref/reflog reading/writing, or create submodules
> without passing --refs-backend-type to git init. If those tests are
> changed to use the update-ref machinery or test-refs-be-db (or, in the
> case of packed-refs, corrupt refs, and dumb fetch tests, are skipped),
> the only remaining failing tests are the git-new-workdir tests and the
> gitweb tests.
I haven't read the series, but I guess you should also add a few tests
to run on the first run, so new code is exercised a bit even if people
skip the second run.
--
Duy
next prev parent reply other threads:[~2015-06-23 10:23 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-23 0:50 RFC/Pull Request: Refs db backend David Turner
2015-06-23 5:36 ` Junio C Hamano
2015-06-23 10:23 ` Duy Nguyen [this message]
2015-06-23 18:47 ` David Turner
2015-06-23 17:29 ` David Turner
2015-06-23 11:47 ` Jeff King
2015-06-23 13:10 ` Duy Nguyen
2015-06-24 8:51 ` Jeff King
2015-06-23 18:18 ` David Turner
2015-06-24 9:14 ` Jeff King
2015-06-24 17:29 ` David Turner
2015-06-24 6:09 ` Shawn Pearce
2015-06-24 9:49 ` Jeff King
2015-06-25 1:08 ` brian m. carlson
2015-06-24 10:18 ` Duy Nguyen
2015-06-23 15:51 ` Michael Haggerty
2015-06-23 19:53 ` David Turner
2015-06-23 21:27 ` Michael Haggerty
2015-06-24 17:31 ` David Turner
2015-06-23 21:35 ` David Turner
2015-06-23 21:41 ` Junio C Hamano
2015-06-23 17:16 ` Stefan Beller
2015-06-23 20:04 ` David Turner
2015-06-23 20:10 ` Randall S. Becker
2015-06-23 20:22 ` David Turner
2015-06-23 20:27 ` Randall S. Becker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACsJy8DA3oOt8QRsztdJXwmfUwDvY_nGALQrOpSA3M_eNSuT8g@mail.gmail.com \
--to=pclouds@gmail.com \
--cc=dturner@twopensource.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).