From: Nguyen Thai Ngoc Duy <pclouds@gmail.com>
To: "Zbigniew Jędrzejewski-Szmek" <zbyszek@in.waw.pl>
Cc: git@vger.kernel.org, gitster@pobox.com,
Michael J Gruber <git@drmicha.warpmail.net>
Subject: Re: [PATCH 3/3 v5] diff --stat: use less columns for change counts
Date: Wed, 15 Feb 2012 19:12:20 +0700 [thread overview]
Message-ID: <CACsJy8D4sWm8iprprbjU7X5RyPE4fbqiU2f70idByRmpkh70wA@mail.gmail.com> (raw)
In-Reply-To: <1329303808-16989-3-git-send-email-zbyszek@in.waw.pl>
2012/2/15 Zbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl>:
> Number of columns required for change counts is computed based on the
> maximum number of changed lines. This means that usually a few more
> columns will be available for the filenames and the graph.
If the required number of columns is less than 80 (or even lower), can
we maintain current spacing strategy? I just want to avoid mass
updates in the test suite. More or less space does not make much
different for narrow diffstats anyway.
--
Duy
next prev parent reply other threads:[~2012-02-15 12:12 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-09 23:58 (unknown), Zbigniew Jędrzejewski-Szmek
2012-02-09 23:58 ` [PATCH 1/4] Move git_version_string to help.c in preparation for diff changes Zbigniew Jędrzejewski-Szmek
2012-02-10 0:46 ` Junio C Hamano
2012-02-09 23:58 ` [PATCH 2/4] help.c: make term_columns() cached and export it Zbigniew Jędrzejewski-Szmek
2012-02-10 0:50 ` Junio C Hamano
2012-02-09 23:58 ` [PATCH 3/4] diff --stat: use the real terminal width Zbigniew Jędrzejewski-Szmek
2012-02-10 0:54 ` Junio C Hamano
2012-02-10 6:15 ` Nguyen Thai Ngoc Duy
2012-02-10 11:25 ` Zbigniew Jędrzejewski-Szmek
2012-02-10 13:00 ` Nguyen Thai Ngoc Duy
2012-02-10 16:39 ` [PATCH 0/3 v2] " Zbigniew Jędrzejewski-Szmek
2012-02-10 16:39 ` [PATCH 1/3] Move git_version_string to help.c before diff changes Zbigniew Jędrzejewski-Szmek
2012-02-10 17:58 ` Junio C Hamano
2012-02-10 16:39 ` [PATCH 2/3] help.c: make term_columns() cached and export it Zbigniew Jędrzejewski-Szmek
2012-02-11 4:36 ` Nguyen Thai Ngoc Duy
2012-02-11 10:49 ` Zbigniew Jędrzejewski-Szmek
2012-02-12 9:40 ` Junio C Hamano
2012-02-12 14:12 ` [PATCH 1/2] Save terminal width before setting up pager and export term_columns() Zbigniew Jędrzejewski-Szmek
2012-02-13 23:00 ` Junio C Hamano
2012-02-14 11:44 ` Nguyen Thai Ngoc Duy
2012-02-14 11:53 ` Zbigniew Jędrzejewski-Szmek
2012-02-12 14:16 ` [PATCH 2/2] Rename lineno_width to decimal_width and export it Zbigniew Jędrzejewski-Szmek
2012-02-13 23:29 ` Junio C Hamano
2012-02-14 12:24 ` [PATCH v2] make lineno_width() from blame reusable for others Zbigniew Jędrzejewski-Szmek
2012-02-10 16:39 ` [PATCH 3/3] diff --stat: use the real terminal width Zbigniew Jędrzejewski-Szmek
2012-02-10 18:24 ` [PATCH 0/3 v2] " Junio C Hamano
2012-02-12 14:30 ` [PATCH v3] diff --stat: use the full " Zbigniew Jędrzejewski-Szmek
2012-02-14 1:08 ` Junio C Hamano
2012-02-14 23:45 ` [PATCH 1/3 v4] " Zbigniew Jędrzejewski-Szmek
2012-02-14 23:45 ` [PATCH 2/3 v4] diff --stat: better alignment for binary files Zbigniew Jędrzejewski-Szmek
2012-02-14 23:45 ` [PATCH 3/3 v4] Update diff --stat output in tests and tutorial Zbigniew Jędrzejewski-Szmek
2012-02-15 1:21 ` Junio C Hamano
2012-02-15 11:03 ` [PATCH 1/3 v5] diff --stat: tests for long filenames and big change counts Zbigniew Jędrzejewski-Szmek
2012-02-15 11:03 ` [PATCH 2/3 v5] diff --stat: use the full terminal width Zbigniew Jędrzejewski-Szmek
2012-02-15 18:07 ` Junio C Hamano
2012-02-15 11:03 ` [PATCH 3/3 v5] diff --stat: use less columns for change counts Zbigniew Jędrzejewski-Szmek
2012-02-15 12:12 ` Nguyen Thai Ngoc Duy [this message]
2012-02-15 17:12 ` [PATCH 1/3 v5] diff --stat: tests for long filenames and big " Junio C Hamano
2012-02-15 17:33 ` Junio C Hamano
2012-02-16 9:57 ` Zbigniew Jędrzejewski-Szmek
2012-02-16 20:01 ` Junio C Hamano
2012-02-15 0:07 ` [PATCH 1/3 v4] diff --stat: use the full terminal width Junio C Hamano
2012-02-15 1:18 ` Junio C Hamano
2012-02-15 7:39 ` Johannes Sixt
2012-02-09 23:58 ` [PATCH 4/4] diff --stat: use most of the space for file names Zbigniew Jędrzejewski-Szmek
2012-02-10 0:55 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACsJy8D4sWm8iprprbjU7X5RyPE4fbqiU2f70idByRmpkh70wA@mail.gmail.com \
--to=pclouds@gmail.com \
--cc=git@drmicha.warpmail.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=zbyszek@in.waw.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).