From mboxrd@z Thu Jan 1 00:00:00 1970 From: Duy Nguyen Subject: Re: [RFC] pack-objects: compression level for non-blobs Date: Wed, 2 Jan 2013 09:23:39 +0700 Message-ID: References: <1353911154-23495-1-git-send-email-b@rr-dav.id.au> <20121229004104.GA24828@sigill.intra.peff.net> <20121229050707.GA14475@sigill.intra.peff.net> <20121229052747.GA14928@sigill.intra.peff.net> <20121230120542.GA10820@sigill.intra.peff.net> <20121230213124.GA15946@sigill.intra.peff.net> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Cc: Jeff King , David Michael Barr , Git Mailing List , Junio C Hamano To: Shawn Pearce X-From: git-owner@vger.kernel.org Wed Jan 02 03:24:35 2013 Return-path: Envelope-to: gcvg-git-2@plane.gmane.org Received: from vger.kernel.org ([209.132.180.67]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1TqE0M-0001hu-Nh for gcvg-git-2@plane.gmane.org; Wed, 02 Jan 2013 03:24:31 +0100 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752484Ab3ABCYL (ORCPT ); Tue, 1 Jan 2013 21:24:11 -0500 Received: from mail-ob0-f181.google.com ([209.85.214.181]:63005 "EHLO mail-ob0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752415Ab3ABCYK (ORCPT ); Tue, 1 Jan 2013 21:24:10 -0500 Received: by mail-ob0-f181.google.com with SMTP id oi10so12158210obb.40 for ; Tue, 01 Jan 2013 18:24:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type; bh=cvpAFca/VMe5V10epvhjGG5Z7y3j4up7evV+b0JZB0Q=; b=GzGNxWuQ0txDTpee+Z34Qn3e/TWYMZ9zSoXGU7zwoIX8WBc45EJ37UruW7Abz4b+xv /G+sX6vMwn/HTpDk5m7MBproIIW+M6Dx4HnUkZRy7GQa6t40lkIyoQtv8K7mQI++7PvT 50Hxy67lg1EXvracVxGijD4TQJ9z/iedJfuwunSCRHvDA0T9bkYKaKusLYPojNvpp4kK ClABXfDP9rCfbw3A1+Kn032J9YNqjAYQkmUC45ZLTI/9EBQqJzhiW6Owk39bY/RLswbh jWKAfpFlr3EgfSTaIkHb2atlRstuaCMPKT7TMXfiKZc7OlPPCf26MSux46Fnl88kAXMX +kJA== Received: by 10.182.212.2 with SMTP id ng2mr36342346obc.81.1357093449153; Tue, 01 Jan 2013 18:24:09 -0800 (PST) Received: by 10.182.27.168 with HTTP; Tue, 1 Jan 2013 18:23:39 -0800 (PST) In-Reply-To: Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Archived-At: On Wed, Jan 2, 2013 at 12:17 AM, Shawn Pearce wrote: >> And I was wrong. At least since 1b4bb16 (pack-objects: optimize >> "recency order" - 2011-06-30) commits are spread out and can be mixed >> with trees too. Grouping them back defeats what Junio did in that >> commit, I think. > > I think you misunderstand what 1b4bb16 does. Junio uses a layout > similar to what JGit has done for years. Commits are packed, then > trees, then blobs. Only annotated tags are interspersed with commits. > The decision on where to place tags is different, but has a similar > purpose. This is embarrassing. I looked at verify-pack output and somehow saw trees mixed with commits. I must have read it wrong. "git verify-pack -v |awk '{print $2;}'|uniq on recently created pack shows that only tags and commits are mixed. Sorry for the noise. -- Duy