Re: [PATCH 1/2] entry.c: convert checkout_entry to use strbuf

[Duy Nguyen <pclouds@gmail.com>]

On Wed, Oct 23, 2013 at 7:58 PM, Antoine Pelisse <apelisse@gmail.com> wrote:
>> diff --git a/entry.c b/entry.c
>> index acc892f..d955af5 100644
>> --- a/entry.c
>> +++ b/entry.c
>> @@ -237,16 +237,18 @@ static int check_path(const char *path, int len, struct stat *st, int skiplen)
>>  int checkout_entry(struct cache_entry *ce,
>>                    const struct checkout *state, char *topath)
>>  {
>> -       static char path[PATH_MAX + 1];
>> +       static struct strbuf path_buf = STRBUF_INIT;
>> +       char *path;
>>         struct stat st;
>> -       int len = state->base_dir_len;
>> +       int len;
>>
>>         if (topath)
>>                 return write_entry(ce, topath, state, 1);
>>
>> -       memcpy(path, state->base_dir, len);
>> -       strcpy(path + len, ce->name);
>> -       len += ce_namelen(ce);
>> +       strbuf_reset(&path_buf);
>
> I think this is not required

If you mean strbuf_reset, I think it is. path_buf is still static (I
don't want to remove that because it'll add a lot more strbuf_release)
so we can't be sure what it contains from the second checkout_entry()
call.
-- 
Duy

-- 
-- 
*** Please reply-to-all at all times ***
*** (do not pretend to know who is subscribed and who is not) ***
*** Please avoid top-posting. ***
The msysGit Wiki is here: https://github.com/msysgit/msysgit/wiki - Github accounts are free.

You received this message because you are subscribed to the Google
Groups "msysGit" group.
To post to this group, send email to msysgit@googlegroups.com
To unsubscribe from this group, send email to
msysgit+unsubscribe@googlegroups.com
For more options, and view previous threads, visit this group at
http://groups.google.com/group/msysgit?hl=en_US?hl=en

--- 
You received this message because you are subscribed to the Google Groups "msysGit" group.
To unsubscribe from this group and stop receiving emails from it, send an email to msysgit+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.