From: Duy Nguyen <pclouds@gmail.com>
To: hanwen@google.com
Cc: Git Mailing List <git@vger.kernel.org>
Subject: Re: [PATCH 1/1] Highlight keywords in remote sideband output.
Date: Mon, 30 Jul 2018 16:52:40 +0200 [thread overview]
Message-ID: <CACsJy8CSh5uqWepdY7wCzP024WYcRFM719uXoKzJ4oziHHxwjw@mail.gmail.com> (raw)
In-Reply-To: <20180730123334.65186-2-hanwen@google.com>
On Mon, Jul 30, 2018 at 2:34 PM Han-Wen Nienhuys <hanwen@google.com> wrote:
> + struct kwtable {
> + const char *keyword;
> + const char *color;
> + } keywords[] = {
> + {"hint", GIT_COLOR_YELLOW},
> + {"warning", GIT_COLOR_BOLD_YELLOW},
> + {"success", GIT_COLOR_BOLD_GREEN},
> + {"error", GIT_COLOR_BOLD_RED},
> + };
Please let me customize these colors. "grep color.*slot
Documentation/config.txt help.c" could give you a few examples.
I think we also add a space after { and before } in most places (there
are a few places that don't do that, but personally I'd prefer spaces
to make it a bit easier to read).
--
Duy
next prev parent reply other threads:[~2018-07-30 14:53 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-30 12:33 [PATCH 0/1] Highlight keywords in remote sideband output Han-Wen Nienhuys
2018-07-30 12:33 ` [PATCH 1/1] " Han-Wen Nienhuys
2018-07-30 14:52 ` Duy Nguyen [this message]
2018-07-31 1:03 ` brian m. carlson
2018-07-30 21:39 ` Junio C Hamano
2018-07-31 11:03 ` Han-Wen Nienhuys
2018-07-31 14:59 ` Junio C Hamano
2018-07-31 7:37 ` Ævar Arnfjörð Bjarmason
2018-07-31 15:06 ` Duy Nguyen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACsJy8CSh5uqWepdY7wCzP024WYcRFM719uXoKzJ4oziHHxwjw@mail.gmail.com \
--to=pclouds@gmail.com \
--cc=git@vger.kernel.org \
--cc=hanwen@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).