From: Duy Nguyen <pclouds@gmail.com>
To: "Michal Suchánek" <msuchanek@suse.de>
Cc: Git Mailing List <git@vger.kernel.org>,
Eric Sunshine <sunshine@sunshineco.com>,
Marketa Calabkova <mcalabkova@suse.cz>,
Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH 2/2] setup: don't fail if commondir reference is deleted.
Date: Fri, 22 Feb 2019 16:26:10 +0700 [thread overview]
Message-ID: <CACsJy8CGtYe-d_0gXg4HLqvE6eR62yXsX-abz8NZ-Ln_+VdUqQ@mail.gmail.com> (raw)
In-Reply-To: <20190221145056.53b98b2a@kitsune.suse.cz>
On Thu, Feb 21, 2019 at 8:50 PM Michal Suchánek <msuchanek@suse.de> wrote:
>
> On Thu, 21 Feb 2019 17:50:38 +0700
> Duy Nguyen <pclouds@gmail.com> wrote:
>
> > On Tue, Feb 19, 2019 at 12:05 AM Michal Suchanek <msuchanek@suse.de> wrote:
> > >
> > > When adding wotktrees git can die in get_common_dir_noenv while
> > > examining existing worktrees because the commondir file does not exist.
> > > Rather than testing if the file exists before reading it handle ENOENT.
> >
> > I don't think we could go around fixing every access to incomplete
> > worktrees like this. If this is because of racy 'worktree add', then
> > perhaps a better solution is make it absolutely clear it's not ready
> > for anybody to access.
> >
> > For example, we can suffix the worktree directory name with ".lock"
> > and make sure get_worktrees() ignores entries ending with ".lock".
> > That should protect other commands while 'worktree add' is still
> > running. Only when the worktree is complete that 'worktree add' should
> > rename the directory to lose ".lock" and run external commands like
> > git-checkout to populate the worktree.
>
> The problem is we don't forbid worktree names ending with ".lock".
> Which means that if we start to forbid them now existing worktrees
> might become inaccessible.
Worktrees ending with .lock will not work well now anyway. While [1]
reports the problem with worktree names having a whitespace, ".lock"
is in the same class (not a valid refname) and will result the same
error. So if you have "*.lock" worktrees now you're already in
trouble.
[1] https://public-inbox.org/git/1550673274.30738.0@yandex.ru/T/#m9d86e0a388fd4961bc102c2c69e8bc3b2db07a42
--
Duy
next prev parent reply other threads:[~2019-02-22 9:26 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-18 17:04 [PATCH 0/2] worktree add race fix Michal Suchanek
2019-02-18 17:04 ` [PATCH 1/2] worktree: fix worktree add race Michal Suchanek
2019-02-18 17:04 ` [PATCH 2/2] setup: don't fail if commondir reference is deleted Michal Suchanek
2019-02-18 21:00 ` Eric Sunshine
2019-02-21 10:50 ` Duy Nguyen
2019-02-21 13:50 ` Michal Suchánek
2019-02-21 17:07 ` Phillip Wood
2019-02-21 17:12 ` Eric Sunshine
2019-02-21 17:27 ` Phillip Wood
2019-03-04 13:30 ` Michal Suchánek
2019-02-21 17:33 ` Michal Suchánek
2019-02-22 9:32 ` Duy Nguyen
2019-02-22 10:20 ` Phillip Wood
2019-02-22 9:26 ` Duy Nguyen [this message]
2019-02-20 16:16 ` [PATCH v3 1/2] worktree: fix worktree add race Michal Suchanek
2019-02-20 16:34 ` Eric Sunshine
2019-02-20 17:29 ` Michal Suchánek
2019-03-08 9:20 ` Duy Nguyen
2019-03-08 9:37 ` Eric Sunshine
2019-03-11 1:55 ` Junio C Hamano
2019-02-20 16:16 ` [PATCH v3 2/2] setup: don't fail if commondir reference is deleted Michal Suchanek
2019-02-20 16:55 ` Eric Sunshine
2019-02-20 17:16 ` Michal Suchánek
2019-02-20 18:35 ` Eric Sunshine
2019-02-21 9:27 ` Eric Sunshine
2019-02-21 11:13 ` Michal Suchánek
2019-02-21 11:19 ` Michal Suchánek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACsJy8CGtYe-d_0gXg4HLqvE6eR62yXsX-abz8NZ-Ln_+VdUqQ@mail.gmail.com \
--to=pclouds@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=mcalabkova@suse.cz \
--cc=msuchanek@suse.de \
--cc=sunshine@sunshineco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).