From: Duy Nguyen <pclouds@gmail.com>
To: Stefan Beller <sbeller@google.com>
Cc: Junio C Hamano <gitster@pobox.com>, Jeff King <peff@peff.net>,
Lars Schneider <larsxschneider@gmail.com>,
"git@vger.kernel.org" <git@vger.kernel.org>
Subject: Re: [PATCH v2] add test to demonstrate that shallow recursive clones fail
Date: Tue, 1 Dec 2015 13:15:36 +0100 [thread overview]
Message-ID: <CACsJy8CFCu4casNn25b1YPkV==-8kDy3wzYd5uf794R41M0Y9w@mail.gmail.com> (raw)
In-Reply-To: <CAGZ79kYY5FbvMpa2vOun7-h4S2cJvZLn67uPGYVbje55R4dFSg@mail.gmail.com>
On Tue, Dec 1, 2015 at 1:47 AM, Stefan Beller <sbeller@google.com> wrote:
> On Mon, Nov 30, 2015 at 10:11 AM, Junio C Hamano <gitster@pobox.com> wrote:
>> Stefan Beller <sbeller@google.com> writes:
>>
>>> +cc Junio, Duy
>>>
>>> So cloning from an arbitrary SHA1 is not a new thing I just came up with,
>>> but has been discussed before[1].
>>>
>>> Junio wrote on Oct 09, 2014:
>>>> This is so non-standard a thing to do that I doubt it is worth
>>>> supporting with "git clone". "git clone --branch", which is about
>>> "> I want to follow that particular branch", would not mesh well with
>>>> "I want to see the history that leads to this exact commit", either.
>>>> You would not know which branch(es) is that exact commit is on in
>>>> the first place.
>>>
>>> I disagree with this. This is the *exact* thing you actually want to do when
>>> dealing with submodules.
>>
>> Yup, I know, but I do not think the above disagrees with you (read
>> again ;-). It merely says "--branch" option to "clone" is not a
>> good place to add a new "clone at this single commit" mode of
>> operation.
>
> Ok. So maybe a bit of bike shedding time:
>
> How does
>
> git clone --detached-head <sha1>
maybe
git clone --commit-id <sha1> repo (*)
instead. Detached head is implied, and this way you don't have to
disambiguate sha-1 vs refname. And --commit-id can also be added in
git-fetch. Actually the git-fetch case is even more interesting, what
do we do with refspec..
(*) as usual, we accept committish sha-1, not just comit sha-1, so
--commit-id may be confusing..? Or maybe just go with --tag where we
accept either tag names, tag sha-1 or commit-sha1
> sound? I would imagine that this would either present you with a fresh clone
> with a detached head at the specified sha1, or if the server doesn't support
> getting a specific sha1, it would error out.
--
Duy
next prev parent reply other threads:[~2015-12-01 12:16 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-12 9:37 [PATCH v2] add test to demonstrate that shallow recursive clones fail larsxschneider
2015-11-12 23:34 ` Stefan Beller
2015-11-15 12:43 ` Lars Schneider
2015-11-13 5:35 ` Jeff King
2015-11-13 18:41 ` Stefan Beller
2015-11-13 23:16 ` Stefan Beller
2015-11-13 23:38 ` Jeff King
2015-11-13 23:41 ` Jeff King
2015-11-14 0:10 ` Stefan Beller
2015-11-16 18:59 ` Jens Lehmann
2015-11-16 19:25 ` Stefan Beller
2015-11-16 21:42 ` Jens Lehmann
2015-11-16 22:56 ` Stefan Beller
2015-11-17 19:46 ` Jens Lehmann
2015-11-17 20:04 ` Stefan Beller
2015-11-17 20:39 ` Jens Lehmann
2015-11-17 20:49 ` Stefan Beller
2015-11-17 21:00 ` Jens Lehmann
2015-11-17 20:17 ` Duy Nguyen
2015-11-17 21:43 ` Jeff King
2015-11-18 12:32 ` Duy Nguyen
2015-11-18 21:11 ` Jeff King
2015-11-18 21:36 ` Stefan Beller
[not found] ` <CAOE36qj2m4e3hw73-QoLbbpGv4RiyhBt_ou7eN4i4q8pF15rdA@mail.gmail.com>
2015-11-19 13:58 ` Jeff King
2015-11-30 18:11 ` Junio C Hamano
2015-12-01 0:47 ` Stefan Beller
2015-12-01 12:15 ` Duy Nguyen [this message]
2015-12-01 21:47 ` Junio C Hamano
2015-12-01 22:22 ` Junio C Hamano
2015-12-03 20:03 ` Stefan Beller
2015-12-04 15:32 ` Junio C Hamano
2015-12-04 16:15 ` Junio C Hamano
2015-12-04 7:52 ` Duy Nguyen
2015-11-15 12:53 ` Lars Schneider
2015-11-17 21:34 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACsJy8CFCu4casNn25b1YPkV==-8kDy3wzYd5uf794R41M0Y9w@mail.gmail.com' \
--to=pclouds@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=larsxschneider@gmail.com \
--cc=peff@peff.net \
--cc=sbeller@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).