git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
* Silent failure to add Windows-style paths in Cygwin Git
@ 2016-04-20  9:17 Adam Dinwoodie
  0 siblings, 0 replies; 3+ messages in thread
From: Adam Dinwoodie @ 2016-04-20  9:17 UTC (permalink / raw)
  To: git

If I attempt to `git add` an extant file specified using a Windows-style
path on Cygwin Git, this doesn't add the file, and produces no error
message:

    $ pwd  # As seen by Cygwin
    /cygdrive/c/tmp

    $ cygpath -aw .  # As seen by Windows
    C:\tmp

    $ git init
    Initialized empty Git repository in /cygdrive/c/tmp/.git/

    $ git add 'c:\tmp\file' || echo non-zero exit code  # Errors out as expected
    fatal: pathspec 'c:\tmp\file' did not match any files
    non-zero exit code

    $ touch file

    $ git add 'c:\tmp\file' || echo non-zero exit code  # No error this time...

    $ git status  # ...even though the file didn't get added
    On branch master

    Initial commit

    Untracked files:
      (use "git add <file>..." to include in what will be committed)

            file

    nothing added to commit but untracked files present (use "git add" to track)

I wouldn't expect adding the file to actually succeed, but I would
expect it to either succeed or produce an error, rather than silently
failing.

Experimentation shows I get the same behaviour for 'c:\tmp\file',
'c:/tmp/file' and 'subdir\file'.  I'm seeing this on v2.8.0; the
downstream report says the same behaviour occurs on v2.7.4[0], and I've
also seen what appears to be the same behaviour on a v2.0.5 build I
produced to check.

Adam

[0]: https://cygwin.com/ml/cygwin/2016-04/msg00474.html

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Silent failure to add Windows-style paths in Cygwin Git
@ 2016-04-25 12:07 Adam Dinwoodie
  2016-04-25 12:18 ` Duy Nguyen
  0 siblings, 1 reply; 3+ messages in thread
From: Adam Dinwoodie @ 2016-04-25 12:07 UTC (permalink / raw)
  To: git

[Resending as my initial attempt appears to have not made it to the
list.  Apologies if this results in a double-post.]

If I attempt to `git add` an extant file specified using a Windows-style
path on Cygwin Git, this doesn't add the file, and produces no error
message:

    $ pwd  # As seen by Cygwin
    /cygdrive/c/tmp

    $ cygpath -aw .  # As seen by Windows
    C:\tmp

    $ git init
    Initialized empty Git repository in /cygdrive/c/tmp/.git/

    $ git add 'c:\tmp\file' || echo non-zero exit code  # Errors out as expected
    fatal: pathspec 'c:\tmp\file' did not match any files
    non-zero exit code

    $ touch file

    $ git add 'c:\tmp\file' || echo non-zero exit code  # No error this time...

    $ git status  # ...even though the file didn't get added
    On branch master

    Initial commit

    Untracked files:
      (use "git add <file>..." to include in what will be committed)

            file

    nothing added to commit but untracked files present (use "git add" to track)

I wouldn't expect adding the file to actually succeed, but I would
expect it to either succeed or produce an error, rather than silently
failing.

Experimentation shows I get the same behaviour for 'c:\tmp\file',
'c:/tmp/file' and 'subdir\file'.  I'm seeing this on v2.8.0; the
downstream report says the same behaviour occurs on v2.7.4[0], and I've
also seen what appears to be the same behaviour on a v2.0.5 build I
produced to check.

Adam

[0]: https://cygwin.com/ml/cygwin/2016-04/msg00474.html

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: Silent failure to add Windows-style paths in Cygwin Git
  2016-04-25 12:07 Silent failure to add Windows-style paths in Cygwin Git Adam Dinwoodie
@ 2016-04-25 12:18 ` Duy Nguyen
  0 siblings, 0 replies; 3+ messages in thread
From: Duy Nguyen @ 2016-04-25 12:18 UTC (permalink / raw)
  To: Adam Dinwoodie; +Cc: Git Mailing List

On Mon, Apr 25, 2016 at 7:07 PM, Adam Dinwoodie <adam@dinwoodie.org> wrote:
> [Resending as my initial attempt appears to have not made it to the
> list.  Apologies if this results in a double-post.]
>
> If I attempt to `git add` an extant file specified using a Windows-style
> path on Cygwin Git, this doesn't add the file, and produces no error
> message:
>
>     ...
>
> I wouldn't expect adding the file to actually succeed, but I would
> expect it to either succeed or produce an error, rather than silently
> failing.
>
> Experimentation shows I get the same behaviour for 'c:\tmp\file',
> 'c:/tmp/file' and 'subdir\file'.  I'm seeing this on v2.8.0; the
> downstream report says the same behaviour occurs on v2.7.4[0], and I've
> also seen what appears to be the same behaviour on a v2.0.5 build I
> produced to check.

Can you try git-bisect if possible? An strace log may be helpful
otherwise (looks like strace is supported on cygwin, but I don't know
to what level)
-- 
Duy

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2016-04-25 12:18 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-04-25 12:07 Silent failure to add Windows-style paths in Cygwin Git Adam Dinwoodie
2016-04-25 12:18 ` Duy Nguyen
  -- strict thread matches above, loose matches on Subject: below --
2016-04-20  9:17 Adam Dinwoodie

Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).