From: Duy Nguyen <pclouds@gmail.com>
To: Jonathan Tan <jonathantanmy@google.com>
Cc: Stefan Beller <sbeller@google.com>,
Git Mailing List <git@vger.kernel.org>,
Junio C Hamano <gitster@pobox.com>,
Jameson Miller <jamill@microsoft.com>
Subject: Re: [PATCH v3 13/13] alloc: allow arbitrary repositories for alloc functions
Date: Wed, 9 May 2018 19:18:06 +0200 [thread overview]
Message-ID: <CACsJy8C7N2W821H8YR8VaKdCSOSCDtQi_YT7z8hHNDO-VxJmEA@mail.gmail.com> (raw)
In-Reply-To: <20180508130431.287a9f273a847c375b3b1e2b@google.com>
On Tue, May 8, 2018 at 10:04 PM, Jonathan Tan <jonathantanmy@google.com> wrote:
> On Tue, 8 May 2018 12:37:36 -0700
> Stefan Beller <sbeller@google.com> wrote:
>
>> +void clear_alloc_state(struct alloc_state *s)
>> +{
>> + while (s->slab_nr > 0) {
>> + s->slab_nr--;
>> + free(s->slabs[s->slab_nr]);
>> + }
>
> I should have caught this earlier, but you need to free s->slabs itself
> too.
And nobody frees 's' either. I'm not saying cler_alloc_state() should,
but somebody should. When I tried repo_clear(the_repository) with
gitster/sb/object-store-alloc I got this
==13250== 944 (32 direct, 912 indirect) bytes in 1 blocks are
definitely lost in loss record 62 of 88
==13250== at 0x4C2CF25: calloc (vg_replace_malloc.c:718)
==13250== by 0x1AB7A8: xcalloc (wrapper.c:160)
==13250== by 0x1BF666: allocate_alloc_state (alloc.c:41)
==13250== by 0x140090: parsed_object_pool_new (object.c:462)
==13250== by 0x16CCF4: initialize_the_repository (repository.c:18)
==13250== by 0x110BD0: main (common-main.c:37)
If you want to reproduce, this is what I used to test this with.
https://gist.github.com/pclouds/86a2df6c28043f1b6fa3d4e72e7a1276
--
Duy
next prev parent reply other threads:[~2018-05-09 17:18 UTC|newest]
Thread overview: 95+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-01 21:33 [PATCH 00/13] object store: alloc Stefan Beller
2018-05-01 21:33 ` [PATCH 01/13] repository: introduce object parser field Stefan Beller
2018-05-02 17:17 ` Duy Nguyen
2018-05-02 17:26 ` Stefan Beller
2018-05-02 17:58 ` Duy Nguyen
2018-05-02 20:30 ` Jonathan Tan
2018-05-01 21:33 ` [PATCH 02/13] object: add repository argument to create_object Stefan Beller
2018-05-01 21:43 ` Eric Sunshine
2018-05-01 21:33 ` [PATCH 03/13] object: add repository argument to grow_object_hash Stefan Beller
2018-05-01 21:33 ` [PATCH 04/13] alloc: add repository argument to alloc_blob_node Stefan Beller
2018-05-02 20:34 ` Jonathan Tan
2018-05-01 21:33 ` [PATCH 05/13] alloc: add repository argument to alloc_tree_node Stefan Beller
2018-05-01 21:33 ` [PATCH 06/13] alloc: add repository argument to alloc_commit_node Stefan Beller
2018-05-01 21:33 ` [PATCH 07/13] alloc: add repository argument to alloc_tag_node Stefan Beller
2018-05-01 21:33 ` [PATCH 08/13] alloc: add repository argument to alloc_object_node Stefan Beller
2018-05-01 21:33 ` [PATCH 09/13] alloc: add repository argument to alloc_report Stefan Beller
2018-05-01 21:34 ` [PATCH 10/13] alloc: add repository argument to alloc_commit_index Stefan Beller
2018-05-01 21:34 ` [PATCH 11/13] object: allow grow_object_hash to handle arbitrary repositories Stefan Beller
2018-05-01 21:34 ` [PATCH 12/13] object: allow create_object " Stefan Beller
2018-05-02 20:36 ` Jonathan Tan
2018-05-01 21:34 ` [PATCH 13/13] alloc: allow arbitrary repositories for alloc functions Stefan Beller
2018-05-02 17:44 ` Duy Nguyen
2018-05-03 17:24 ` Stefan Beller
2018-05-03 17:35 ` Duy Nguyen
2018-05-02 20:50 ` Jonathan Tan
2018-05-03 17:25 ` Stefan Beller
2018-05-03 14:58 ` Duy Nguyen
2018-05-02 17:01 ` [PATCH 00/13] object store: alloc Duy Nguyen
2018-05-02 18:07 ` Jameson Miller
2018-05-02 18:22 ` Duy Nguyen
2018-05-02 18:44 ` Jameson Miller
2018-05-03 22:45 ` Stefan Beller
2018-05-07 14:05 ` Junio C Hamano
2018-05-07 20:53 ` Stefan Beller
2018-05-07 22:59 ` [PATCH v2 " Stefan Beller
2018-05-07 22:59 ` [PATCH v2 01/13] repository: introduce parsed objects field Stefan Beller
2018-05-08 17:23 ` Jonathan Tan
2018-05-07 22:59 ` [PATCH v2 02/13] object: add repository argument to create_object Stefan Beller
2018-05-07 22:59 ` [PATCH v2 03/13] object: add repository argument to grow_object_hash Stefan Beller
2018-05-07 22:59 ` [PATCH v2 04/13] alloc: add repository argument to alloc_blob_node Stefan Beller
2018-05-07 22:59 ` [PATCH v2 05/13] alloc: add repository argument to alloc_tree_node Stefan Beller
2018-05-07 22:59 ` [PATCH v2 06/13] alloc: add repository argument to alloc_commit_node Stefan Beller
2018-05-07 22:59 ` [PATCH v2 07/13] alloc: add repository argument to alloc_tag_node Stefan Beller
2018-05-07 22:59 ` [PATCH v2 08/13] alloc: add repository argument to alloc_object_node Stefan Beller
2018-05-07 22:59 ` [PATCH v2 09/13] alloc: add repository argument to alloc_report Stefan Beller
2018-05-07 22:59 ` [PATCH v2 10/13] alloc: add repository argument to alloc_commit_index Stefan Beller
2018-05-07 22:59 ` [PATCH v2 11/13] object: allow grow_object_hash to handle arbitrary repositories Stefan Beller
2018-05-07 22:59 ` [PATCH v2 12/13] object: allow create_object " Stefan Beller
2018-05-07 22:59 ` [PATCH v2 13/13] alloc: allow arbitrary repositories for alloc functions Stefan Beller
2018-05-08 10:10 ` Jeff King
2018-05-08 15:00 ` Duy Nguyen
2018-05-08 18:38 ` Stefan Beller
2018-05-08 17:45 ` Jonathan Tan
2018-05-08 19:37 ` [PATCH v3 00/13] object store: alloc Stefan Beller
2018-05-08 19:37 ` [PATCH v3 01/13] repository: introduce parsed objects field Stefan Beller
2018-05-08 19:37 ` [PATCH v3 02/13] object: add repository argument to create_object Stefan Beller
2018-05-08 19:37 ` [PATCH v3 03/13] object: add repository argument to grow_object_hash Stefan Beller
2018-05-08 19:37 ` [PATCH v3 04/13] alloc: add repository argument to alloc_blob_node Stefan Beller
2018-05-08 19:37 ` [PATCH v3 05/13] alloc: add repository argument to alloc_tree_node Stefan Beller
2018-05-08 19:37 ` [PATCH v3 06/13] alloc: add repository argument to alloc_commit_node Stefan Beller
2018-05-08 19:37 ` [PATCH v3 07/13] alloc: add repository argument to alloc_tag_node Stefan Beller
2018-05-08 19:37 ` [PATCH v3 08/13] alloc: add repository argument to alloc_object_node Stefan Beller
2018-05-08 19:37 ` [PATCH v3 09/13] alloc: add repository argument to alloc_report Stefan Beller
2018-05-08 19:37 ` [PATCH v3 10/13] alloc: add repository argument to alloc_commit_index Stefan Beller
2018-05-08 19:37 ` [PATCH v3 11/13] object: allow grow_object_hash to handle arbitrary repositories Stefan Beller
2018-05-08 19:37 ` [PATCH v3 12/13] object: allow create_object " Stefan Beller
2018-05-08 19:37 ` [PATCH v3 13/13] alloc: allow arbitrary repositories for alloc functions Stefan Beller
2018-05-08 20:04 ` Jonathan Tan
2018-05-08 20:37 ` Stefan Beller
2018-05-09 15:54 ` Duy Nguyen
2018-05-09 17:18 ` Duy Nguyen [this message]
2018-05-09 19:20 ` Stefan Beller
2018-05-10 15:43 ` Duy Nguyen
2018-05-10 0:40 ` [PATCH v4 00/13] object store: alloc Stefan Beller
2018-05-10 0:40 ` [PATCH v4 01/13] repository: introduce parsed objects field Stefan Beller
2018-05-10 0:40 ` [PATCH v4 02/13] object: add repository argument to create_object Stefan Beller
2018-05-10 0:40 ` [PATCH v4 03/13] object: add repository argument to grow_object_hash Stefan Beller
2018-05-10 0:40 ` [PATCH v4 04/13] alloc: add repository argument to alloc_blob_node Stefan Beller
2018-05-10 0:40 ` [PATCH v4 05/13] alloc: add repository argument to alloc_tree_node Stefan Beller
2018-05-10 0:40 ` [PATCH v4 06/13] alloc: add repository argument to alloc_commit_node Stefan Beller
2018-05-10 0:40 ` [PATCH v4 07/13] alloc: add repository argument to alloc_tag_node Stefan Beller
2018-05-10 0:40 ` [PATCH v4 08/13] alloc: add repository argument to alloc_object_node Stefan Beller
2018-05-10 0:40 ` [PATCH v4 09/13] alloc: add repository argument to alloc_report Stefan Beller
2018-05-10 0:40 ` [PATCH v4 10/13] alloc: add repository argument to alloc_commit_index Stefan Beller
2018-05-10 0:40 ` [PATCH v4 11/13] object: allow grow_object_hash to handle arbitrary repositories Stefan Beller
2018-05-10 0:40 ` [PATCH v4 12/13] object: allow create_object " Stefan Beller
2018-05-10 0:40 ` [PATCH v4 13/13] alloc: allow arbitrary repositories for alloc functions Stefan Beller
2018-05-10 17:16 ` [PATCH v4 00/13] object store: alloc Jonathan Tan
2018-05-10 17:32 ` Stefan Beller
2018-05-10 20:56 ` Jonathan Tan
2018-05-10 22:36 ` Stefan Beller
2018-05-11 19:17 ` [PATCH] alloc: allow arbitrary repositories for alloc functions Stefan Beller
2018-05-11 19:38 ` Eric Sunshine
2018-05-15 21:48 ` Stefan Beller
2018-05-16 2:27 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACsJy8C7N2W821H8YR8VaKdCSOSCDtQi_YT7z8hHNDO-VxJmEA@mail.gmail.com \
--to=pclouds@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jamill@microsoft.com \
--cc=jonathantanmy@google.com \
--cc=sbeller@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).