From: Duy Nguyen <pclouds@gmail.com>
To: Jeremy Linton <lintonrjeremy@gmail.com>
Cc: Git Mailing List <git@vger.kernel.org>,
Jonathan Tan <jonathantanmy@google.com>,
Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH] packfile: Correct zlib buffer handling
Date: Sat, 26 May 2018 07:51:55 +0200 [thread overview]
Message-ID: <CACsJy8C4zNZAe6Vw-mz8r8HueYdQKs4ZhMOQYX0v7ypfHdmShg@mail.gmail.com> (raw)
In-Reply-To: <20180525225601.22575-1-lintonrjeremy@gmail.com>
On Sat, May 26, 2018 at 12:56 AM, Jeremy Linton <lintonrjeremy@gmail.com> wrote:
> @@ -1416,7 +1416,7 @@ static void *unpack_compressed_entry(struct packed_git *p,
> return NULL;
> memset(&stream, 0, sizeof(stream));
> stream.next_out = buffer;
> - stream.avail_out = size + 1;
> + stream.avail_out = size;
You may want to include in your commit message a reference to
39eea7bdd9 (Fix incorrect error check while reading deflated pack data
- 2009-10-21) which adds this plus one with a fascinating story
behind.
--
Duy
next prev parent reply other threads:[~2018-05-26 5:52 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-25 22:56 [PATCH] packfile: Correct zlib buffer handling Jeremy Linton
2018-05-26 5:51 ` Duy Nguyen [this message]
2018-05-26 23:57 ` Junio C Hamano
2018-05-27 5:02 ` Duy Nguyen
2018-05-27 11:53 ` Junio C Hamano
2018-05-28 2:41 ` Junio C Hamano
2018-06-13 1:04 ` Jeremy Linton
-- strict thread matches above, loose matches on Subject: below --
2018-05-25 23:17 Jeremy Linton
2018-05-25 23:36 ` Eric Sunshine
2018-05-26 1:06 ` Todd Zullinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACsJy8C4zNZAe6Vw-mz8r8HueYdQKs4ZhMOQYX0v7ypfHdmShg@mail.gmail.com \
--to=pclouds@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jonathantanmy@google.com \
--cc=lintonrjeremy@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).