From: Duy Nguyen <pclouds@gmail.com>
To: Justin Lebar <jlebar@google.com>
Cc: Git Mailing List <git@vger.kernel.org>,
Richard Hansen <rhansen@bbn.com>,
Jiang Xin <worldhello.net@gmail.com>
Subject: Re: [PATCH 0/6] Fix misuses of "nor"
Date: Sat, 15 Mar 2014 15:56:03 +0700 [thread overview]
Message-ID: <CACsJy8C2Qainuix2CXy7P71BxE1ajrzfxYMmNAyVa04mfSJJ-A@mail.gmail.com> (raw)
In-Reply-To: <1394872922-2000-1-git-send-email-jlebar@google.com>
On Sat, Mar 15, 2014 at 3:41 PM, Justin Lebar <jlebar@google.com> wrote:
> I got annoyed by git's awkward use of "nor" in man pages and in git add -p, so
> I went ahead and audited all uses of "nor" in the tree. One might be able to
> argue that some of the uses I've changed are technically acceptable, but that's
> a pretty low bar to set for ourselves. I aimed to make everything both correct
> and idiomatic.
I guess I'm cc'd because I made a few of those or/nor mistakes. Being
a non-native English speaker I'm not really qualified to review this.
But I suggest that you merge "Fix misuses of "nor" outside comments"
and "Tests: Fix muses of "nor"" into one. Otherwise you break the test
suite at 5/6 (and 6/6 fixes it, but breaking the test suite at any
commit is not very bisect-friendly).
--
Duy
next prev parent reply other threads:[~2014-03-15 8:56 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-15 8:41 [PATCH 0/6] Fix misuses of "nor" Justin Lebar
2014-03-15 8:41 ` [PATCH 1/6] Documentation: " Justin Lebar
2014-03-15 8:41 ` [PATCH 2/6] contrib: " Justin Lebar
2014-03-15 8:41 ` [PATCH 3/6] l10n: " Justin Lebar
2014-03-17 1:45 ` Jiang Xin
2014-03-17 2:43 ` Justin Lebar
2014-03-15 8:42 ` [PATCH 4/6] Fix misuses of "nor" in comments Justin Lebar
2014-03-15 8:42 ` [PATCH 5/6] Fix misuses of "nor" outside comments Justin Lebar
2014-03-15 8:42 ` [PATCH 6/6] Tests: Fix misuses of "nor" Justin Lebar
2014-03-15 8:56 ` Duy Nguyen [this message]
2014-03-15 16:56 ` [PATCH 0/6] " Justin Lebar
2014-03-15 23:45 ` Duy Nguyen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACsJy8C2Qainuix2CXy7P71BxE1ajrzfxYMmNAyVa04mfSJJ-A@mail.gmail.com \
--to=pclouds@gmail.com \
--cc=git@vger.kernel.org \
--cc=jlebar@google.com \
--cc=rhansen@bbn.com \
--cc=worldhello.net@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).